From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 366073382C4 for ; Wed, 28 Jan 2026 08:45:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769589909; cv=none; b=HlJ5+TYFPmm8ANM4m2eIvhutFfQNge1yv4FlUMqMdV2ewuq9ETSkdzaqDDIVVw/snPEbpcydfkrhE21AMuIWjoGD58Uu6KrCI0/hmuy8UmfZ28pVtgKAr7QCfwi0eyLy7ygEjDYMEN5gPa3xDgq8JqOe1gCk/h2FW8jHMfX2JDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769589909; c=relaxed/simple; bh=RmjPdOoSLN83hdmAOBaQ60Ic1/65Z53zJZ8NP4f3+Rw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LNmyCVXlsrKxweUql6H9b5y2Z6hQKsxu9dt/K3DXJioyu8Dd41oi4l/v/3TsfdaVnb+LRKCRXPgc667mGP08BEkAcXF6D5qsqso1ZZc13Btyz7VfzswTdFUBTIuIOPrCAruAX0x7tYP/+pfr9hdcjppG4C516FmQRQkTtjRRyG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SZIbsb4u; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SZIbsb4u" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4801eb2c0a5so63199185e9.3 for ; Wed, 28 Jan 2026 00:45:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769589905; x=1770194705; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yzZ5aaJur2cGbo3tv1Z3AlCZuGpqhSu9RlDH7L/IIPI=; b=SZIbsb4uqLo2GtuIKPa3bbLA7N6dH7jjl6viB/R0/10DmYtuzJlEe7d0Lgh3AsecRy Jb04vA7E9/uLgkJZj1z+cgSxI3Pw1kEmK8VTCRIPmIz0NhYj96oATGrLZoy7Q77sTuDw mGjKnzWQTVqorHggE4D4U6/8Mf1kmcypiioWs0sIzDr+ORIOuLY1V6G4ENM7uvS7yfSs ZNvihc9rHZx9imvV17/9Oe01/vYcd1kY83/3Hw76N9KkKngapUjdwLQYcCYYynsVx+y9 1Jbevjw8z6Hb9P7DLqp8t2bANC8o9Q00TSBYdZxWguV1RtcG2SS3gAKfvOKvJZxcgBXk 4HcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769589905; x=1770194705; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yzZ5aaJur2cGbo3tv1Z3AlCZuGpqhSu9RlDH7L/IIPI=; b=XhUUpP9Qs3erpe1AHAP192QVdhvmQFmS61wNdcICpH6+GCXDTVG0W0SlvYL0U5ReHI abVGrCpFkiTgBBIwkrEdkXz1gvHuySNOqhv6Kl2yR8U6FgCFsgo7VCks6Ne1Nzj9O/f2 W43Lwuhv5V0gO7aX8OAVltImujHeShjJcQad3makjl6hoSFWuOxVFEBu04DtQxtevcGV 5AJM9L2xFP9KKicsivsCtECFZrR+d0thzONt+c++4y1lAYcSpYxt60eBb0dFGYdFl2dh kC9glqZscvYjknmO13A8CBnRv+Pnr2c3JXwbT88CxXGboInME27T4MrpJkMIxEi11DUI qeFQ== X-Forwarded-Encrypted: i=1; AJvYcCUobFedgyU1a8YvMrX4gFSu9PIqqV5yrZX5xJEcF1k/c7JS142J8hWfd//dK+V4P9yCp+pYmMnc@vger.kernel.org X-Gm-Message-State: AOJu0YzWyKI/9vTIMzHoCt/q08LohUjteXV6yzgn+76+4sXknsSfnl2t 3dsmm42rDbtGtSMs9xYMtN8uWmFG4rwHw1FQvSP7SAqT8CNXjSlUEMskDNRbveXoalo= X-Gm-Gg: AZuq6aJ+vtFCnKAKDUwVOTlXUvMAgRbt6TK1u+Mb4nus2nat0lw3TdLvR2ka4TfVBz5 tYBDVaph13Dk9JT+fLvMuYXl8gcZWUcntiI2/3EK7N7KV7Ag6HXTyFT/UAHfLi31in0xebzmqpM C53jkF7jaq5Pa5UCugxnBCPCgiZCFgus99NL5ARXEWK2jGpKx6bR6WCqGlYNqivYpKuEJuAF9vS sgOhoS7Y2PJs4ebNxFI6FTGShLw9vCbR89uRS/+2g0KZAvDIUqwUcGvRtxNbmzbD/Dh7pEZKTiZ pLeul+MC5aw+pxguJFbqQ5nd0qr1vsjJt+I6ivmX4DNoWxKUUEFMPrE9NbXRIUn7Qf+pZAD215E T8xKsqCYnUNPyrTqJAO4h71aG5x+PBlzGmWVFZCtlHLD2TGrIVg3aKuziP020Us4yr7h2Ut4+Y3 K9+oPC0ResGRSBKtSG5lzRkj6F X-Received: by 2002:a05:600c:4e12:b0:480:6873:b2f6 with SMTP id 5b1f17b1804b1-48069c557d0mr54819185e9.20.1769589905328; Wed, 28 Jan 2026 00:45:05 -0800 (PST) Received: from localhost (109-81-26-156.rct.o2.cz. [109.81.26.156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066bee7d0sm121124905e9.4.2026.01.28.00.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 00:45:04 -0800 (PST) Date: Wed, 28 Jan 2026 09:45:03 +0100 From: Michal Hocko To: Frederic Weisbecker Cc: LKML , Michal =?iso-8859-1?Q?Koutn=FD?= , Andrew Morton , Bjorn Helgaas , Catalin Marinas , Chen Ridong , Danilo Krummrich , "David S . Miller" , Eric Dumazet , Gabriele Monaco , Greg Kroah-Hartman , Ingo Molnar , Jakub Kicinski , Jens Axboe , Johannes Weiner , Lai Jiangshan , Marco Crivellari , Muchun Song , Paolo Abeni , Peter Zijlstra , Phil Auld , "Rafael J . Wysocki" , Roman Gushchin , Shakeel Butt , Simon Horman , Tejun Heo , Thomas Gleixner , Vlastimil Babka , Waiman Long , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 03/33] memcg: Prepare to protect against concurrent isolated cpuset change Message-ID: References: <20260125224541.50226-1-frederic@kernel.org> <20260125224541.50226-4-frederic@kernel.org> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue 27-01-26 13:45:06, Frederic Weisbecker wrote: > Le Mon, Jan 26, 2026 at 05:41:38PM +0100, Michal Hocko a écrit : > > On Sun 25-01-26 23:45:10, Frederic Weisbecker wrote: > > > The HK_TYPE_DOMAIN housekeeping cpumask will soon be made modifiable at > > > runtime. In order to synchronize against memcg workqueue to make sure > > > that no asynchronous draining is pending or executing on a newly made > > > isolated CPU, target and queue a drain work under the same RCU critical > > > section. > > > > > > Whenever housekeeping will update the HK_TYPE_DOMAIN cpumask, a memcg > > > workqueue flush will also be issued in a further change to make sure > > > that no work remains pending after a CPU has been made isolated. > > > > > > Signed-off-by: Frederic Weisbecker > > > --- > > > mm/memcontrol.c | 21 +++++++++++++++++---- > > > 1 file changed, 17 insertions(+), 4 deletions(-) > > > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > index be810c1fbfc3..2289a0299331 100644 > > > --- a/mm/memcontrol.c > > > +++ b/mm/memcontrol.c > > > @@ -2003,6 +2003,19 @@ static bool is_memcg_drain_needed(struct memcg_stock_pcp *stock, > > > return flush; > > > } > > > > > > +static void schedule_drain_work(int cpu, struct work_struct *work) > > > +{ > > > + /* > > > + * Protect housekeeping cpumask read and work enqueue together > > > + * in the same RCU critical section so that later cpuset isolated > > > + * partition update only need to wait for an RCU GP and flush the > > > + * pending work on newly isolated CPUs. > > > + */ > > > + guard(rcu)(); > > > + if (!cpu_is_isolated(cpu)) > > > + schedule_work_on(cpu, work); > > > > Shouldn't this in the guarded rcu section? > > This is what guard(rcu)() does, right? > Or am I missing something? I am probably misreading the patch. But I've had the following in mind scoped_guard(rcu) { if (!cpu_is_isolated(cpu)) schedule_work_on(cpu, work); } -- Michal Hocko SUSE Labs