From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 523851FE47B for ; Sat, 7 Feb 2026 01:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770428934; cv=none; b=k4WXXd0XjhGOT3kFVNjbzWNcsfr48CR1iI6Wm0a11K/1nakVHjxl6kBCEkveZEBHZDjY1K55Jz0DdYOj2AShUhCxtSOGA7u5T+pGQ0VMFkefWNByiqC8agIAearXZNr3wk/wLBibrZdl8fxh4nOpri64mMrcrYcYfftQ/DRRQ+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770428934; c=relaxed/simple; bh=k3xor5pLC7j9CISwYcAglNwWdIXhdc7x378s28tSHdk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SUgWpb6SDUTOQEefUibsWO9cNAtbnW7fRiuAUcZ04fDIu0Bh+kWRHXfbvFVSOEjIl9VTNzdJv+CM8VjyVNmNetHo9CslJBcowM2EhaG6eZ2T2UX4+7oekvQ84v7eZcEclUvh6245VMdoU+AH4X4OCo5fE8bedf5ykDMdREsbsZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=l4kbaUZL; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="l4kbaUZL" Date: Fri, 6 Feb 2026 17:48:38 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770428931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QN4/4OPtzn+BeYzhJZqjDMvLt+ze3+0173gmQET5pxA=; b=l4kbaUZLViC/91cpxADrAlD7KSE2LUhQpWnfvQ3jaxoedcAFLDmd1V9pafJHCNgW1skNeg FyJFSA6OuUfO1iAeURB/eWN1geTznbfJ6r1qWIp40Y0G7oMowPK4dWKqAnMrqUMxy4sUhZ u2ERIgz/s5o9p19c+RCjRxm/wPnJVV4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Qi Zheng Cc: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Qi Zheng Subject: Re: [PATCH v4 28/31] mm: workingset: use lruvec_lru_size() to get the number of lru pages Message-ID: References: Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Thu, Feb 05, 2026 at 05:01:47PM +0800, Qi Zheng wrote: > From: Qi Zheng > > For cgroup v2, count_shadow_nodes() is the only place to read > non-hierarchical stats (lruvec_stats->state_local). To avoid the need to > consider cgroup v2 during subsequent non-hierarchical stats reparenting, > use lruvec_lru_size() instead of lruvec_page_state_local() to get the > number of lru pages. > > For NR_SLAB_RECLAIMABLE_B and NR_SLAB_UNRECLAIMABLE_B cases, it appears > that the statistics here have already been problematic for a while since > slab pages have been reparented. So just ignore it for now. > > Signed-off-by: Qi Zheng Acked-by: Shakeel Butt