From: Tejun Heo <tj@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-rt-devel@lists.linux.dev, cgroups@vger.kernel.org,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Clark Williams" <clrkwllms@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Bert Karwatzki" <spasswolf@web.de>
Subject: Re: [PATCH] cgroup: Don't expose dead tasks in cgroup
Date: Mon, 2 Mar 2026 11:56:40 -1000 [thread overview]
Message-ID: <aaYHmCV2CW-tOT-Z@slm.duckdns.org> (raw)
In-Reply-To: <20260302120738.6KkDipsR@linutronix.de>
Hello, Seb.
On Mon, Mar 02, 2026 at 01:07:38PM +0100, Sebastian Andrzej Siewior wrote:
> Tejun, with this change, would it be okay to
> - replace the irq-work with kworker? With this change it should address
> your concern regarding "run in definite time" as mentioned in [0]. So
> it might be significantly delayed but it shouldn't be visible.
> This would lift the restriction that a irq-work needs to run on this
> CPU and the kworker could run on any CPU.
Yeah, that's fine.
> - would it be okay to treat RT and !RT equally here (and do this delayed
> cgroup_task_dead() in both cases)
I don't see why we'd bounce on !RT. Are there any benefits?
> @@ -5283,6 +5283,11 @@ static void *cgroup_procs_start(struct seq_file *s, loff_t *pos)
>
> static int cgroup_procs_show(struct seq_file *s, void *v)
> {
> + struct task_struct *tsk = v;
> +
> + if (READ_ONCE(tsk->__state) & TASK_DEAD)
> + return 0;
Does this actually close the window for systemd through operation ordering
or does it just reduce the race window?
Thanks.
--
tejun
next prev parent reply other threads:[~2026-03-02 21:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 12:07 [PATCH] cgroup: Don't expose dead tasks in cgroup Sebastian Andrzej Siewior
2026-03-02 21:56 ` Tejun Heo [this message]
2026-03-03 13:13 ` Sebastian Andrzej Siewior
2026-03-03 17:59 ` Tejun Heo
2026-03-03 20:22 ` Tejun Heo
2026-03-04 19:16 ` Sebastian Andrzej Siewior
2026-03-04 19:22 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaYHmCV2CW-tOT-Z@slm.duckdns.org \
--to=tj@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=cgroups@vger.kernel.org \
--cc=clrkwllms@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mkoutny@suse.com \
--cc=rostedt@goodmis.org \
--cc=spasswolf@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox