From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99C261B4257 for ; Thu, 5 Mar 2026 13:09:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772716161; cv=none; b=NLwxQTMJOAxuct06/tO8oxtuk4zt+WtSV69I0vcHCgZ6fiwEf1nlg40T/ebFNXR2JFgn0ZUjBgLU6RsTEZqKIewIoqe61/iarxITXwjvKHX/5hoqU9F5NijOQI7X3MX5AMiLacIuoIAx8uhSuDXZjgfRflHjjEvz3DWWICxDkqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772716161; c=relaxed/simple; bh=8T9epKh2buznNrrWhPOPl+MXk6VUa5xnuTzDvWpucb0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q9BYpPT78m7AWZHbTQqzN2qzigXDaNIqvgtoBjEZBZ4rNKLQEuBbwpci4MBGzPPrUzPofQ2qA6L+lo17jnpZw7PCxsPjeK70sZswaExcjhopsnc6OsJdoeS45LyBwHZSkKcBRWgjB7Qrm1P0+OErxXdO566ssB8vGDhe3vV3AVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=PNkyumOx; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="PNkyumOx" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-899fb030812so61895156d6.2 for ; Thu, 05 Mar 2026 05:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1772716157; x=1773320957; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RCwW07BC85VhkN6p7jwWc7fFxc9d+eDY6Cs2s6mDKrE=; b=PNkyumOx2oJKa5/3dNeu2XPv4rdjL4aykMZbNtv7dcZFV7rlXoUBo3qxRwQQAR3Ei9 weBun5PF+cwQBkgNLHvOH0v3xP/UFv4Z2DjiUduBeJz/Mzdlv1oyb5xxJqWQdGfOjUuw efbX9+//D946pbrF9htHbWegTS7ii7cSvtmG2lyzeupmHyLzd8esngiuvOEk7itSE1WR dTfXYnomEiNZqvRAeBh8KqjmERQjhlGlPzF34YwgthJybTm3qFWCJ17kPga+uFP3YopL mUEOwtvrTmPj1zGaQ6cBZn08FYov/9y5LXGqZE3qpYYdt0mdb0cfGf8GWmXTKQPfh02D uqCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772716157; x=1773320957; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RCwW07BC85VhkN6p7jwWc7fFxc9d+eDY6Cs2s6mDKrE=; b=mRhMA4VcLoG3jGtj8/IsZU4yEJkip+fkS8cSxLmYomqffAwA9iXaLNqcnQlsZtrJrD bW5YQLbLEn1zbgVTEW66EnMJ8qq3oA5yOs9/Fby8BrQ26nKNrj/soBx7eQZCrMqwGRGK hSvsh8hyuytF9sA/SJuWKrH0mIzzEWYk8z7Wg7SSvA9a2oRLtQ3kFyy2teb6DXUA/jnK dzd4tRRLmCY3t7EYFPz7IprhSRT1lGHv3HeH97vm7hkfEj15P9SPzGueAhpxFpT+2oNe 9K5ZMTnp7AnnbnPl8+qqxi99lDUP9bFuJX+f7vK6CsbhkHYWArpSEfXbKDYDKZL6qszf abvg== X-Forwarded-Encrypted: i=1; AJvYcCWANd5gOYTmSGJsWYIvlyfc9CZBl9MMBgcRwfOVw8AAmrme03RuCmiGRpzI7MgyJYReXhWoPIiF@vger.kernel.org X-Gm-Message-State: AOJu0YwNaDYoZBu320e4b4NKHXuCXLbCMe8oZ1vd1lKtxF2vMWv65z42 D932vMjZeik81rMRnjR9N/krAA2cqi588OKDd+ghELylFPBf8KuLoHKrUdbXBQh2oP4= X-Gm-Gg: ATEYQzwjRl+yORmknR+y5caDxQMbcmI6IRE01YB9ytdzihSOjie1SoNBbxrMXjG9Fmq Esn0N9L9zkYzohBk/g+hGIC1w3IJk5IoR/nPcuCSdWnd2Q8aJiXzVwr3Q98CfEZ4sTkCFau8bsl b48LDHsHhYEn1u7N4x92PwVTS1C9k1z4YJotAKxicHWGhzNjJ3wuYcrUh0KNbrqAdw/Zjs80HTT aJI4WcjI8yWng1KyvX4mzQmhakJ3sJLUZjDz7ZS8FJ0M0NvQwUZ/P9fZbe9zUsC8JaExmXj0mE/ Nq/coxfKNmk1+hOhnV1a+K5zNvs0lmjFDOLYzmQltAXbwS39J7am+Xfn0zxwX+OPBHQ5EDoNkFd m3gcEXQPKK5FAANAkp9uzsWoIh6uwqN8uUioz6xYAzpIwbDGsqbsEFAyIVFY+fCUEZx/xwVcXzk rIQ6f6zM6Bvs4vGjzJxOBMeA== X-Received: by 2002:a05:6214:2a86:b0:899:d6d2:4b96 with SMTP id 6a1803df08f44-89a19d19be3mr78504446d6.34.1772716157355; Thu, 05 Mar 2026 05:09:17 -0800 (PST) Received: from localhost ([2603:7000:c00:3a00:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899e608cfc6sm122095406d6.14.2026.03.05.05.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 05:09:16 -0800 (PST) Date: Thu, 5 Mar 2026 08:09:15 -0500 From: Johannes Weiner To: "Vlastimil Babka (SUSE)" Cc: Andrew Morton , Hao Li , Michal Hocko , Roman Gushchin , Shakeel Butt , Vlastimil Babka , Harry Yoo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Johannes Weiner Subject: Re: [PATCH 1/5] mm: memcg: factor out trylock_stock() and unlock_stock() Message-ID: References: <20260302195305.620713-1-hannes@cmpxchg.org> <20260302195305.620713-2-hannes@cmpxchg.org> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 03, 2026 at 10:23:54AM +0100, Vlastimil Babka (SUSE) wrote: > On 3/2/26 20:50, Johannes Weiner wrote: > > From: Johannes Weiner > > > > Consolidate the local lock acquisition and the local stock > > lookup. This allows subsequent patches to use !!stock as an easy way > > to disambiguate the locked vs. contended cases through the callstack. > > > > Signed-off-by: Johannes Weiner > > Reviewed-by: Vlastimil Babka (SUSE) Thanks! > nit: > > > --- > > mm/memcontrol.c | 25 +++++++++++++++++++------ > > 1 file changed, 19 insertions(+), 6 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 753d76e96cc6..a975ab3aee10 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -3208,6 +3208,19 @@ void __memcg_kmem_uncharge_page(struct page *page, int order) > > obj_cgroup_put(objcg); > > } > > > > +static struct obj_stock_pcp *trylock_stock(void) > > +{ > > + if (local_trylock(&obj_stock.lock)) > > + return this_cpu_ptr(&obj_stock); > > + > > + return NULL; > > +} > > + > > +static void unlock_stock(struct obj_stock_pcp *stock) > > +{ > > + local_unlock(&obj_stock.lock); > > +} > > Could have added inline's there. The compiler heuristics can be sometimes > unpredictable. Oops, I almost missed that, but that sounds good to me. Andrew, would you mind folding this in? diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 36612175e98e..178be98f2e49 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -3160,7 +3160,7 @@ void __memcg_kmem_uncharge_page(struct page *page, int order) obj_cgroup_put(objcg); } -static struct obj_stock_pcp *trylock_stock(void) +static inline struct obj_stock_pcp *trylock_stock(void) { if (local_trylock(&obj_stock.lock)) return this_cpu_ptr(&obj_stock); @@ -3168,7 +3168,7 @@ static struct obj_stock_pcp *trylock_stock(void) return NULL; } -static void unlock_stock(struct obj_stock_pcp *stock) +static inline void unlock_stock(struct obj_stock_pcp *stock) { if (stock) local_unlock(&obj_stock.lock);