From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: Juri Lelli <juri.lelli@redhat.com>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
"Valentin Schneider" <vschneid@redhat.com>,
"Waiman Long" <longman@redhat.com>, "Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Qais Yousef" <qyousef@layalina.io>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Swapnil Sapkal" <swapnil.sapkal@amd.com>,
"Phil Auld" <pauld@redhat.com>,
luca.abeni@santannapisa.it, tommaso.cucinotta@santannapisa.it,
"Jon Hunter" <jonathanh@nvidia.com>
Subject: Re: [PATCH v2 2/8] sched/topology: Wrappers for sched_domains_mutex
Date: Fri, 7 Mar 2025 14:32:35 +0530 [thread overview]
Message-ID: <ab67eb4d-0940-4278-b84f-20dbaf0560cf@linux.ibm.com> (raw)
In-Reply-To: <Z8q0Alpk8AXbGxgW@jlelli-thinkpadt14gen4.remote.csb>
On 3/7/25 14:23, Juri Lelli wrote:
> Hi,
>
> Thanks for the overall review!
>
> On 07/03/25 12:04, Shrikanth Hegde wrote:
>> Hi Juri.
>>
>> On 3/6/25 19:40, Juri Lelli wrote:
>>> Create wrappers for sched_domains_mutex so that it can transparently be
>>> used on both CONFIG_SMP and !CONFIG_SMP, as some function will need to
>>> do.
>
> ...
>
>> Maybe sched_domains_mutex can be static since its only used in topology.c ?
>
> We have a lockdep_assert in cpuset.c, don't we? We can create another
> wrapper for that, but I am not sure it is going to be cleaner.
Ok. Sorry, my bad. I searched only in kernel/sched. You can ignore this
comment.
>
> Thanks,
> Juri
>
next prev parent reply other threads:[~2025-03-07 9:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 14:10 [PATCH v2 0/8] Fix SCHED_DEADLINE bandwidth accounting during suspend Juri Lelli
2025-03-06 14:10 ` [PATCH v2 1/8] sched/deadline: Ignore special tasks when rebuilding domains Juri Lelli
2025-03-06 14:10 ` [PATCH v2 2/8] sched/topology: Wrappers for sched_domains_mutex Juri Lelli
2025-03-07 6:34 ` Shrikanth Hegde
2025-03-07 8:53 ` Juri Lelli
2025-03-07 9:02 ` Shrikanth Hegde [this message]
2025-03-07 15:11 ` Waiman Long
2025-03-07 15:15 ` Juri Lelli
2025-03-07 15:19 ` Waiman Long
2025-03-07 15:59 ` Juri Lelli
2025-03-07 16:34 ` Waiman Long
2025-03-06 14:10 ` [PATCH v2 3/8] sched/deadline: Generalize unique visiting of root domains Juri Lelli
2025-03-07 5:36 ` Shrikanth Hegde
2025-03-07 8:55 ` Juri Lelli
2025-03-06 14:10 ` [PATCH v2 4/8] sched/deadline: Rebuild root domain accounting after every update Juri Lelli
2025-03-07 6:33 ` Shrikanth Hegde
2025-03-07 9:33 ` Juri Lelli
2025-03-07 7:32 ` Shrikanth Hegde
2025-03-07 8:59 ` Juri Lelli
2025-03-06 14:10 ` [PATCH v2 5/8] sched/topology: Remove redundant dl_clear_root_domain call Juri Lelli
2025-03-06 14:10 ` [PATCH v2 6/8] cgroup/cpuset: Remove partition_and_rebuild_sched_domains Juri Lelli
2025-03-07 7:40 ` Shrikanth Hegde
2025-03-07 15:14 ` Waiman Long
2025-03-07 15:16 ` Waiman Long
2025-03-06 14:10 ` [PATCH v2 7/8] sched/topology: Stop exposing partition_sched_domains_locked Juri Lelli
2025-03-06 14:10 ` [PATCH v2 8/8] include/{topology,cpuset}: Move dl_rebuild_rd_accounting to cpuset.h Juri Lelli
2025-03-07 15:17 ` Waiman Long
2025-03-07 11:40 ` [PATCH v2 0/8] Fix SCHED_DEADLINE bandwidth accounting during suspend Jon Hunter
2025-03-07 15:16 ` Juri Lelli
2025-03-07 19:00 ` Waiman Long
2025-03-10 8:55 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab67eb4d-0940-4278-b84f-20dbaf0560cf@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=bigeasy@linutronix.de \
--cc=bsegall@google.com \
--cc=cgroups@vger.kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=hannes@cmpxchg.org \
--cc=jonathanh@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=luca.abeni@santannapisa.it \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rostedt@goodmis.org \
--cc=swapnil.sapkal@amd.com \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox