From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C302627BF95 for ; Thu, 14 Aug 2025 21:52:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755208328; cv=none; b=LbPZyqCiBmb6P7eTN+G57lwFhCz63BOIF2HYKx4o6V9xJlPFYuOAO+sUFIVMONH7422R0iL1MSwR/QIFrSim8w5yrwrss6kzgreR8W1W3mYUaMfhJzjYFzLhGobbaaU+gvigX4iVzCZEKbIxLsyTyfzEYNNExEgqYpU676i3vgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755208328; c=relaxed/simple; bh=WnREA4EmIGffwVYe+p1Wq3OblJahuKZyzXDj71NDWfE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G5Ckv0+TGF15sBTwA12LI861+zks0+pJBCW/sckJF17csuc0gyCYvIMJGfydt+Nr3QHwGOIUm3uFUSM11v6B2NzCGJuQJTjFHqF/LcblhPd6MAGUUrPyXxNM1qiP4PJ+vbzaRtEJDB35Ox/tbuRMjAXt8QUEGJsX+s3kbM5DUCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=IrN0ga1A; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="IrN0ga1A" Date: Thu, 14 Aug 2025 14:51:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1755208323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rqdnKsJcJkYJnPBTXkMaUgB7UwMWndORjmIX+sJaJew=; b=IrN0ga1A477YwjqiZcuceGQzNznS3SzlrYd+7GS0ASPe9/mRFVQjDkW0St+5h3Wo6IfN2U bK+IB04vdumaMqVNLxQSTUp64UctuI6IKtdcHZ+O6X5+e+u0taBRiEekPEbeFSshyg+tfF kXJ5/xN1Bf+d4xMzPkNwJiRaL+xoqw0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Kuniyuki Iwashima Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Neal Cardwell , Paolo Abeni , Willem de Bruijn , Matthieu Baerts , Mat Martineau , Johannes Weiner , Michal Hocko , Roman Gushchin , Andrew Morton , Michal =?utf-8?Q?Koutn=C3=BD?= , Tejun Heo , Simon Horman , Geliang Tang , Muchun Song , Mina Almasry , Kuniyuki Iwashima , netdev@vger.kernel.org, mptcp@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 net-next 07/10] net-memcg: Introduce mem_cgroup_sk_enabled(). Message-ID: References: <20250814200912.1040628-1-kuniyu@google.com> <20250814200912.1040628-8-kuniyu@google.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250814200912.1040628-8-kuniyu@google.com> X-Migadu-Flow: FLOW_OUT On Thu, Aug 14, 2025 at 08:08:39PM +0000, Kuniyuki Iwashima wrote: > The socket memcg feature is enabled by a static key and > only works for non-root cgroup. > > We check both conditions in many places. > > Let's factorise it as a helper function. > > Signed-off-by: Kuniyuki Iwashima > Reviewed-by: Eric Dumazet > Acked-by: Roman Gushchin Acked-by: Shakeel Butt