From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: "Chen Ridong" <chenridong@huawei.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup/cpuset: Skip security check for hotplug induced v1 task migration
Date: Fri, 27 Mar 2026 10:22:59 -1000 [thread overview]
Message-ID: <acbnI21DC-W_uE2F@slm.duckdns.org> (raw)
In-Reply-To: <20260327201546.2463644-1-longman@redhat.com>
On Fri, Mar 27, 2026 at 04:15:46PM -0400, Waiman Long wrote:
> + /*
> + * Set to true if a kthread is moving tasks away from a v1 cpuset with
> + * no CPUs
> + */
> + kthread_move_task_from_empty_cs = !cpuset_v2() &&
> + cpumask_empty(oldcs->effective_cpus) &&
> + (current->flags & PF_KTHREAD);
PF_KTHREAD test seems odd. Can't you pass this in as a flag from hotplug
handler?
Thanks.
--
tejun
next prev parent reply other threads:[~2026-03-27 20:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 20:15 [PATCH] cgroup/cpuset: Skip security check for hotplug induced v1 task migration Waiman Long
2026-03-27 20:22 ` Tejun Heo [this message]
2026-03-28 1:42 ` Waiman Long
2026-03-28 1:39 ` Chen Ridong
2026-03-29 17:27 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acbnI21DC-W_uE2F@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox