Re: [PATCH v3] cgroup/rdma: refactor resource parsing with match_table_t/match_token()

[Tejun Heo <tj@kernel.org>]

On Wed, Apr 22, 2026 at 10:17:09AM +0800, Tao Cui wrote:
> Replace the hand-rolled strsep/strcmp/match_string parsing in
> rdmacg_resource_set_max() with a match_table_t and match_token()
> pattern, following the convention used by user_proactive_reclaim()
> and ioc_cost_model_write().
> 
> The old strncmp(value, RDMACG_MAX_STR, strlen(value)) also had two
> bugs that are fixed by this refactor:
> 
>   - It matched "ma" as "max" because strncmp only compared the
>     shorter strlen(value) bytes.
> 
>   - It silently accepted "hca_handle=" (empty value) as "max"
>     because strncmp with n=0 always returns 0.
> 
> The match_token() approach also robustly handles extra whitespace in
> the input by splitting on " \t\n" and skipping empty tokens.
> 
> Suggested-by: "Michal Koutný" <mkoutny@suse.com>
> Signed-off-by: Tao Cui <cuitao@kylinos.cn>

Looks fine to me, Michal?

Thanks.

-- 
tejun