Linux cgroups development
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Tao Cui <cuitao@kylinos.cn>
Cc: axboe@kernel.dk, cgroups@vger.kernel.org, josef@toxicpanda.com,
	 linux-block@vger.kernel.org, tj@kernel.org
Subject: Re: [PATCH] blk-throttle: schedule parent dispatch in tg_flush_bios()
Date: Thu, 21 May 2026 13:54:43 +0900	[thread overview]
Message-ID: <ag6OXDuTc3JubfqV@shinmob> (raw)
In-Reply-To: <31179261-64e0-4950-b112-32627d48e734@kylinos.cn>

On May 21, 2026 / 10:54, Tao Cui wrote:
...
> Could you check if your system has a non-English locale set? 

Thanks for trying it out. My system has Englihs locale.

$ locale
LANG=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=

> If the issue persists after running with LC_ALL=C ./check throtl/004, I'll investigate further.

It still fails with LC_ALL=C.

# LC_ALL=C ./check throtl/004
throtl/004 (nullb) (delete disk while IO is throttled)       [passed]
    runtime  1.250s  ...  1.211s
throtl/004 (sdebug) (delete disk while IO is throttled)      [failed]
    runtime  2.518s  ...  2.271s
    --- tests/throtl/004.out    2026-03-20 14:25:50.478000000 +0900
    +++ /home/shin/Blktests/blktests/results/nodev_sdebug/throtl/004.out.bad    2026-05-21 13:46:36.676000000 +0900
    @@ -1,3 +1,2 @@
     Running throtl/004
    -Input/output error
     Test complete


P.S. Through this action, I noticed that locale handling is an improvement point
     of blktests.

  reply	other threads:[~2026-05-21  4:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20  6:24 [PATCH] blk-throttle: schedule parent dispatch in tg_flush_bios() Tao Cui
2026-05-20 12:33 ` Shin'ichiro Kawasaki
2026-05-20 14:20   ` Tao Cui
2026-05-20 23:39     ` Shin'ichiro Kawasaki
2026-05-21  2:54       ` Tao Cui
2026-05-21  4:54         ` Shin'ichiro Kawasaki [this message]
2026-05-21  7:54           ` Tao Cui
2026-05-21  9:04           ` Tao Cui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ag6OXDuTc3JubfqV@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=cuitao@kylinos.cn \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox