From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 338A13ACA7E for ; Tue, 19 May 2026 20:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779221489; cv=none; b=Xg+CmpeWEi1XGqNh0OnIIiQ3ipI93g8jQqWnLRkuBIM0thX/71no2Ab35Q7edM7IHFVjWS88vRrLliJCPNKQXwMvTjdIBD2hBtb/0ilEdt5hGoYj4vw0AbESM3uLGBXVTZVOtoSXUHX5ym2GI3pB0BshyXthuBkbfH0zUxc96mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779221489; c=relaxed/simple; bh=vjTqi2oUdlBXEwZ68rA08ByBf/yv5RCFyRR5LsH7Q/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MvH4Fo33IT1qmBDvRLHD9PpzDnSHREfoshswJuAePv9aStdjteV7XG+m9RhTXtcwn91CbkpKcSlNRejGq8X1tMPTV7GxR7QH34hzuGJ3SI6WOs4xsjiwJMCSaBbC4/9ouQag3hYnq71g5MYa01+fAvIsp5bS8X3YgYF1S9gsoy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=KYuDwzpS; arc=none smtp.client-ip=95.215.58.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="KYuDwzpS" Date: Tue, 19 May 2026 13:11:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779221486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kJMO1B/wUheToiDYWGSoEg/sxiAds2iQg3Hn7Ds6K+k=; b=KYuDwzpSkEYfETezMt32EYxbA2JTy87z0DUyz+R+kSus5d0zTzU0bVqZhwtWU58dFApu2N bW3HqDPkx3r9pO4t8OJ/VjsAHHjf/lRGkT3eOKY2cY4Sabm+DDBvC9+ceMHul2yeKYgHWL dDyda6ZhpNc3f5yuJi2e9LKBP5rw/48= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Harry Yoo Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Qi Zheng , Alexandre Ghiti , Joshua Hahn , Meta kernel team , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH v3] memcg: cache obj_stock by memcg, not by objcg pointer Message-ID: References: <20260518222827.110696-1-shakeel.butt@linux.dev> <4e296262-fbbf-4ac7-aecc-3ef831583704@kernel.org> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Wed, May 20, 2026 at 12:00:16AM +0900, Harry Yoo wrote: > > [...] > > > > The full clean solution might take one more cycle and I think we can not just > > ignore 67% regression on 7.1. > > That is valid point, unfortunately. > > One more thing I have to ask... for v7.1, wouldn't it be a safer option to > revert the per-node object change and re-introduce it once we have a cleaner > solution? The issue with that revert is that we reintroduce all node lru locking in the objcg reparenting path. > > This change was introduced in v5, but the implementation before v4 had been > exposed in -next for a while, and I think we don't have enough justification > to keep the per-node objcgs change, at least for v7.1, given that we have an > unexpected last-minute regression and > correctness concerns (albeit slight). I am waiting for Oliver to test the multi-objcg patch I sent. If that also resolves the regression then we have one more option i.e. backport that to 7.1 to fix the regression. So to summarize, for future kernels we will be having multi-objcg in some form. For 7.1, we have to decide between (1) do nothing (2) this patch or (3) backport the multi-objcg path to 7.1. Andrew, please don't send this patch to Linus until we decide on the option.