From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 165A2315D21 for ; Wed, 27 May 2026 01:43:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779846186; cv=none; b=lzUO0dBqzgVGG5il53oRQDDwA0QQXQZcHpPF2FoiKrwENs6Fjt0EVGLrLRz3p6HJfhJ+XDQLSaOR91HM9qVKdYlDuPZLqPnmyJYRIdlgEv0gs9qUoaThEWIbdbPeXn9FZ+lbRwPN5gTYfsoTzrZoBWdEt0VttTI4E8My6zPTHk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779846186; c=relaxed/simple; bh=ycfMMg9+7DShBq3vWQYzurSrqAe8/KImlo6O2xMlEYo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lWx1AVAKvIALlAWy3f9p3uu3I3XRDKYtwLqJT6Y3T+LUL39u6h04BSlp5D1RIx3usc6/de2th4+QCgcVdfs5GPJpX1evm+8A2OLT6w1E9TMRbAj/jw+UYsSEsZp9tSmFygzYLGSEGSYpxrteCu5lDI28RJv41xBlJzbVK11Qp+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=jlIwSpdl; arc=none smtp.client-ip=95.215.58.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="jlIwSpdl" Date: Wed, 27 May 2026 09:42:54 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779846181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8fHAP+dXRYZTfGDBp++y6CzrTTEWIHFIL88enGg73+U=; b=jlIwSpdlreKSpJiPJIJXN3tq/5wWkEDhReZkiz33cL2TG4g0BUmL8/wp5MBt85mFCMEHqw H/S9TlvOOE8WKvXtIuwl8/lDMkK+FtYRZbgES6thaBMrVzGG6M+eXviZGZBuZ2OQQ0JreJ yyB4VQJ8QZTG4xjO5Mx0BZYjSKNjuMc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Baoquan He To: Youngjun Park Cc: akpm@linux-foundation.org, chrisl@kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kasong@tencent.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, shikemeng@huaweicloud.com, nphamcs@gmail.com, bhe@redhat.com, baohua@kernel.org, gunho.lee@lge.com, taejoon.song@lge.com, hyungjun.cho@lge.com, mkoutny@suse.com, baver.bae@lge.com, matia.kim@lge.com Subject: Re: [PATCH v6 4/4] mm: swap: filter swap allocation by memcg tier mask Message-ID: References: <20260421055323.940344-1-youngjun.park@lge.com> <20260421055323.940344-5-youngjun.park@lge.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260421055323.940344-5-youngjun.park@lge.com> X-Migadu-Flow: FLOW_OUT On 04/21/26 at 02:53pm, Youngjun Park wrote: > Apply memcg tier effective mask during swap slot allocation to > enforce per-cgroup swap tier restrictions. > > In the fast path, check the percpu cached swap_info's tier_mask > against the folio's effective mask. If it does not match, fall > through to the slow path. In the slow path, skip swap devices > whose tier_mask is not covered by the folio's effective mask. > > This works correctly when there is only one non-rotational > device in the system and no devices share the same priority. > However, there are known limitations: > > - When non-rotational devices are distributed across multiple > tiers, and different memcgs are configured to use those > distinct tiers, they may constantly overwrite the shared > percpu swap cache. This cache thrashing leads to frequent > fast path misses. > > - Combined with the above issue, if same-priority devices exist > among them, a percpu cache miss (overwritten by another memcg) > forces the allocator to round-robin to the next device > prematurely, even if the current cluster is not fully > exhausted. > > These edge cases do not affect the primary use case of > directing swap traffic per cgroup. Further optimization is > planned for future work. > > Signed-off-by: Youngjun Park > --- > mm/swapfile.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index d5abc831cde7..8734e5d26b08 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1352,15 +1352,22 @@ static bool swap_alloc_fast(struct folio *folio) > struct swap_cluster_info *ci; > struct swap_info_struct *si; > unsigned int offset; > + int mask = folio_tier_effective_mask(folio); > > /* > * Once allocated, swap_info_struct will never be completely freed, > * so checking it's liveness by get_swap_device_info is enough. > */ > si = this_cpu_read(percpu_swap_cluster.si[order]); > + if (!si || !swap_tiers_mask_test(si->tier_mask, mask) || > + !get_swap_device_info(si)) > + return false; > + > offset = this_cpu_read(percpu_swap_cluster.offset[order]); > - if (!si || !offset || !get_swap_device_info(si)) > + if (!offset) { > + put_swap_device(si); > return false; > + } The whole patch looks good to me except of one nitpick. Is it a lille cleaner with below tiny adjustment? diff --git a/mm/swapfile.c b/mm/swapfile.c index 2864cd8c2da9..cdf453bf6b80 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -1359,15 +1359,12 @@ static bool swap_alloc_fast(struct folio *folio) * so checking it's liveness by get_swap_device_info is enough. */ si = this_cpu_read(percpu_swap_cluster.si[order]); - if (!si || !swap_tiers_mask_test(si->tier_mask, mask) || - !get_swap_device_info(si)) + if (!si || !swap_tiers_mask_test(si->tier_mask, mask)) return false; offset = this_cpu_read(percpu_swap_cluster.offset[order]); - if (!offset) { - put_swap_device(si); + if (!offset || !get_swap_device_info(si)) return false; - } ci = swap_cluster_lock(si, offset); if (cluster_is_usable(ci, order)) { > > ci = swap_cluster_lock(si, offset); > if (cluster_is_usable(ci, order)) { > @@ -1379,10 +1386,14 @@ static bool swap_alloc_fast(struct folio *folio) > static void swap_alloc_slow(struct folio *folio) > { > struct swap_info_struct *si, *next; > + int mask = folio_tier_effective_mask(folio); > > spin_lock(&swap_avail_lock); > start_over: > plist_for_each_entry_safe(si, next, &swap_avail_head, avail_list) { > + if (!swap_tiers_mask_test(si->tier_mask, mask)) > + continue; > + > /* Rotate the device and switch to a new cluster */ > plist_requeue(&si->avail_list, &swap_avail_head); > spin_unlock(&swap_avail_lock); > -- > 2.34.1 >