From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 831773BED76 for ; Wed, 17 Jun 2026 12:25:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699143; cv=none; b=nhTcUnky9Ozte89dOerIy8l3wf5CuIF9QjXKHCN42OwtRpnfNhk4ELx3mDqIOYIzfUnmCUGeMRsXhsweiRtxKhZBZ+NHGqy0AGlQOPDUCBQVgETEbzDWzg0t8+tGJMEhuTwv+4+Dw1zQ54OY9cjq6Z6+H8PAvp+J9cReQiOWx50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699143; c=relaxed/simple; bh=55oehVVJrmbgSWpqFQjMcXle7kXrC4IU8zhtK3UJFn0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AJoSdLN3Vj+k5CpVGCCAyQh6/WOdeIwbe/Ep3dG1G2ITn/QY9OcOx9jHNHQE2qUvYvDycBpWySRGtjQd74z084Tyc562ILUhIwUjLZJpH8/iHvoXoS0e4wReSXzeiNGronJ5rwNNVpu+fT9Oy2A6aYuskQBGU2p86bxXgyTpokM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=PL5Zse+k; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="PL5Zse+k" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-4626fdc829aso625532f8f.3 for ; Wed, 17 Jun 2026 05:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781699139; x=1782303939; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0GtI51H7Zd74M1RsBhYXt9g8xAv+Fn70VlHsGIGT064=; b=PL5Zse+kBTa3E2DF8RlgL+llKyk9XrWurGnrRud3SssnE9D9BXFbCI/DazFsFYfapo zNZQU19WfyxIIUF3ftuWyF2dCmq4AH7hrxDdWznVzpYYxzDeGVFExJIujjmIZ/eefJYX ZJ9Wd66ZODnJy8cY7bQ8CCfZnioAG6mWYjRyERtqYkYlpMJdeNg4Rb3kTJ/cubdRKgl8 PNv+/p2utPSqaC99enUM+FHWX6mMfsoJccwrA/1t8XATC9j3B4hAjIBqPlszfV1H5/hy etqUVf3ssG8fr4zINGWfGRh53HqJBrOrahuLCW7GDARod7HExCeOSChbQQut2uc1fPfa EcdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781699139; x=1782303939; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0GtI51H7Zd74M1RsBhYXt9g8xAv+Fn70VlHsGIGT064=; b=oeBNAyrxHUXPPjCHRdcb/tDY436KC+FgmIPh82xUuCDglMV2l3euJPN6+IbJp3LcJD kQsVgA4RYaQ4AWjfQjudtckpffEJhbxTyaohAzUv+Hlje5u1g6104AOXjJahzYYbIDtt 5rQCR+y3rZ5jQn7dTYwAp2PiGXZE0iyLYMF+6cyoOg0BBtg64IM/DZ4o5TnyyoVepqwA WiLJyy2UtpF8OfnwWeQ4Uv0BE9pfUhNVmamit0Xw+eEVaqNrbJk0pn6NSv6k9lulS7LZ txeliR+Yv0IcUsRn7FzWbdqeXSdpToWjbg/c1BN2lQPiXsPPDnU6oJgRAPamdSAd2Oj0 Rj0w== X-Forwarded-Encrypted: i=1; AFNElJ+vx7iYtnQuWAjgvmlofjP/V738TnKzz56r17f8XWhS7FRk8QI1Kjk4i4zZBaFfrAX7aBiYn6SS@vger.kernel.org X-Gm-Message-State: AOJu0Yx6XZ0r2qRG1nH5XgtEzvWymcpKmcswcDn5hC+dYLgDRpZyNxxj tm9p1/DSM8519ru/uL60fDTgi9rAPF83M7EUNBqK4BY4F7zr285xYjelW0P6r3mBDFI= X-Gm-Gg: AfdE7ck4YecbCV4IveT7QzEAl01siiQ/5oM4zo4OGJGd2l+TySbapYGplMrfcBpT7qo dqupzUkY9dc1QCrCaoGiRChMCH0NZc9B40zeQs2ygMQ4vCDoE36Dogm9D5Nan+hasKLSFAkgsFE vJMeE+UdtpWhUNEal4AVymUxWt+AuMpioNmYd9ulbBtEa0TpY+EwR/S4tx4G7g1NYj9oINyEBGh oRTsQqhzpndhCLkX6UJ0HLz3D1fCUfY7YdEajE35SJwOmAxzY/HLuppkVFLGrpfU4UrfwyiJBIg b3nuJF4ynppMpOLwZV96FdlqnWMrMQotUZ/6aKt3+RqUXjYsmuVzvjAFp65MEULJsVblOOG9xDB v5d/Ip0Y+Qifcti+6/C8phNTqTz/qDMRl99egmwMBsRFfFo7deW4Epoqy7KaHiJUde1WWBsvrWn 3DM5DJ0vZe4/GFzNeJyA== X-Received: by 2002:a5d:588d:0:b0:43f:dbbf:6d93 with SMTP id ffacd0b85a97d-462410d3c5bmr5999253f8f.27.1781699138624; Wed, 17 Jun 2026 05:25:38 -0700 (PDT) Received: from localhost.localdomain ([62.77.90.70]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f26f726sm51008107f8f.15.2026.06.17.05.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 05:25:38 -0700 (PDT) Date: Wed, 17 Jun 2026 14:25:36 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Li Wang Cc: akpm@linux-foundation.org, tj@kernel.org, longman@redhat.com, roman.gushchin@linux.dev, hannes@cmpxchg.org, yosry@kernel.org, jiayuan.chen@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, shuah@kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko , Muchun Song , Shakeel Butt , Yosry Ahmed Subject: Re: [PATCH v7 1/8] selftests/cgroup: skip test_zswap if zswap is globally disabled Message-ID: References: <20260424040059.12940-1-li.wang@linux.dev> <20260424040059.12940-2-li.wang@linux.dev> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xz3b5522yngbc7la" Content-Disposition: inline In-Reply-To: <20260424040059.12940-2-li.wang@linux.dev> --xz3b5522yngbc7la Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v7 1/8] selftests/cgroup: skip test_zswap if zswap is globally disabled MIME-Version: 1.0 On Fri, Apr 24, 2026 at 12:00:52PM +0800, Li Wang wrote: > test_zswap currently only checks whether zswap is present by testing > /sys/module/zswap. This misses the runtime global state exposed in > /sys/module/zswap/parameters/enabled. >=20 > When zswap is built/loaded but globally disabled, the zswap cgroup > selftests run in an invalid environment and may fail spuriously. >=20 > Check the runtime enabled state before running the tests: > - skip if zswap is not configured, > - fail if the enabled knob cannot be read, > - skip if zswap is globally disabled. >=20 > Also print a hint in the skip message on how to enable zswap. >=20 > Signed-off-by: Li Wang > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Michal Koutn=FD > Cc: Muchun Song > Cc: Nhat Pham > Cc: Tejun Heo > Cc: Roman Gushchin > Cc: Shakeel Butt > Cc: Yosry Ahmed > Acked-by: Yosry Ahmed > Acked-by: Nhat Pham > --- > tools/testing/selftests/cgroup/test_zswap.c | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) Reviewed-by: Michal Koutn=FD --xz3b5522yngbc7la Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCajKSOxsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+Ag2DAEA2nNoiQ15OgJR5VxoVnSf lqGp2dpx3cwAQ5ux10qjH68A/1bVmadDbo1mKFNPpy/OmWnyJnAthaTKN3GT+oTM BcoO =cwDP -----END PGP SIGNATURE----- --xz3b5522yngbc7la--