From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B49243ED125 for ; Wed, 17 Jun 2026 12:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699169; cv=none; b=PLe0XH62XnMcnjhTJzE6BqUyB9hctbBL7ZFMs2d469iSTDuJEydX9rRdVWE/zoGBaRn67mi/9tieBT1Fdh8zc5bF1PxervsiMN6TreLZnn/LYayaHYOsC48Wjcj7BXO+S2Ioa9+Z9gbkR3wVqPt7VGw9O0RyE8D+8U0Ru2iQG+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781699169; c=relaxed/simple; bh=jXv3Lp1VAkZliGQZVvjo9P0HvOkaYz9n//YoA1Z/TW0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s0H4vuRRCS/aUepJ81mL1nk7vfd+BGXLeesHfwlnrQb/H5Vz1w6pyCoUk2fC9MRf7GlQxwmjzRZnb5Npx2Thvf5gB7F7uJ//VojPS3afrwtqNyWYPhT837V6atQ9bjgK8t0v6JNRxai6VEimI6MvU966Tcg9yf9zWhxTnpnvJNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SbUyNTX1; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SbUyNTX1" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4631679f204so219086f8f.0 for ; Wed, 17 Jun 2026 05:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1781699164; x=1782303964; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UPt25DcGCAYbTcLBdAYH1YOTb8QxGJA5VYhPTuLTerQ=; b=SbUyNTX1MZBASicJ68JQ/I9QN8XY1IZkGhvUKf8al6VPdI+pPol9XrpZIduVTClmmO qsQwdW71wAL/UazVDTm/hvcEflzQrsRBct9zgv3OLn8JAocOORddIi0k0+kOfdPsnZ7R db8KpzLvoM2t0lCS9J8rS8SLo44fMak7eo/kgtRAdfvs4Ay8kaYtkbYEh+CSL6hYHNB1 f4BKBfRmb7oMtmbBd2tR4VD0BERtnhtSBs7SwVraM194iiv2tJWX5Cg6qzV3RvTib06x X3tU52UveN506IxYsMO9GMDOrgTWq87j6B4eHx9dE103iwER7VsnMi8yYlDWG+QBU8AK Ozbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781699164; x=1782303964; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UPt25DcGCAYbTcLBdAYH1YOTb8QxGJA5VYhPTuLTerQ=; b=dNAhbb2s9AcX0QvaDSGgtHsY3jLR2OapyYG6p0ZPba5KtSQjo/6wSn7OV01DIQI/dB mc7znzpeyHvhgSaZDmxDte533Ij07kPTdr9eMisc60xrByAC9tFyXJ1EQQSiKcqdMcPC sy/MRBSyD704YvEgTt+m1ONTi16o011YjaNwiUD/jZJZAfcwRlyQ34IykCSynd3d4sqz Yz874W1RDW5ugHdE6TbVisubmurF8H1OIp//5l5xJVl7T9EgDuPzAgmKcODExHhH3URg 5ENr2Ha/rdpQ2a9qcwDVAJ1a8xDbY6GVexZVsg6+SYUxv8wnmas0HCfTag7Llh2ZDRHM VEWg== X-Forwarded-Encrypted: i=1; AFNElJ/MlusGHPpJDEdzLufdqom+AiEcyGFx5p4WVs0450GfSLcSwqFMz9a7IvWTXacxI2FRUTcf4e93@vger.kernel.org X-Gm-Message-State: AOJu0YydG+LzmBiGVewzhcSJBpWythAkV5cuqNgOg0DTohQA/aOxE3Hf 52IeBrzlJC2VcdmsyKblM4TkJuIPf+YU6tj55WeIP1IlnsrB1zKwEp4Ip/zh5zjmdpU= X-Gm-Gg: AfdE7cnOErZh94EB2ssCZQqzgzdam6qrbIWVaj0Geo7X6iGdSk0uTbdgRaGN7Z6HbIX 4zQorjJNw724JvIixeGoCbjggim/IYX5skI6oVF8ptKV8BFoRXZei6UqiMupOYazhcpEVMLTZVc 6Yibx+EXWdu7D/tZK+/EHoBogth65gPht5YEmDn5awLXS9/LrICAoqKwRUpl+rSJTYcEj1Hr9YG 2wodpxIfkDOzWAHpY7hrmQkOy0UKXwarbHQkEvxeFFCzvgZgZbTbZt6+K0wE5MQerZAdrFp1AIB xADsljYGBB9PFDmzYzr7Ne3gtILlwbn02lvz1xTpmB+a8wKbqtxInzTLxuDr/tMFwl4I5JV03c6 VVQPCkbNI4Z6Fr+YSshFJZG7HGhSrRIwyx2WL7JXQGCSRxKWea10Ha1Bd4eyNFfzS7n4ckbyOGk c9T3VAahptiC5h0B0yLOEekcDzgZEv X-Received: by 2002:a05:6000:603:b0:463:1d06:ab33 with SMTP id ffacd0b85a97d-4631d06ab96mr1913666f8f.27.1781699163597; Wed, 17 Jun 2026 05:26:03 -0700 (PDT) Received: from localhost.localdomain ([62.77.90.70]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-462e7fc53fasm3497433f8f.33.2026.06.17.05.26.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 05:26:03 -0700 (PDT) Date: Wed, 17 Jun 2026 14:26:01 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Li Wang Cc: akpm@linux-foundation.org, tj@kernel.org, longman@redhat.com, roman.gushchin@linux.dev, hannes@cmpxchg.org, yosry@kernel.org, jiayuan.chen@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, shuah@kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko , Muchun Song , Shakeel Butt Subject: Re: [PATCH v7 2/8] selftests/cgroup: avoid OOM in test_swapin_nozswap Message-ID: References: <20260424040059.12940-1-li.wang@linux.dev> <20260424040059.12940-3-li.wang@linux.dev> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n7t6jkbdigw2ibo4" Content-Disposition: inline In-Reply-To: <20260424040059.12940-3-li.wang@linux.dev> --n7t6jkbdigw2ibo4 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v7 2/8] selftests/cgroup: avoid OOM in test_swapin_nozswap MIME-Version: 1.0 On Fri, Apr 24, 2026 at 12:00:53PM +0800, Li Wang wrote: > test_swapin_nozswap can hit OOM before reaching its assertions on some > setups. Is it because of differences in available IO or what does it depend on? > The test currently sets memory.max=3D8M and then allocates/reads > 32M with memory.zswap.max=3D0, which may over-constrain reclaim and kill > the workload process. >=20 > Replace hardcoded sizes with PAGE_SIZE-based values: > - control_allocation_size =3D PAGE_SIZE * 512 > - memory.max =3D control_allocation_size * 3 / 4 > - minimum expected swap =3D control_allocation_size / 4 >=20 > This keeps the test pressure model intact (allocate/read beyond memory.ma= x to > force swap-in/out) while making it more robust across different environme= nts. I see you used allocation value that is preserve absolute values from 64k s= ystems test is differnt on 4k ones. Any specific reason for that? Thanks, Michal --n7t6jkbdigw2ibo4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCajKSVRsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+AhqQQEAhKvnU2uXdtmJBVHmhU0h vihGBStgNmEeFai/1TzvfbMA/jfIjPkmuNEjQrWZRoxCNCCn746++JvMF9TKwDBC VKQL =xbR8 -----END PGP SIGNATURE----- --n7t6jkbdigw2ibo4--