Linux cgroups development
 help / color / mirror / Atom feed
From: Youngjun Park <youngjun.park@lge.com>
To: Xueyuan Chen <xueyuan.chen21@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	baohua@kernel.org, zhaonanzhe@xiaomi.com, hannes@cmpxchg.org,
	mhocko@kernel.org, roman.gushchin@linux.dev,
	shakeel.butt@linux.dev, muchun.song@linux.dev, chrisl@kernel.org,
	kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com,
	bhe@redhat.com, david@kernel.org, ljs@kernel.org,
	liam@infradead.org, vbabka@kernel.org, rppt@kernel.org,
	surenb@google.com, qi.zheng@linux.dev, axelrasmussen@google.com,
	yuanchu@google.com, weixugc@google.com,
	baolin.wang@linux.alibaba.com, hughd@google.com
Subject: Re: [RFC PATCH v3 2/4] mm: distinguish large folio swap allocation failures
Date: Wed, 22 Jul 2026 01:13:09 +0900	[thread overview]
Message-ID: <al+alXxG/8XRCM3y@yjaykim-PowerEdge-T330> (raw)
In-Reply-To: <20260717122514.51514-3-xueyuan.chen21@gmail.com>

On Fri, Jul 17, 2026 at 08:25:12PM +0800, Xueyuan Chen wrote:
...
>  	local_lock(&percpu_swap_cluster.lock);
>  	if (!swap_alloc_fast(folio))
> @@ -1730,11 +1734,16 @@ int folio_alloc_swap(struct folio *folio)
>  	}
>  	/* Need to call this even if allocation failed, for MEMCG_SWAP_FAIL. */
> -	if (unlikely(mem_cgroup_try_charge_swap(folio, folio->swap)))
> +	if (unlikely(mem_cgroup_try_charge_swap(folio, folio->swap,
> +						&nr_swap_pages))) {
>  		swap_cache_del_folio(folio);

IMHO,
If we get here the allocation succeeded and only the charge failed, so
we already know global swap space exists.
(And also swap_cache_del_folio right above even puts the slots back, 
so nr_swap_pages goes up again)

Could we just take the margin and decide -E2BIG or -ENOMEM from that?

Youngjun

  parent reply	other threads:[~2026-07-21 16:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 12:25 [RFC PATCH v3 0/4] mm: avoid large folio splits when swap is unavailable Xueyuan Chen
2026-07-17 12:25 ` [RFC PATCH v3 1/4] mm: add page_counter_margin() Xueyuan Chen
2026-07-17 12:25 ` [RFC PATCH v3 2/4] mm: distinguish large folio swap allocation failures Xueyuan Chen
2026-07-21  8:15   ` Barry Song
2026-07-21 11:53     ` Johannes Weiner
2026-07-23 14:49     ` Xueyuan Chen
2026-07-21 16:13   ` Youngjun Park [this message]
2026-07-23 15:15     ` Xueyuan Chen
2026-07-17 12:25 ` [RFC PATCH v3 3/4] mm/vmscan: avoid pointless large folio splits without swap Xueyuan Chen
2026-07-21  8:00   ` Barry Song
2026-07-17 12:25 ` [RFC PATCH v3 4/4] mm/shmem: split large folios only on -E2BIG Xueyuan Chen
2026-07-21  7:57   ` Barry Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=al+alXxG/8XRCM3y@yjaykim-PowerEdge-T330 \
    --to=youngjun.park@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bhe@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=chrisl@kernel.org \
    --cc=david@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=kasong@tencent.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=nphamcs@gmail.com \
    --cc=qi.zheng@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=rppt@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=shikemeng@huaweicloud.com \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=weixugc@google.com \
    --cc=xueyuan.chen21@gmail.com \
    --cc=yuanchu@google.com \
    --cc=zhaonanzhe@xiaomi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox