From: Weijie Yuan <wy@wyuan.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: "Yahya Toubali" <yahya@yahyatoubali.me>,
"Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst
Date: Mon, 20 Jul 2026 01:21:31 +0800 [thread overview]
Message-ID: <al0Hm-K2qj5KsOWS@wyuan.org> (raw)
In-Reply-To: <87zezn3p4r.fsf@trenco.lwn.net>
On Sun, Jul 19, 2026 at 10:44:52AM -0600, Jonathan Corbet wrote:
> Weijie Yuan <wy@wyuan.org> writes:
>
> > On Sat, Jul 18, 2026 at 04:19:08PM +0100, Yahya Toubali wrote:
> >> Remove trailing spaces on lines 1335 and 2197.
> >>
> >> Signed-off-by: Yahya Toubali <yahya@yahyatoubali.me>
> >
> > Hmmm, for a file that might be modified, I wonder if it makes sense to
> > include fixed line numbers in the commit message. i.e. When the line
> > number changes, your commit message will become meaningless.
> >
> > I'd love to hear others' comments.
>
> Honestly, I question the value of churning the files for a couple of
> trailing blanks in the first place. There are *so many* ways in which
> our documentation can be improved, and this doesn't approach any of
> them.
Yeah, exactly. I even spent some time comparing letter by letter to
figure out exactly where the changes were made, because I didn't
initially read the commit message. ;-)
But I recalled Greg KH's classic email as I've checked this is Yahya's
first contribution known on the list.
https://lwn.net/Articles/658231/
So I was like, okay, first time, let's understand and be inclusive. And
apparently he (or any other pronouns if you prefer) was trying to figure
out how to send his patches out correctly. (I noticed that before this,
his first version of the patches did not even form a series.)
So hopefully Yahya could get familiar with the process soon and start to
make more useful contributions as Jon expected.
But as for whether to accept this or not, I'm afraid I have no answers
or suggestions. (Naturally, there is no authority either.) While
objectively speaking, this patch is indeed rather embarrassing. It's up
to you Jon ;-)
Thanks,
Weijie
next prev parent reply other threads:[~2026-07-19 17:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260718151913.1892547-1-yahya@yahyatoubali.me>
2026-07-18 15:19 ` [PATCH 2/5] Documentation: admin-guide: fix trailing whitespace in cgroup-v2.rst Yahya Toubali
2026-07-18 16:14 ` Weijie Yuan
2026-07-18 16:16 ` Randy Dunlap
2026-07-18 16:32 ` Weijie Yuan
2026-07-18 16:56 ` [PATCH v3] " Yahya Toubali
2026-07-18 17:24 ` Randy Dunlap
2026-07-19 16:44 ` [PATCH 2/5] " Jonathan Corbet
2026-07-19 17:21 ` Weijie Yuan [this message]
2026-07-18 14:40 Yahya Toubali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al0Hm-K2qj5KsOWS@wyuan.org \
--to=wy@wyuan.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=skhan@linuxfoundation.org \
--cc=tj@kernel.org \
--cc=yahya@yahyatoubali.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox