From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: [PATCH] blkcg: fix call_kern.cocci warnings Date: Fri, 31 Aug 2018 12:01:38 -0700 (PDT) Message-ID: Mime-Version: 1.0 Return-path: Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dennisszhou@gmail.com Cc: Jens Axboe , Tejun Heo , Johannes Weiner , Josef Bacik , kernel-team@fb.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, "Dennis Zhou (Facebook)" From: kbuild test robot block/blk-cgroup.c:243:57-67: ERROR: function blkg_create called on line 1260 inside lock on line 1259 but uses GFP_KERNEL block/blk-cgroup.c:243:57-67: ERROR: function blkg_create called on line 922 inside lock on line 911 but uses GFP_KERNEL Generated by: scripts/coccinelle/locks/call_kern.cocci Fixes: 6ef69a3a0b4a ("blkcg: change blkg reference counting to use percpu_ref") CC: Dennis Zhou (Facebook) Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- url: https://github.com/0day-ci/linux/commits/Dennis-Zhou/blkcg-ref-count-refactor-cleanup-blkcg-avg_lat/20180831-161742 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next :::::: branch date: 10 hours ago :::::: commit date: 10 hours ago The kbuild report doesn't include enough context to check this. Please check whether this is appropriate and whether another approach would be better. blk-cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -240,7 +240,7 @@ static struct blkcg_gq *blkg_create(stru blkg_get(blkg->parent); } - ret = percpu_ref_init(&blkg->refcnt, __blkg_release, 0, GFP_KERNEL); + ret = percpu_ref_init(&blkg->refcnt, __blkg_release, 0, GFP_ATOMIC); if (ret) goto err_cancel_ref;