From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Rientjes Subject: Re: [RFC PATCH] mm: thp: grab the lock before manipulation defer list Date: Fri, 3 Jan 2020 11:29:06 -0800 (PST) Message-ID: References: <20200103143407.1089-1-richardw.yang@linux.intel.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=xiCyHmcnUXsbcQ7aHolyREhLRtQlcm0tNcQpv0xj54g=; b=otHt/I+pw8YEKdneORJaQbqVOMxTvFzuxsTLLo7ZOfnkm7+sA/s/x+b5ZiwnwdyNsM mfRl/YbfDdxHzR2Rfe0dAizN3JrCsQ76Os4SjYyo9S1ECVmqUOML8K8S/YBi5lHfUumH I5sRO4W4LYYWzpp+g2tfXYM8x+1i2fRx+TVLGkGcDO7rAoq4BzN5giqoCdnq10C+hw+o NVmD4trJFm7qSbm58YTvtBPmdSOVfFH9OlPvaUYGTkLBuR4W1QJa14C5GlU267SLGDIk nJvj1z52hjwCB/qZkkakQbkJqE7ovBP/lPjUGrjm7HuF9J8UTNwBPO9jMGL9+KBvpBx7 97Og== In-Reply-To: <20200103143407.1089-1-richardw.yang@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yang Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yang.shi@linux.alibaba.com On Fri, 3 Jan 2020, Wei Yang wrote: > As all the other places, we grab the lock before manipulate the defer list. > Current implementation may face a race condition. > > Fixes: 87eaceb3faa5 ("mm: thp: make deferred split shrinker memcg aware") > > Signed-off-by: Wei Yang > > --- > I notice the difference during code reading and just confused about the > difference. No specific test is done since limited knowledge about cgroup. > > Maybe I miss something important? The check for !list_empty(page_deferred_list(page)) must certainly be serialized with doing list_del_init(page_deferred_list(page)). > --- > mm/memcontrol.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index bc01423277c5..62b7ec34ef1a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5368,12 +5368,12 @@ static int mem_cgroup_move_account(struct page *page, > } > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > + spin_lock(&from->deferred_split_queue.split_queue_lock); > if (compound && !list_empty(page_deferred_list(page))) { > - spin_lock(&from->deferred_split_queue.split_queue_lock); > list_del_init(page_deferred_list(page)); > from->deferred_split_queue.split_queue_len--; > - spin_unlock(&from->deferred_split_queue.split_queue_lock); > } > + spin_unlock(&from->deferred_split_queue.split_queue_lock); > #endif > /* > * It is safe to change page->mem_cgroup here because the page > @@ -5385,13 +5385,13 @@ static int mem_cgroup_move_account(struct page *page, > page->mem_cgroup = to; > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > + spin_lock(&to->deferred_split_queue.split_queue_lock); > if (compound && list_empty(page_deferred_list(page))) { > - spin_lock(&to->deferred_split_queue.split_queue_lock); > list_add_tail(page_deferred_list(page), > &to->deferred_split_queue.split_queue); > to->deferred_split_queue.split_queue_len++; > - spin_unlock(&to->deferred_split_queue.split_queue_lock); > } > + spin_unlock(&to->deferred_split_queue.split_queue_lock); > #endif > > spin_unlock_irqrestore(&from->move_lock, flags); > -- > 2.17.1 > > >