From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hugh Dickins Subject: Re: [PATCH v21 00/19] per memcg lru lock Date: Tue, 5 Jan 2021 13:35:20 -0800 (PST) Message-ID: References: <1604566549-62481-1-git-send-email-alex.shi@linux.alibaba.com> <49be27f2652d4658f80c95bea171142c35513761.camel@redhat.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=0hmHryJfbf/XT9z825YcWQkO0BUnqygh/hnGzawmTrY=; b=ulzDg2IasU4VsBB0KyNVFZxes1bxHLiVNF/IhndXx0/HSPvfKmMt3cBCtUJHxjWu7w C0Q4SrWmKapNA8Wsr861GbH/g+uH75/m+kXBeGchxMklBe9rYzJZ6KgP2F9YQLuV6duU vZ94xR1xktoGZvvSxbqw3Ibo78we4eI6TXvJR8MEWFmQV3C/J66qSjiMRj8NaCNr8DYk 811SPpXl0e5iMH97feJnxm8ANn4PHHtVr+UfeqAho94TMgvDHDc3/iVOnhMw+I+4LLAl F1K/SsUTZ7C2+/VJf5icCjpptLOW34t2RQ0wjVlZtNcliYZcL0Wzg1CH1ooUpox46P00 amcw== In-Reply-To: <49be27f2652d4658f80c95bea171142c35513761.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Qian Cai Cc: Shakeel Butt , Alex Shi , Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Matthew Wilcox , Johannes Weiner , kernel test robot , Linux MM , LKML , Cgroups , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" , alexander.duyck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, kernel test robot , Michal Hocko On Tue, 5 Jan 2021, Qian Cai wrote: > On Tue, 2021-01-05 at 11:42 -0800, Shakeel Butt wrote: > > On Tue, Jan 5, 2021 at 11:30 AM Qian Cai wrote: > > > On Thu, 2020-11-05 at 16:55 +0800, Alex Shi wrote: > > > > This version rebase on next/master 20201104, with much of Johannes's > > > > Acks and some changes according to Johannes comments. And add a new patch > > > > v21-0006-mm-rmap-stop-store-reordering-issue-on-page-mapp.patch to support > > > > v21-0007. > > > > > > > > This patchset followed 2 memcg VM_WARN_ON_ONCE_PAGE patches which were > > > > added to -mm tree yesterday. > > > > > > > > Many thanks for line by line review by Hugh Dickins, Alexander Duyck and > > > > Johannes Weiner. > > > > > > Given the troublesome history of this patchset, and had been put into linux- > > > next > > > recently, as well as it touched both THP and mlock. Is it a good idea to > > > suspect > > > this patchset introducing some races and a spontaneous crash with some mlock > > > memory presume? > > > > This has already been merged into the linus tree. Were you able to get > > a similar crash on the latest upstream kernel as well? > > No, I seldom test the mainline those days. Before the vacations, I have tested > linux-next up to something like 12/10 which did not include this patchset IIRC > and never saw any crash like this. I am still trying to figure out how to > reproduce it fast, so I can try a revert to confirm. This patchset went into mmotm 2020-11-16-16-23, so probably linux-next on 2020-11-17: you'll have had three trouble-free weeks testing with it in, so it's not a likely suspect. I haven't looked yet at your report, to think of a more likely suspect: will do. Hugh