From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70C054AA585 for ; Wed, 2 Sep 2026 17:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788369703; cv=none; b=ZKQrldBahOPtaIbagbUvfPUXpGz0Cd69pROvozKva9oOEQ2IepMXxV1Kn+hA+OihDjYGNG4j7c8V7jTvewHMomFx+0I916mcNf69dANhNa9Se6Uq9NWrHmj7J6fsZ7WZve+neUfLmehAzV/uL49f5UrugBaqNSzY4gNiXczo+sc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788369703; c=relaxed/simple; bh=m+JVflRfogZkAqD6QsXF3pZmp6uJr0RtWwe9UeEcILs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aLzxZ6gVvzruN8UgpO9GetngCwj/9Nx2C/CADak9JGwZ+9SPhubWUf1CTD3HYHlvKF9wkwnSd+Qmhxh+E/dDjEX/HRg8wItNc80oBC6D2eMAYD4sEy0fgFDEQjvIc69pIkA7kw6pLXkdgZPGEF9JrrWS3APmP3ylHHHyNuB73hA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SXjFc8my; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SXjFc8my" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-49b392ccaacso19952005e9.2 for ; Wed, 02 Sep 2026 10:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1788369700; x=1788974500; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=mbr8vDhDQK57otnRsW80mi/+agFd8G6T3W4N93pfIMo=; b=SXjFc8myRRa5xojHOKjeEhB6i/sBvtxJUJeidgzE3zQKvBcpPwhhj/M4U5r/ZFSO0r EfXwzCFKIPOCgfdXI2NFqY7pJIKRcugPakyfkFs5OwNFXVrQVqrGm+hDwMWBSsAuwXQf tC9TnMBgZlR5GaamYt71w3a+LpxeY9oR2CqFPJzyLwLg0Jl4MNKtbznLSKvu1qb+iBMX l9NmW1reQ4iDF5EsBLmQJS4Eu1lrfv0pucjjkNnWO3OZTdYIozFfFa53uQJQ0K6/8YVo YHM1D/v6OwpaPdYOb5zuyC8zD0wNPmBA5FM8OLkOW3HEAZyCYDEBlepEBuEUPzHXyfsR 2/4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788369700; x=1788974500; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mbr8vDhDQK57otnRsW80mi/+agFd8G6T3W4N93pfIMo=; b=KjAtOKRDjYegaDD3qiJB0bOv0RQGjJb65kRcs4mjWwceDl7aN9ZijEXOV10+65HYN6 nhWM0B5jDmlpE7We00ny5vmRCZ4N80GYrs9IB6nzT/0kt84P+iGMGUTlHGzV6hTCXs28 LcMppz8Fk15qMcvFtSRmRD/WhyE1zQ8rDT/71dstEFg1zZd0Wx1ArQ8JqByFtkHKkcUa OtwQVVmoSFy1fbL7HHe8S5RLJf0EPJzuT+YOv0oBQma0pmyZULSw5TTsbJ/6iTdzR3Pz hwbmQwQy2xgWXbDTu+nhSkt82vgMkfq/Li9csVG9jpcTEknR0A+GCekzifk/fnNLcMZq CHmw== X-Forwarded-Encrypted: i=1; AHgh+RpZhkyG5UlXOTvn9de88dmslQWPunCtNtMOFSG1Rjo0CMhDTQf/gU/U8RM/UtTS9o7WYxQuzah7@vger.kernel.org X-Gm-Message-State: AFuF++mTEg2UjrsihsKfnDa+Avjudl9k6x8GWPwULev/WPuRVtVgx7M5 ZGUkRkhcsEUXrbechG7bPAnK9D4OzwuAdYOYxyJB2gsvtoxPA9dRmsYcgs6lpoKmXK0= X-Gm-Gg: AR+sD13fiygFB4EbHFUN2ocQNnP5ZUGzw0QYCisvUG7MfINlwV2gh+XXP3TZIh04jHA i4GObKKtqnScwlRTm+EBQfEMO+BBXOUQ1KXz+3qbpuvSnkrR29dmDVfuxKrY2z5YwgL2rkWugRo lna8Rb5xy5HUQBwWzf6Zv9eJpU8mEMndkFrUbRxsr91EwIMswtvBI0HVQUnn9hJTl33WFPBUdc9 M6u5Bpvsuo7ODbDxt7Yw8qKkL1ktRe72wEjsKHj4TJNB/FYjI2RedOhGdQF3qcoD/ufqSK1Mdq+ KPBFzCFaSfDHBHS6k0uysKNNn2TJaaQCDk86px/hoHZxA/J9qFrdr4sVXIz999E6Sq5OCnxEx6h fIn0SGvpxVQCJcskduSEQGJii4YdMF19cEnFQdkTV3lIoWJP/TBgE0/liSmvXS8eXTOuVYq98PU AhxtBvGEr3OOU5nrueJaRtRYWNgVKYggotTbczsZ0lSvf5WQPREeC/TXmZ3ftxzbw= X-Received: by 2002:a05:600c:4592:b0:496:c1f3:e8f8 with SMTP id 5b1f17b1804b1-49ce5828104mr100735675e9.7.1788369699585; Wed, 02 Sep 2026 10:21:39 -0700 (PDT) Received: from localhost.localdomain ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce554d52esm46037545e9.3.2026.09.02.10.21.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 10:21:39 -0700 (PDT) Date: Wed, 2 Sep 2026 19:21:37 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Wilson Felipe Pereira Cc: Andrew Morton , Johannes Weiner , Yosry Ahmed , Nhat Pham , Chengming Zhou , Tejun Heo , Shuah Khan , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] selftests/cgroup: test_zswap: fix implicit unsigned promotion bug in test_no_kmem_bypass Message-ID: References: <20260901052250.154532-1-wfelipe@google.com> <20260901052250.154532-3-wfelipe@google.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="brfghnffrv7lgskx" Content-Disposition: inline In-Reply-To: --brfghnffrv7lgskx Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v5 2/2] selftests/cgroup: test_zswap: fix implicit unsigned promotion bug in test_no_kmem_bypass MIME-Version: 1.0 On Tue, Sep 01, 2026 at 10:42:51PM +0000, Wilson Felipe Pereira wrote: > I like this option a), any thoughts on the sequence here? >=20 > I thought the following steps: > 1) Add cg_read_key_s64() here and make use of it; > 2) In another patch (probably 3/3), replace all uses of cg_read_key_long > by cg_read_key_s64. There are 41 uses currently. Sounds good to me. Michal --brfghnffrv7lgskx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCaphbHRsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+AgYRgEAp30olA9rJ2qhGFysO4s+ aIyThbEl72AZDl4Xoxzmfa0BAPTcX/yNIMQiLrmSpdmTPSJc835GqqqammL+Cq4q NggI =9Inn -----END PGP SIGNATURE----- --brfghnffrv7lgskx--