From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outbound.qs.icloud.com (qs-2002k-snip4-11.eps.apple.com [57.103.87.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C64C0362157 for ; Sat, 5 Sep 2026 19:45:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=57.103.87.241 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788637532; cv=none; b=Emjddkk3p+5RuzhS+Yx8AqN/EmH7jrrN0gbosxvwbVPwN9bExo109069dphoSQYVgKdFOuJUyA/aDHmcLqyMeaSoN1gu37AT38IwnE22ljZleEriuxaVoOYCzZdhrH5Nf7wiHr5NS30TYAozhdukQzrHEPKlTQbe26LeYzZaLv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788637532; c=relaxed/simple; bh=//O8GUFvqWQzoMuotouB0rhwfAAonXTClvTHtBUf2ik=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g23Al+gCTN7/PVKqRD301dSXz0tp1I8Nyux7zpr5P2ALBWTctkEvLt+O+WINbqZiPkWGNNy1Xkv1FYU4wa5u2RaPOvNPzjm9S8hedb1OafLn2Y9ApH/7XRebokeIZdJiNRrFTDO4Vada/3wEdoJgKcmlMAmMrXJF9UggUsrym9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com; spf=pass smtp.mailfrom=icloud.com; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b=LVeAVtSx; arc=none smtp.client-ip=57.103.87.241 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=icloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b="LVeAVtSx" Received: from outbound.qs.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-east-2d-60-percent-7 (Postfix) with ESMTPS id 59424180014F; Sat, 05 Sep 2026 19:45:26 +0000 (UTC) X-ICL-RepId: 01a0731a-b916-706c-866a-caa7764bf380 X-ICL-Out-Info: HUtFAUMEWwJACUgATUQeDx5WFlZNRAJCTQtPHV4PRQBAC1YGVBcOVk1bHlQYWCtbE1UXRgkZCF0dGR5XUF4IXh9MHB0OWAYSAlpFAlQXA1ccVkVcGEMJXQVXHB0cREVbE1UXRgkZCF0dGQhHHwowA0IOVgNDB0UALRkcV1BeCF4fTBwdDlgGEh1QHA5RVhtKCGpVYUBwDGoAXFVjGXcpez5+PnIjcCxnPxQ1cF0JS0YJSR0OBFQHXQVd Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1788637529; x=1791229529; bh=Ij/H9+RBYCrUvtV8IoLnxtztar7yjDWo8m1G+THjprc=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:x-icloud-hme; b=LVeAVtSxWH68i77itB0aCkIdGp1AYxueIQoJ7yD1Te4NcKuQYecoYP1k3yoClD99uN+WLDNYYm8+roED7cTG95Fg0L9u0B3iTP4keGaWlZAsiPW6YACcilaV9AJ+9Ga7cG3QKyMtDx3yt3JMYhAiz5A1XSKNo0BVM7HhhVYoc0cYJ32wZQm3KSkupQPFJG+q5h2K7pXMtDTpk8OHxYsRcsiEzpCDROsLq/1MwymhsHABXlSVlMjRM2rBBnuQw8l1i57QHlYcD4XscczDSaVZWpkbU6r3miQ0bIb0lQGNlSCfxsPoU6wcfSsbrd3YNWIeWlGZfRUT1Tvv5CGyT4r6CQ== mail-alias-created-date: 1772519804199 Received: from BINGFANGGUO-MC0 (unknown [17.57.155.37]) by p00-icloudmta-asmtp-us-east-2d-60-percent-7 (Postfix) with ESMTPSA id 6AECF1800136; Sat, 05 Sep 2026 19:45:20 +0000 (UTC) Date: Sun, 6 Sep 2026 03:45:15 +0800 From: Bingfang Guo To: Muchun Song Cc: bingfangguo@tencent.com, Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Andrew Morton , Dave Chinner , Qi Zheng , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , David Hildenbrand , Lorenzo Stoakes , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 6/6] mm/memcg: filter out reparented memcgs got from memcgid Message-ID: References: <20260901-bingfangguo-memcgid-rework-v2-0-8edd7f7a7251@tencent.com> <20260901-bingfangguo-memcgid-rework-v2-6-8edd7f7a7251@tencent.com> <3F681C23-8462-4BA3-B3C6-B7A45A9341DE@linux.dev> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F681C23-8462-4BA3-B3C6-B7A45A9341DE@linux.dev> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA1MDIyMCBTYWx0ZWRfX2PDczRc5LH1h D4z6/Oc2ZOgPy2Yg6O5ebmL+K6RFGGxaWwV9I7m208B/3hnr8/lQIRTsKkasKOAy7GU1w+zbP3o JHQyMs3g5aJw9Rfq/8o5T2uG6PaLE95unk7Wkdn1eCDELIlSAJONDrsEGwrwYsEgKU1aQMFURvD BXXRh33KL7ZFfxKiQjDPvDVs2SD7ql9RTiJx7Z0hgLmKgTVKJ6Tzh29jtqM0xma2PeT7de1iDKe dAqBKnmPEb0EPjx9IGSTx1BZOHyLnI5c0d+rzGuCEjxMp/mQp2SYcRNeUbDOencPxA8bbHsQIwK KQK3KJfbiDU7N98pi12kp2kp9PFLwIJkNQGx3UGCt8qw4vhuDSm40WT6tn418c= X-Authority-Info-Out: v=2.4 cv=YaWwJgRf c=1 sm=1 tr=0 ts=6a9c7157 cx=c_apl:c_pps:t_out a=bsP7O+dXZ5uKcj+dsLqiMw==:117 a=bsP7O+dXZ5uKcj+dsLqiMw==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=x7bEGLp0ZPQA:10 a=vu5NlEYW-o8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=GvQkQWPkAAAA:8 a=6M0O934HbYkpANdxMewA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-GUID: m84ibJRqfqn4m4oan2iZ5z6B25R83_2u X-Proofpoint-ORIG-GUID: m84ibJRqfqn4m4oan2iZ5z6B25R83_2u X-JNJ: AAAAAAABnlKTAD41Z2yG/m3BLmu03FzCv6P+TssBS4Z3iT0XZRv7suIlbp/8UGzEzz8R5cZp85bnVIKpRA66ix7pp+BPvgsO71JbgM/t9HkF+nk+x2zMCKsG6rVVCI3u8V80BZRFT4UFFOnwa2yaSa2+FXnQzohdUQEccEfKNLo3MqTxglUhiyeam+SgPZCQXISKl0o/tG3V3fAqidxwPqUuH9zAjMla9BUzRNwtqZ/BLWaebuTNAEsy+sGMGJcmEbki9gttDN7/vMSCQfyUY3lxuMTivtSKkOvO2FVAfba3agl5DPH5IvFpbA/FAQaxcUD6OVPxbKylA4PAns6i5NcdTxCM80bsVpbNxWrECNtzOKNEca99i20sm/zbmwdMJITx+wDFMYB/+oNd7jf7EE/wRaGQKrbqfhty9SMurB1MbR6fay7uA4T8o3HxvdIJV4RPqJXkxVfM2dZ001AeXh8rzGEVyxQLRvkLhDD7vfZHDFqQEW00IOw8qzieKYoqgnJr2cKjE16pCpk2qeQO9eZmD41oDqNExxQHbOmMoA49VRwOQub/LZ6cD7ngr7S/uGbw95I0gDz/hlDzgOfYFhk1aXrvxTNTjakByChluS1c5z5DwhqmguJvK03cxGa+HE959+Nw8yWpo/FoYkv2ghfu3j3sJb7H+R85QA0x9vnF7lezFuwyAocXxfY2o4eIHf9DUVlOeiG/eJO3NinHpnB+0R8KRzSH5p3M9tqXnnTYloQ+Jjf3mJ5rYk4P0wk4gbmi4llXOQqjWi4AS1wRf47CNoJgC/AcZPpk1W0rkwrYWvsi/E6Wk3OJFk8BRnugmTMQjahX+vC18mfEMPNSrwJ7yaK35SQ4eSWSzoKxE6TXZzCvJvGK2jK92lXmHxta+dyp/XJoQAK/2twZcJd2xS3++F/DtRAcP7P6uGzd1tGDhn5636zplXHpr/6dNLzOzNCkVq8e6PXulzmFNK4eMNB7fGz7OFk L9R80FqXVAbuZRkpgbklRyfrwniUhWcmr9loArYWiKt7MBBzRlxT8JKJR7/gFFG4tIzUmn4ysZpscMA+noWLFAsGZ2hPZp5Q8A59tDsZovFo+VMnxcA3lWNpqUOJtzPKdhTyFM439LVLky8CKgJxS66nLjkGmd9F16sTBFjzIwrywE5R71BhcQDziKfek4p9RWKIrj7H8fGi/lhzbq6EiYxcxhlTjdJW5ngSQgjdG0XSlCy3XAWX1TXXK8vEcybloEQxsFamkPoN0yCsppwlJxGa1/pfJACpJbm+7GOUIjXUcT24nCs/1YVNHkYEZTrjYPV3rlZ0vShd3nw8HXegg5BeS4idGuDve+Mdliajgb5Ld2/0hiF5TaWQlNx38dkWNb8SpOaYL7jaHXOyfcNr14hRcfnGH/mDHDjfvQgWMRrWzvt3L9N9rzzKnYIC2nSZK6RC1sEot+cw/dFuJOqU7m2sDH6BsaiX9bP3S On Sat, Sep 05, 2026 at 08:18:03PM +0800, Muchun Song wrote: > > > > On Sep 1, 2026, at 16:58, Bingfang Guo via B4 Relay wrote: > > > > From: Bingfang Guo > > > > mem_cgroup_from_private_id() looks up the objcg that owns the id and > > returns the objcg's current memcg. After reparenting, that memcg can > > differ from the one the id originally belonged to. > > > > Callers such as the list lru and workingset refault code expect to get > > back exactly the memcg referred to by the memcgid, so check that the > > returned memcg still owns the id and return NULL otherwise. In this > > case, make list_lru just skip and workingset tests use the root (as the > > comments said in workingset.c:460). > > > > Signed-off-by: Bingfang Guo > > We should move this patch earlier to avoid introducing the problem first > and then fixing it later. OK. I will keep that in mind. Regards, Bingfang > > Muchun, > Thanks. >