From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DD254825B1 for ; Mon, 21 Sep 2026 14:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790000001; cv=none; b=A1GFmYalBMofg7r93xKCIby0h4kOReVP/XwshUyre4fK9CPCnSel9+3Aum1mXGCNLfH4GG4bA8MNX0xWQt4ut6WCgGvDhxsCb9Dz3czeCFUDlAvlviVFUAMkecEmA70j4FZrD3Aq857h5LvpOaTQa/ekFsdSwP2IG6sdU4/XfLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790000001; c=relaxed/simple; bh=FPWqC66o0DYZqJN5PzsSkHRliknVuMnTz8yDSq8JJ2M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cvdgDPQF6HkKplQyaXbQfpLJ4hA+KAPaUegLPnV/FuJp4XqA57piNJkUw1VaA3cBqATTjKLWaIFae1dGnyDvcCtonA/Yh/yb8+HFRCo+GC+AlBxudbA29jT7w/8KGTa2ft0eqd+7iRlpG37gQe80cTmPK4/Uf6OD+bl/6ru1VMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=fzu2CmwN; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="fzu2CmwN" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49e73611928so19429775e9.1 for ; Mon, 21 Sep 2026 07:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1789999997; x=1790604797; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cZmbAJJNnfDZG7kkKrTMELDcFp2a6nfaCSWGLZAt/V4=; b=fzu2CmwNwmu4EzyDm/SS+HyLsxT9GLO6/oTBd7xz4C1+ZERrsqJ/T4lE3y/ntmOUu8 iNt49knAFeGGNGAmBdrwAuw+cyegVmc5P1ZaitZYOmDilf8wyaWpGNp9muuEsKRGJpe4 W6jo2WRhigpu/r9DDGq+jcywXQZU+N9fHOJkMXis7yh/eIWnYVQ9b5r1PKLKvk9pEHFp Afu7JC4jS14TexS9zgW9KK4b94J1balJ386mJB/75wEtZWWyHi7fpaA4PxYiMFLdlYm+ thJMOexv22zR+emVktFgKcg3ZRZ8WM4tezCKgTJIb6FxqH4vAN6MXQKFV4Qus1z1qRQI MsYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789999997; x=1790604797; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=cZmbAJJNnfDZG7kkKrTMELDcFp2a6nfaCSWGLZAt/V4=; b=ryvvjy1lcVzfEDw1tIY50t+Rq23hXW1k+S6pk1ibvYpNHuWk+GziRA6hniQQxxDuG3 6FQMWKyAcCqBruYjQ/TaHKnL2YF2tNX7Mifnw+7nW1eFnTi8OwZjZzPWhr/jLYHw8/J8 VNEo8E64ZkWc81xRXrdwPAsL7QvHgz1SkXAUzsKISSjNlp6pleou4SbfBuxlkEZqsaEN z5XHBStQk9ZpjJz+3xSr277dK2PUqSudi1c+TsL0BSagMeuyUIbeelyWlrBxIxwlahFO eE51hdTMDxjdW7NMV/SsdkIvbHSm08p6zoZrv92O6je3dfMZLOk/+UMyPwEuhWo6ZImT kHyA== X-Forwarded-Encrypted: i=1; AKwUvByKBTj/4Bix7B863s/CVcMM+FtaKOHcByyugJGIJV+PZjK7JTLu1lIgUkJ5cZdIRbIkCqyZ7lJy@vger.kernel.org X-Gm-Message-State: AFuF++lGSBrxns9BmPSQnuZ0ZoCs2UVNFuFxkGWh2lshqxb+mi7fxjnq 40m/6wv8prVt5EQ09qR8HWoQE+xp5wA+TNVBgfTEtgyvycfMJY6ZMo6Qxv3aHQjFHzk3Fz8Dg6+ bCNPCjr4= X-Gm-Gg: AYBFou3k1K8RWGdj2dM+yZKEPJ9Tx5QQRgjfzNMvJkAd1aGQsQZPfhhz+5STProWWPx keUDV+ohoEQAG8YTvLef0cSyB7a8Z+aZvqXl9saEn8nrjcrAsZoE+i5/4uvmczPDJKCh+8MdQlw u7dX0uSvucmfmhSUGSp36aIlckBN30fNZ3pBk5sjoEbTCgziRgPCxWJbfMOA9wziQJPOjRaJXHi 5ihOjcMOIUOpovkc3gK2DSam3aUqYGM5WzXot23q6Uiyw/mhOO2mVe2rilFbPz6UJlRZjhSxxIZ +EmnadBNIkZOJ8xE0p3aHXigtfSIIhcefXsMMH0aewLPNzC9LgNMJH0DJISzoruvIG9M/z4obZ1 1420BEgUwtZ1crlcYQ5wL/bMDSSo2TZq8DDvqOpXK91nnfMXLgyeTZJF4Udoxs76oFrnQYY3xEr YB0jVk8SnKM1ItfHBrcxK0kEznR8AJd4l5fizswbCdZXmvs5XnXixilapEPGn/usgp8b8vpQJWN BgjSIifKil+5g== X-Received: by 2002:a05:600c:c0d5:b0:49f:bd43:5a1c with SMTP id 5b1f17b1804b1-49fbd435a63mr227453445e9.15.1789999997444; Mon, 21 Sep 2026 07:13:17 -0700 (PDT) Received: from localhost.localdomain ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48724562bcbsm24917482f8f.16.2026.09.21.07.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 07:13:17 -0700 (PDT) Date: Mon, 21 Sep 2026 16:13:15 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: "Peng Fan (OSS)" Cc: Tejun Heo , Johannes Weiner , Waiman Long , Ridong Chen , linux-kernel@vger.kernel.org, Peng Fan , cgroups@vger.kernel.org Subject: Re: [PATCH] cgroup: use assign_bit() where applicable Message-ID: References: <20260920022738.3145820-1-peng.fan@oss.nxp.com> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260920022738.3145820-1-peng.fan@oss.nxp.com> On Sun, Sep 20, 2026 at 10:27:37AM +0800, "Peng Fan (OSS)" wrote: > From: Peng Fan > > Convert open-coded if/else with set_bit/clear_bit and their > non-atomic __set_bit/__clear_bit variants to the assign_bit/__assign_bit > API. > > Done with Coccinelle semantic patch: > // set_bit -> clear_bit => assign_bit > > @@ > expression cond, bit, addr; > @@ > > -if (cond) > - set_bit(bit, addr); > -else > - clear_bit(bit, addr); > +assign_bit(bit, addr, cond); > > // clear_bit -> set_bit => assign_bit > > @@ > expression cond, bit, addr; > @@ > > -if (cond) > - clear_bit(bit, addr); > -else > - set_bit(bit, addr); > +assign_bit(bit, addr, !cond); > > // __set_bit -> __clear_bit => __assign_bit > > @@ > expression cond, bit, addr; > @@ > > -if (cond) > - __set_bit(bit, addr); > -else > - __clear_bit(bit, addr); > +__assign_bit(bit, addr, cond); > > // __clear_bit -> __set_bit => __assign_bit > > @@ > expression cond, bit, addr; > @@ > > -if (cond) > - __clear_bit(bit, addr); > -else > - __set_bit(bit, addr); > +__assign_bit(bit, addr, !cond); > > Signed-off-by: Peng Fan > --- > kernel/cgroup/cgroup-v1.c | 10 ++-------- > kernel/cgroup/cpuset.c | 16 ++++------------ > kernel/cgroup/freezer.c | 5 +---- > 3 files changed, 7 insertions(+), 24 deletions(-) Nice use of Coccinelle, Acked-by: Michal Koutný (You may consider sharing an adjusted variant for scripts/coccinelle/misc/ via cocci@inria.fr ML.)