From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=40.93.195.13 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1795366075; b=pcRMjP6zNlINLuZFqELhbvhWTJXCzjt9qzrp+3dDCTsYtAtXxd5jDJL8kzHnW/irmvtr ooS5N8sAAYvkDlwHhGeyG2V9XM/0yHfgYIC8jx7+mflMo2PUGdnzA/bWxMV7sjbipbnXG Abjt9QsYHwi2ejNnyFJuKY20eDQXYq4Z9+D5Omix6PbbUgoXpSaQlUAvBFhS3YYQMt6ca 9H44a3pzFby1kTFfl9eM6NTojp/cqH7vjCX7L1QCuM1PWlxnM4C/RjDZbdyNjhzLjlmXT RIZ/65TPuZJFAeiXXIbQyo9Y0HQroNCa3j4ZLwHxtOFSV0CQxODOBzIffegzFGZXKNA== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795366075; h=DMARC-Filter:DKIM-Signature:Received:Received:Date:From:To:Cc: Subject:Message-ID:References:Content-Type:Content-Disposition: In-Reply-To:X-ClientProxiedBy:MIME-Version:X-MS-PublicTrafficType: X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id: X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay: X-Microsoft-Antispam:X-Microsoft-Antispam-Message-Info: X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-OriginatorOrg: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType: X-MS-Exchange-CrossTenant-UserPrincipalName: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=JATS/rNWdcvhmGzK9ANEDAbcukOMpu3tVj/EWIuICWo=; b=HaQgyQ7FEyYGGPsOuo9fKZeksVPhpUnlIu9lYTCTGb1mc8A0MFqy4F3bM8Nvr6TjL9Hf tPE46YAa/QZ8wL96ZwPvPlkdRH58VMgvMZi1Fan7LULgioxTuZf5R9V6oUmU5W+DCpiAG iAV7mp17Q1Hu5S42dOi9ll3UdHbJI1abpnSYiBZRckOpW1hWaCz38bsQq7PSmDW7TA+dW ZdAmRY1zxUdJjoBf5LWbJnooFZMpu6ZUFlq5g7qlevBktOhYrcaGW8UyYsg/IcF9kKDQr u7q1cve5QQrwH/bgTGpBWNNgnyZ+K90TwZt8wCaizIZlBPHceK+VrpRU6Hzk0Ov0h0Q== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=NHvteN96; arc=pass header.oldest-pass=0 smtp.remote-ip=40.93.195.13 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012013.outbound.protection.outlook.com [40.93.195.13]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65590606A32A; Sun, 22 Nov 2026 16:47:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 65590606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=NHvteN96 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XDeCJdITcEIKFadnzY9oI70AmgQ1O2qZTyxaDAtFx7xgYOn9oceyXGhqfJhqB06UuATtU1FZttoybrRYCTuHhx69U6SDQPlOtU3iXRD4DdA8VgLLwAQS1vEgpsuybuBvDiaz2uYp6I0leKj4TQNSV9r5zEMNLbVamoX5EWru4LrIGC6+2Hw3z8HJr2WExbs2W3gohwTyXuruWSrU9NiCP3N0noj6lXOA1KMWWxkAEPx+U96mwZA1md4yk7rLEPQDsNkEqxBjEE1InHBY9/H+wboKzzhi5zTa53wYZYYPrIVD4JhNW/9R85Q1mLNAkkSl5MDcFtNBBbBEaMI+Vh5AEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JATS/rNWdcvhmGzK9ANEDAbcukOMpu3tVj/EWIuICWo=; b=tCvPwZqVLOYcVZiSWEOpsr+LEAQ9XCtKPk10IL4gDgDDh6yEV7sG7LCj4CGpPPKk9MmlOpw+T60Es4acKzqjNWU4EQWQQ1RhiWlJ8f7iO3oFiJbVtOy2W2a2/oS2kpkjf4DUIomes2Ggstxg4nEpiBepbvwrYBMQsp1NandR9DOgVubYvgWk8UpHXyv91sfKpmbOqnCEyQx1el/LZnO3xFMdWEAlJynZc51Yw4JHgBknqFCev+XiGE5mZOgqqt4OKzzC8yyGUO78X6AqMkq239kvtI4hLG/M0UhqCcDFpQhJBuEdxfLdqoiybEcPppaYfHymagyOtIINwb5sSQln1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JATS/rNWdcvhmGzK9ANEDAbcukOMpu3tVj/EWIuICWo=; b=NHvteN96GqE4F5Jx69Kfk0JxoQx7aOJqTEjWKB+k7lipNrHQVgwa/mowVB2CE9nhz6j5Lzwz3v3m5NA8PHA1XSEoDxSAb74gI2ExYAwUp0a0R6EECu6tipxsf98kvSs/pj7rmfS1N7PwOJc5CAMKgMHRKm5MUoSh7yBrQvEiSMhCd2XsQCnhbezzupmtuC4QcL+JMKPKDWrjRf9qiLEAfi25veb5VudDnyLxvogM1HmpL0Ge+ZKKwNa475e3eZswPoRhwpbjQZm1su9WAd4wv8XeSfLxtZnx9DFHtRj1xqL2Q3yppsLJZ9TcCv0BXONroEp0SVzKRxiBTn5kaT8GDw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV3PR12MB9356.namprd12.prod.outlook.com (2603:10b6:408:20c::21) by SJ5PPF6D27E3EA3.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::998) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.8; Sun, 22 Nov 2026 16:47:47 +0000 Received: from LV3PR12MB9356.namprd12.prod.outlook.com ([fe80::1c36:31b4:c420:6286]) by LV3PR12MB9356.namprd12.prod.outlook.com ([fe80::1c36:31b4:c420:6286%4]) with mapi id 15.21.0639.012; Sun, 22 Nov 2026 16:47:47 +0000 Date: Sun, 22 Nov 2026 11:47:45 -0500 From: Yury Norov To: gourry@gourry.net Cc: Yury Norov , Rasmus Villemoes , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Michal Hocko , Andrew Morton , Oscar Salvador , Johannes Weiner , Suren Baghdasaryan , Brendan Jackman , Zi Yan , Jonathan Corbet , Shuah Khan , Randy Dunlap , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Johan Hovold , Joshua Hahn , Rakie Kim , Ying Huang , Matthew Brost , Byungchul Park , Alistair Popple , SJ Park , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Kees Cook , Kairui Song , Barry Song , Qi Zheng , Shakeel Butt , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Baolin Wang , Michal Hocko , David Rientjes , Pavel Machek , Len Brown , Nico Pache , Ryan Roberts , Dev Jain , Lance Yang , Usama Arif , Kiryl Shutsemau , Xu Xin , Chengming Zhou , Lorenzo Stoakes , Pedro Falcato , Jann Horn , Chris Li , Kemeng Shi , Nhat Pham , Youngjun Park , "Matthew Wilcox (Oracle)" , Jan Kara , Waiman Long , Ridong Chen , Tejun Heo , Michal =?iso-8859-1?Q?Koutn=FD?= , Dan Williams , Vishal Verma , Dave Jiang , Alison Schofield , Shuah Khan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org, driver-core@lists.linux.dev, damon@lists.linux.dev, linux-pm@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, nvdimm@lists.linux.dev, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 23/60] mm/damon: restrict DAMON-native folio operations to common memory Message-ID: References: <20261120-private_nodes_v6-v1-0-74f5f9a115c2@gourry.net> <20261120-private_nodes_v6-v1-23-74f5f9a115c2@gourry.net> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261120-private_nodes_v6-v1-23-74f5f9a115c2@gourry.net> X-ClientProxiedBy: BN0PR03CA0048.namprd03.prod.outlook.com (2603:10b6:408:e7::23) To LV3PR12MB9356.namprd12.prod.outlook.com (2603:10b6:408:20c::21) X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR12MB9356:EE_|SJ5PPF6D27E3EA3:EE_ X-MS-Office365-Filtering-Correlation-Id: c9d6c601-21aa-49bb-a9ae-08df48b85630 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|7416014|10070799003|4143699003|11063799006|56012099006|18002099003|22082099003|6133799003|10067099003|261021123027099003|261102123227099003|261009223027099003|261021121427099003; X-Microsoft-Antispam-Message-Info: pttyvZrrYA7D4hAdv7PDsflu6Uh6VmXoU3y2OtFAJmFlM8cifYkMj3e7x9ST23KXiCyG1i8STL/Gc/miT2q7nN2BG3UI8qJz+zvGasSaducR77EwZtbjVCR9qW/4c6DillNCrSxYHFW1+amy6DNVWa+1W6mNXl+7iHyWzh4guW0+eu+ifeyFlERU3Vxisg1LiC7SOmNCUYyppvdX7gJZX3/KYSY/N0gGrq9B7U1AopPUjh0mbnwyZL/7w4fjOIQZG7KEMeseEVMQs209jZx34Orl2QUurwoxz1e/qHg/EgHF61TyldoSPEYQTQi2cmYkoN2oqVm9Nz0ZAjTX5Kia5yFwmNXVZPsJ8bKtTsCioBxdHggrUY8HgtHlYDKOEDfjL3s+8O8FU6NrtcLJ/ZjqhRpAEboiL1P+oIDIY/hDVYmXE5nNQ5D6vTm2QSFAMq4xo9ZBG/ZpH7E+n/vkBCYZe7DibUFAPNVJkKiyfssTr4lYNkVa0tMZvDKPUGE+UlYKXdkY5iSAnRglwaYhdB1lsDWtsRD3sva+l+VRS+3kR9xjxV46hLNqI0Pc8RHsX687nR2ebaJv0Q9Uli8xEu1s2Qi8gcp8wqCxu+N7rJhTHGkoo29el+JhMtfcHxk5y4iutfY4LAHnEiA+8Cp8zlXS+1G3ODe6wDtYr7ka2XLHWMs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV3PR12MB9356.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(7416014)(10070799003)(4143699003)(11063799006)(56012099006)(18002099003)(22082099003)(6133799003)(10067099003)(261021123027099003)(261102123227099003)(261009223027099003)(261021121427099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QjdoUo1T00asCqtnXElVzkrVImSL9el03xviw6xq11+EwgfI/I2drFxWr2RT?= =?us-ascii?Q?baxGGcGpWg3kLEBbOftTJ7VpuZSZGCo0sn99NGLO/B2dSdZMohm3zNtOvmTz?= =?us-ascii?Q?G+Kqf9hCW/syX5jqGQL6rHiPCPyQkxpfWhCo/ErzNlHT63i+WKks7Q+ZYd+1?= =?us-ascii?Q?V9sieSpd/4GS7vJuZYWGPaUVCNQK6FvWAouIfh5niJZoFB+ifHR3fvrsnRoq?= =?us-ascii?Q?imqicWxBezT6XL8Y/QLsUeqWDjBk8soHB/dKGyRzuU9eU1B02MbKM2yTlYrd?= =?us-ascii?Q?6yykvfEzHpMdO45UTiTMh28awrN2RYWbwvOlhNS8W8cCR7Ced4pn54w2co+i?= =?us-ascii?Q?9tM6/NK6PDY5LhKec4EZeDrQRHIFn1cp9N7tetif61XLbeSJ9TP57AizrSGA?= =?us-ascii?Q?i5LfpsCE62TrnioYJkjgPk7OxbXMO63dVqQJyfX8tmgYZ+G9GrzBPNJMQao5?= =?us-ascii?Q?NZoQNeVxjcuUl42vU4nfzthMt+sIJV345LYKAjun5z+4af3kKCn9orydLQhg?= =?us-ascii?Q?gZ9Kp3N19Gsw/EWJ9j1n+bnIDI8dz0QB7ch2fd/4Zqvj1BdzPWxQ8SNOcuMJ?= =?us-ascii?Q?beRQoiGDOl2ZPa2n146+P8ghcOPyeT9xSuIBZO9ivwVF4zoTu44XxGNM82mH?= =?us-ascii?Q?U1SjK67jwgFbAoao4SiZC90lMY2mI70n/JNzuZNYtCQitzM6uPf5ZHW7486j?= =?us-ascii?Q?/M2n3CgDVKWfaBbYucBTxBNHZeaXmdePKl5w7wAZCn7FA/YyAMNFM6BP0/RV?= =?us-ascii?Q?6JTNvL//UZzHVU2elYDvNv62Gt5iepMRH21sbygMOVPIcVwTDH+kXuayVugJ?= =?us-ascii?Q?YJ++aifc8xoHje5tyXWliIV1qeZ/cWH/nMHxaEXBH/R82njpCeXHiuS312kW?= =?us-ascii?Q?JUlVEXZbv8ZrQVuUunIx9y8FTfwTMrS3YcH+Xf04UvmTq6qRglN6qlM2a6xt?= =?us-ascii?Q?TaR1KvfCS0xKdt0mgqvmg9sNXiJK9G3RVvPVH0sTm6OITzj7J/tkfoYs8RNw?= =?us-ascii?Q?VeRPcd5dzT7IWifoxTECcVo6R/58PZmGskttf1irgqBPWJDXKlJLu7tYxE5G?= =?us-ascii?Q?xwP4ynlysDFbIa4zFb2EsObzWf1nbIrSkvIOK8b6VZUc4GnaAcFyar/n00mT?= =?us-ascii?Q?tao90rRFiquIK4DX02/A3O8mDCYejx1M/1SS0ZHm+ygnBBzNTlCcdSTAccRv?= =?us-ascii?Q?m4w5nZ0FTbN1Sd/nyCIOnntSwTFdwOKyXIAJ/90/e4fmkR4et3VDMfd1ZJYR?= =?us-ascii?Q?YBfrrgw9yor1KWwH2OZEdzisad0IxDvd1Y/G3h89yIZSUO/leWKW89Ax9Q1o?= =?us-ascii?Q?vhejkCribBnP+ehHs5YWbvRVmQL7oTtqptLiYwHezsDrUm2WsJAGRytGCGN/?= =?us-ascii?Q?AWxsL72oKQ8MD+yOR5+AcXLEJMT5qWAj57V/aSbVuSK095FLfHvgM0/N0pgH?= =?us-ascii?Q?u6bqKwO8TgklAGGU5wwX3kBZEJ3lNlDwfI8KjouzYfI3iy8NFStOo9J3clfc?= =?us-ascii?Q?S1F0UrFyEMepBSc+h0dW/nT/eRtLboGdw4V7cFW6HR89B3MbHT3MJq8R54C9?= =?us-ascii?Q?YkynPk4QhWAL21OiUHB1Bcf172WaJb0PD4pXOPBcEJ5O+T7p0FyZE5QxsIlj?= =?us-ascii?Q?GIqr2Z0iIp2bQz+zKPXzC7oSWc8DuSZyqf/GmLyONgm/OCWukRJzO5fCC+Ij?= =?us-ascii?Q?8b67FI1um10g2xuoTblCPwcBOm1Hr92FXtb+F/MOFPikzPwAyAZ5exLsd3y4?= =?us-ascii?Q?P5utbCJKhbvu777p+E0BOnCiLuHw2kO5mf3H2uisNshlY/BsHMQ+?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9d6c601-21aa-49bb-a9ae-08df48b85630 X-MS-Exchange-CrossTenant-AuthSource: LV3PR12MB9356.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2026 16:47:47.0757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f+1VWZU7dM6sKOJYqHO9c+hsyEoiWzlaDXATHgydhHUhlmlPbaVIckNCrUWY+l99eKJI1Qzvn/kkfDGvS5d4zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPF6D27E3EA3 On Fri, Nov 20, 2026 at 01:09:14PM -0500, Gregory Price via B4 Relay wrote: > From: "Gregory Price (Meta)" > > DAMON acquires folios to age them, check their accesses, and apply LRU > operations and migration. Treat these as general-purpose MM services > and restrict them to N_MEMORY_COMMON. > > Memory outside N_MEMORY_COMMON can still hold ordinary LRU folios, so > it would pass the checks that keep ZONE_DEVICE memory out of these > operations. > > Treat these folios like ZONE_DEVICE memory. > > DAMON cannot acquire such a folio, so it never ages one and virtual > address monitoring reports it as accessed, and DAMOS cannot isolate > one for migration. > > Signed-off-by: Gregory Price (Meta) > --- > mm/damon/ops-common.c | 5 +++-- > mm/damon/vaddr.c | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c > index 15cabc79613b..57201a0c5e3a 100644 > --- a/mm/damon/ops-common.c > +++ b/mm/damon/ops-common.c > @@ -17,8 +17,9 @@ > > static bool damon_folio_acceptable(struct folio *folio, bool monitor) > { > - return folio_test_lru(folio) || > - (monitor && folio_test_hugetlb(folio)); > + return folio_is_common_memory(folio) && > + (folio_test_lru(folio) || > + (monitor && folio_test_hugetlb(folio))); Can you minimize the diff? That would also improve on readability IMO: if (!folio_is_common_memory()) return false; return folio_test_lru(folio) || (monitor && folio_test_hugetlb(folio)); > } > > /* > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 1e65e7651cd9..338876559140 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -830,7 +830,7 @@ static void damos_va_migrate_dests_add(struct folio *folio, > if (folio_nid(folio) == nid) > return; > > - if (!folio_isolate_lru(folio)) > + if (!folio_is_common_memory(folio) || !folio_isolate_lru(folio)) > return; > node_stat_add_folio(folio, NR_ISOLATED_ANON + > folio_is_file_lru(folio)); > > -- > 2.56.1 >