From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [RFC 01/10] drm: Track clients by tgid and not tid Date: Wed, 15 Mar 2023 09:52:20 +0000 Message-ID: References: <20230314141904.1210824-1-tvrtko.ursulin@linux.intel.com> <20230314141904.1210824-2-tvrtko.ursulin@linux.intel.com> <2d4c10c7-6406-7458-4f52-4260b415874e@amd.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678873947; x=1710409947; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=gBg6Vr33FAryjFmPnYb0dmG82k9ImBYRN0MW7OCbJHU=; b=MFuh0nQPeDUWwjbq5zjWg/IEUboL4vL/pzfFypAOYJSMuNa+fz7deuA/ nk1RbD8Z7epAnQ1sSLmOq1Kxuk7cJCYAaE2Oe37KkQ3+mv9Yx5qVfz6FO ylpeEGfcY6kyP0q2JhrlfSTmnLyfAOKRCE5/IRz5C8+8vASWuSLr50SOU ay+HjWdZx33v2u+lEHMndXCHNthwvSgOLhrqfbgPsMrOdUayvOwO9IWSg e6Hn3WmvyvTwJNw5fBT7wTJzjO+XDefpIARIvymliCI0IWfyigRrlSXrX BWaaf4Dk/syjoec6ps1tBgGlpzeW24wbl1J9brkkm3F/mncw34bZeM4WL g==; Content-Language: en-US In-Reply-To: <2d4c10c7-6406-7458-4f52-4260b415874e@amd.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Content-Type: text/plain; charset="utf-8"; format="flowed" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Rob Clark , Kenny.Ho@amd.com, Daniel Vetter , Johannes Weiner , linux-kernel@vger.kernel.org, =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Alex Deucher , linux-graphics-maintainer@vmware.com, Zefan Li , Dave Airlie , Tejun Heo , cgroups@vger.kernel.org, "T . J . Mercier" , Zack Rusin Hi, On 14/03/2023 15:33, Christian König wrote: > Am 14.03.23 um 15:18 schrieb Tvrtko Ursulin: >> From: Tvrtko Ursulin >> >> Thread group id (aka pid from userspace point of view) is a more >> interesting thing to show as an owner of a DRM fd, so track and show that >> instead of the thread id. >> >> In the next patch we will make the owner updated post file descriptor >> handover, which will also be tgid based to avoid ping-pong when multiple >> threads access the fd. >> >> Signed-off-by: Tvrtko Ursulin >> Cc: Zack Rusin >> Cc: linux-graphics-maintainer@vmware.com >> Cc: Alex Deucher >> Cc: "Christian König" >> Reviewed-by: Zack Rusin > > Reviewed-by: Christian König > > Should we push the already reviewed cleanups like this one to > drm-misc-next? That makes sense even without the rest of the > functionality and reduce the amount of patches re-send. I don't have the commit rights so if you could do that I certainly would not mind, thanks! Regards, Tvrtko >> --- >>   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +- >>   drivers/gpu/drm/drm_debugfs.c           | 4 ++-- >>   drivers/gpu/drm/drm_file.c              | 2 +- >>   drivers/gpu/drm/vmwgfx/vmwgfx_gem.c     | 2 +- >>   4 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >> index d8e683688daa..863cb668e000 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c >> @@ -969,7 +969,7 @@ static int amdgpu_debugfs_gem_info_show(struct >> seq_file *m, void *unused) >>            * Therefore, we need to protect this ->comm access using RCU. >>            */ >>           rcu_read_lock(); >> -        task = pid_task(file->pid, PIDTYPE_PID); >> +        task = pid_task(file->pid, PIDTYPE_TGID); >>           seq_printf(m, "pid %8d command %s:\n", pid_nr(file->pid), >>                  task ? task->comm : ""); >>           rcu_read_unlock(); >> diff --git a/drivers/gpu/drm/drm_debugfs.c >> b/drivers/gpu/drm/drm_debugfs.c >> index 4f643a490dc3..4855230ba2c6 100644 >> --- a/drivers/gpu/drm/drm_debugfs.c >> +++ b/drivers/gpu/drm/drm_debugfs.c >> @@ -80,7 +80,7 @@ static int drm_clients_info(struct seq_file *m, void >> *data) >>       seq_printf(m, >>              "%20s %5s %3s master a %5s %10s\n", >>              "command", >> -           "pid", >> +           "tgid", >>              "dev", >>              "uid", >>              "magic"); >> @@ -94,7 +94,7 @@ static int drm_clients_info(struct seq_file *m, void >> *data) >>           bool is_current_master = drm_is_current_master(priv); >>           rcu_read_lock(); /* locks pid_task()->comm */ >> -        task = pid_task(priv->pid, PIDTYPE_PID); >> +        task = pid_task(priv->pid, PIDTYPE_TGID); >>           uid = task ? __task_cred(task)->euid : GLOBAL_ROOT_UID; >>           seq_printf(m, "%20s %5d %3d   %c    %c %5d %10u\n", >>                  task ? task->comm : "", >> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c >> index a51ff8cee049..c1018c470047 100644 >> --- a/drivers/gpu/drm/drm_file.c >> +++ b/drivers/gpu/drm/drm_file.c >> @@ -156,7 +156,7 @@ struct drm_file *drm_file_alloc(struct drm_minor >> *minor) >>       if (!file) >>           return ERR_PTR(-ENOMEM); >> -    file->pid = get_pid(task_pid(current)); >> +    file->pid = get_pid(task_tgid(current)); >>       file->minor = minor; >>       /* for compatibility root is always authenticated */ >> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c >> b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c >> index d6baf73a6458..c0da89e16e6f 100644 >> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c >> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c >> @@ -241,7 +241,7 @@ static int vmw_debugfs_gem_info_show(struct >> seq_file *m, void *unused) >>            * Therefore, we need to protect this ->comm access using RCU. >>            */ >>           rcu_read_lock(); >> -        task = pid_task(file->pid, PIDTYPE_PID); >> +        task = pid_task(file->pid, PIDTYPE_TGID); >>           seq_printf(m, "pid %8d command %s:\n", pid_nr(file->pid), >>                  task ? task->comm : ""); >>           rcu_read_unlock(); >