From: Jens Axboe <axboe@kernel.dk>
To: Khazhy Kumykov <khazhy@chromium.org>, Tejun Heo <tj@kernel.org>
Cc: yukuai@kernel.org, Guenter Roeck <linux@roeck-us.net>,
Josef Bacik <josef@toxicpanda.com>, Yu Kuai <yukuai3@huawei.com>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] block/blk-throttle: Fix throttle slice time for SSDs
Date: Fri, 14 Nov 2025 13:51:46 -0700 [thread overview]
Message-ID: <b9efd5cb-d3cc-48df-8dda-2b3d85e2190b@kernel.dk> (raw)
In-Reply-To: <CACGdZYKFxdF5sv3RY19_ZafgwVSy35E0JmUvL-B95CskHUC2Yw@mail.gmail.com>
On 11/14/25 1:26 PM, Khazhy Kumykov wrote:
> On Wed, Jul 30, 2025 at 4:19 PM Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On 7/30/25 11:30, Yu Kuai wrote:
>> I had combined it because it is another left-over from bf20ab538c81 and
>> I don't know if enabling statistics has other side effects. But, sure,
>> I can split it out if that is preferred. Let's wait for feedback from
>> Jens and/or Tejun; I'll follow their guidance.
>>
>> Thanks,
>> Guenter
>>
> noticed this one in our carry queue... any further guidance here? If
> my opinion counts, since this is a fixup for a "remove feature X"
> commit... I would have done it in one commit as well :)
I agree with Yu that a split of patch 1 would be appropriate.
--
Jens Axboe
next prev parent reply other threads:[~2025-11-14 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 16:48 [PATCH 0/2] block/blk-throttle: Fix throttle slice time for SSDs Guenter Roeck
2025-07-30 16:48 ` [PATCH 1/2] " Guenter Roeck
2025-07-30 18:30 ` Yu Kuai
2025-07-30 23:19 ` Guenter Roeck
2025-11-14 20:26 ` Khazhy Kumykov
2025-11-14 20:51 ` Jens Axboe [this message]
2025-11-15 0:30 ` Guenter Roeck
2025-07-30 16:48 ` [PATCH 2/2] block/blk-throttle: Remove throtl_slice from struct throtl_data Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9efd5cb-d3cc-48df-8dda-2b3d85e2190b@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=khazhy@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tj@kernel.org \
--cc=yukuai3@huawei.com \
--cc=yukuai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox