From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F130F185955; Thu, 18 Dec 2025 09:00:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766048440; cv=none; b=Kz2ODYaqAE6RCEtwWlag64a1z++9i0XI0V69kg8sKdo9RsKMu/hgLO5KGfGJI274CJoHOyPdIFc8g4vvdnHaLI+C9lHjdzIdWexqM1eGIXfPt3yC4mU1KRn2YgJ7c/+exCsGDBV90sicg09ayaV96MGU2JsXy3sIAmkdVyOac/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766048440; c=relaxed/simple; bh=/0/rtcS385uWstxYx5vQaAZ1klTP2bjSTEEUQbZkcz8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X1swbuQysAalajGlRiEq0PSLtUUJb566KM2E0bNXJf7MlrNUHKzdiT4QAF47FUG2XByyO1Qhc0ljKSimMSyJ8PMRftkcWGutv7aKmcr+w+x1to4pJId1ZKjmbtUpmpkMnFak5db06hdFNBGCsEIhyr4kZDfCgXyHJ+WmTnGVof4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jEpxZX6W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jEpxZX6W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C743C4CEFB; Thu, 18 Dec 2025 09:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766048439; bh=/0/rtcS385uWstxYx5vQaAZ1klTP2bjSTEEUQbZkcz8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jEpxZX6WcT4c7dWdMrJJZpdtGqPgJ8kMu4eIg1pFdkUP+oikEB4UsfBdrDdRQ2WGq eBwrStNELBsyZOLBGrYdgsazW4zjFXww8ESHIe53dWMjSRMRWXLUtSvdIgRhaKcKve CWFO/IKhnR1dsTN9uYixAyq9l6iegYeCC9xYw6eK6WsG31Dmr7rqY5NMoOB4Wahsn+ 7/4RZGYWhk2BTmp5762UMBy/r8xGPpGwHT/MH/mztp7G7HzQi5cbBaZe4wFhAuunxX bkES8QgTQQsL8V80bh9TZPh//h3rlTDHcF8zQn/Dhpy8FowhtYr2Cfr63FCUtqTr5j 5cH3r6C2E0XQQ== Message-ID: Date: Thu, 18 Dec 2025 10:00:31 +0100 Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/28] mm: rename unlock_page_lruvec_irq and its variants To: Qi Zheng , hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Muchun Song , Qi Zheng , Chen Ridong References: From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/17/25 08:27, Qi Zheng wrote: > From: Muchun Song > > It is inappropriate to use folio_lruvec_lock() variants in conjunction > with unlock_page_lruvec() variants, as this involves the inconsistent > operation of locking a folio while unlocking a page. To rectify this, the > functions unlock_page_lruvec{_irq, _irqrestore} are renamed to > lruvec_unlock{_irq,_irqrestore}. > > Signed-off-by: Muchun Song > Acked-by: Roman Gushchin > Acked-by: Johannes Weiner > Signed-off-by: Qi Zheng > Reviewed-by: Harry Yoo > Reviewed-by: Chen Ridong > --- Nice cleanup Acked-by: David Hildenbrand (Red Hat) -- Cheers David