From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 960086AA9 for ; Tue, 31 Oct 2023 04:29:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="rcWlELTG" X-Greylist: delayed 438 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 30 Oct 2023 21:29:31 PDT Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1E9EA9 for ; Mon, 30 Oct 2023 21:29:31 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698726129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J2j0WaIECOCx3ysweLloarEOoDOwe2IXjXCAwGdhdn4=; b=rcWlELTGuOZqavXYaXQZKlyNY7Tl5Q49aKhVuN5OTLW+v/dlRz1+X8dmAvKMaFWnXGcolh HDF0Tt2XDv6NOol6uOQ7rnvIcFtiPkyrGMDjd+r9c3ybM69WaCevf0yxO+FM6D7VOK4M/2 6h5lF4lnaD6VT4DNAqXUiRAd+TPYkeA= Date: Tue, 31 Oct 2023 00:22:04 -0400 Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 bpf-next 06/11] bpf: Add a new kfunc for cgroup1 hierarchy Content-Language: en-US To: Yafang Shao , Jiri Olsa , David Vernet Cc: Dave Marchevsky , kernel test robot , ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, yosryahmed@google.com, mkoutny@suse.com, sinquersw@gmail.com, longman@redhat.com, oe-kbuild-all@lists.linux.dev, cgroups@vger.kernel.org, bpf@vger.kernel.org, oliver.sang@intel.com References: <20231029061438.4215-7-laoar.shao@gmail.com> <202310301605.CGFI0aSW-lkp@intel.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: David Marchevsky In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 10/30/23 10:40 PM, Yafang Shao wrote: > On Mon, Oct 30, 2023 at 9:59 PM Jiri Olsa wrote: >> >> On Mon, Oct 30, 2023 at 07:35:25PM +0800, Yafang Shao wrote: >>> On Mon, Oct 30, 2023 at 5:01 PM kernel test robot wrote: >>>> >>>> Hi Yafang, >>>> >>>> kernel test robot noticed the following build warnings: >>>> >>>> [auto build test WARNING on bpf-next/master] >>>> >>>> url: https://github.com/intel-lab-lkp/linux/commits/Yafang-Shao/cgroup-Remove-unnecessary-list_empty/20231029-143457 >>>> base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master >>>> patch link: https://lore.kernel.org/r/20231029061438.4215-7-laoar.shao%40gmail.com >>>> patch subject: [PATCH v3 bpf-next 06/11] bpf: Add a new kfunc for cgroup1 hierarchy >>>> config: i386-randconfig-013-20231030 (https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/20231030/202310301605.CGFI0aSW-lkp@intel.com/config__;!!Bt8RZUm9aw!4feH_paRfc92c6DKnIgcbDciELDAOzSoIr66fN3591gkU9ddriq2cqyFm47OezGzvLvXd5Ep4R9ZYmtxrW9dqg$ ) >>>> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 >>>> reproduce (this is a W=1 build): (https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/20231030/202310301605.CGFI0aSW-lkp@intel.com/reproduce__;!!Bt8RZUm9aw!4feH_paRfc92c6DKnIgcbDciELDAOzSoIr66fN3591gkU9ddriq2cqyFm47OezGzvLvXd5Ep4R9ZYmsRR5GsUA$ ) >>>> >>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>>> the same patch/commit), kindly add following tags >>>> | Reported-by: kernel test robot >>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202310301605.CGFI0aSW-lkp@intel.com/ >>>> >>>> All warnings (new ones prefixed by >>): >>>> >>>> kernel/bpf/helpers.c:1893:19: warning: no previous declaration for 'bpf_obj_new_impl' [-Wmissing-declarations] >>> >>> -Wmissing-declarations is a known issue and somebody is working on it, right? >> >> there's this post [1] from Dave, but seems it never landed >> >> jirka >> >> [1] https://lore.kernel.org/bpf/20230816150634.1162838-1-void@manifault.com/ > > Thanks for your information. > > David, I'd appreciate it if you could share an update on its current status > Hi Yafang, I had a similar patch in a recent series that I was asked to split out and submit separately. Did so today after seeing this thread: https://lore.kernel.org/bpf/20231030210638.2415306-1-davemarchevsky@fb.com/ Sorry, should've CC'd you as well as Jiri on that patch.