From: Waiman Long <longman@redhat.com>
To: "Tejun Heo" <tj@kernel.org>, "Michal Koutný" <mkoutny@suse.com>
Cc: Chen Ridong <chenridong@huawei.com>,
lizefan.x@bytedance.com, hannes@cmpxchg.org,
adityakali@google.com, sergeh@kernel.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] cgroup/cpuset: Prevent UAF in proc_cpuset_show()
Date: Thu, 27 Jun 2024 14:37:35 -0400 [thread overview]
Message-ID: <c12f62fb-7cdc-476f-b6d2-deff2570d7df@redhat.com> (raw)
In-Reply-To: <Zn2vjVNnIcUN8lXM@slm.duckdns.org>
On 6/27/24 14:29, Tejun Heo wrote:
> Hello,
>
> On Thu, Jun 27, 2024 at 11:46:10AM +0200, Michal Koutný wrote:
>> Your patch should work thanks to the rcu_read_lock and
>> cgroup_free_root/kfree_rcu and the `if (css->cgroup)` guard is
>> unnecessary.
I also notice that the if (css->cgroup) guard is not needed. I didn't
reject it because it doesn't hurt.
Cheers,
Longman
>>
>> So the patch is a functional fix, the reasoning in commit message is
>> little off. Not sure if Tejun rebases his for-6.10-fixes (with a
>> possible v4), full fixup commit for this may not be worthy.
> This one's on the top. If Chen can send me a patch with updated description,
> I will replace the patch.
>
> Thanks.
>
prev parent reply other threads:[~2024-06-27 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 9:41 [PATCH V3] cgroup/cpuset: Prevent UAF in proc_cpuset_show() Chen Ridong
2024-06-26 14:56 ` Waiman Long
2024-06-26 21:20 ` Tejun Heo
2024-06-27 9:46 ` Michal Koutný
2024-06-27 18:29 ` Tejun Heo
2024-06-27 18:37 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c12f62fb-7cdc-476f-b6d2-deff2570d7df@redhat.com \
--to=longman@redhat.com \
--cc=adityakali@google.com \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=sergeh@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox