From: Joseph Qi <jiangqi903-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wenqing.lz-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org,
boyu.mt-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org,
qijiang.qj-gPhfCIXyaqCqndwCJWfcng@public.gmane.org
Subject: Re: [PATCH] blk-cgroup: fix wrong unlock order when parse per blkg config
Date: Tue, 2 May 2017 08:41:48 +0800 [thread overview]
Message-ID: <c39a752d-034e-02a0-3c46-892e42c6616a@gmail.com> (raw)
In-Reply-To: <20170428212233.GE22354-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
Fine, I will explain so and resend it later.
Thanks,
Joseph
On 17/4/29 05:22, Tejun Heo wrote:
> Hello,
>
> On Mon, Apr 24, 2017 at 06:52:05PM +0800, Joseph Qi wrote:
>> From: Joseph Qi <qijiang.qj-gPhfCIXyaqCqndwCJWfcng@public.gmane.org>
>>
>> In case of error blkg in blkg_conf_prep, we should unlock
>> queue->queue_lock first and then rcu, just like blkg_conf_finish.
>
> I get that this is inconsistent but why is this wrong? If this is for
> consistency, can you please explain so in the commit so that people
> don't confuse it for an actual bug fix?
>
> Thanks.
>
next prev parent reply other threads:[~2017-05-02 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 10:52 [PATCH] blk-cgroup: fix wrong unlock order when parse per blkg config Joseph Qi
[not found] ` <be8d9709-84fe-d2df-f294-a12701675e27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-28 21:22 ` Tejun Heo
[not found] ` <20170428212233.GE22354-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2017-05-02 0:41 ` Joseph Qi [this message]
[not found] ` <c39a752d-034e-02a0-3c46-892e42c6616a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-02 1:10 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c39a752d-034e-02a0-3c46-892e42c6616a@gmail.com \
--to=jiangqi903-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=boyu.mt-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=qijiang.qj-gPhfCIXyaqCqndwCJWfcng@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wenqing.lz-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).