From: Lance Yang <lance.yang@linux.dev>
To: hannes@cmpxchg.org
Cc: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org,
shakeel.butt@linux.dev, mhocko@kernel.org, david@fromorbit.com,
roman.gushchin@linux.dev, muchun.song@linux.dev,
qi.zheng@linux.dev, yosry.ahmed@linux.dev, ziy@nvidia.com,
liam@infradead.org, usama.arif@linux.dev, kas@kernel.org,
vbabka@kernel.org, ryncsn@gmail.com, zaslonko@linux.ibm.com,
gor@linux.ibm.com, baolin.wang@linux.alibaba.com,
baohua@kernel.org, dev.jain@arm.com, npache@redhat.com,
ryan.roberts@arm.com, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 9/9] mm: switch deferred split shrinker to list_lru
Date: Mon, 1 Jun 2026 19:09:34 +0800 [thread overview]
Message-ID: <c9cf7afb-1c92-4915-b311-305c7ac48739@linux.dev> (raw)
In-Reply-To: <20260601103947.63923-1-lance.yang@linux.dev>
On 2026/6/1 18:39, Lance Yang wrote:
>
> On Wed, May 27, 2026 at 04:45:16PM -0400, Johannes Weiner wrote:
> [...]
>> diff --git a/mm/memory.c b/mm/memory.c
>> index 135f5c0f57bd..f22e61d8c8de 100644
>> --- a/mm/memory.c
>> +++ b/mm/memory.c
>> @@ -5222,6 +5222,10 @@ static struct folio *alloc_anon_folio(struct vm_fault *vmf)
>> folio_put(folio);
>> goto next;
>> }
>> + if (order > 1 && folio_memcg_alloc_deferred(folio)) {
>> + folio_put(folio);
>
> Missing a MTHP_STAT_ANON_FAULT_FALLBACK bump here?
>
> Since we jump straight to fallback and end up at order-0 :)
Sorry for the noise, I missed the earlier discussion. Never mind this
one, please.
>
>> + goto fallback;
>> + }
>> folio_throttle_swaprate(folio, gfp);
>> /*
>> * When a folio is not zeroed during allocation
> [...]
>
> Cheers, Lance
next prev parent reply other threads:[~2026-06-01 11:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 20:45 [PATCH v5 0/9] mm: switch THP shrinker to list_lru Johannes Weiner
2026-05-27 20:45 ` [PATCH v5 1/9] mm: list_lru: fix set_shrinker_bit() call during race with cgroup deletion Johannes Weiner
2026-05-28 13:25 ` Usama Arif
2026-05-30 2:38 ` Wei Yang
2026-05-27 20:45 ` [PATCH v5 2/9] mm: list_lru: lock_list_lru_of_memcg() cannot return NULL if !skip_empty Johannes Weiner
2026-05-27 20:45 ` [PATCH v5 3/9] mm: list_lru: deduplicate unlock_list_lru() Johannes Weiner
2026-05-27 20:45 ` [PATCH v5 4/9] mm: list_lru: move list dead check to lock_list_lru_of_memcg() Johannes Weiner
2026-05-27 20:45 ` [PATCH v5 5/9] mm: list_lru: deduplicate lock_list_lru() Johannes Weiner
2026-05-29 9:56 ` Wei Yang
2026-05-29 13:42 ` Johannes Weiner
2026-05-30 1:25 ` Wei Yang
2026-05-27 20:45 ` [PATCH v5 6/9] mm: list_lru: introduce caller locking for additions and deletions Johannes Weiner
2026-05-27 20:45 ` [PATCH v5 7/9] mm: list_lru: introduce folio_memcg_list_lru_alloc() Johannes Weiner
2026-05-27 20:45 ` [PATCH v5 8/9] mm: memory: flatten alloc_anon_folio() retry loop Johannes Weiner
2026-05-30 9:06 ` Dev Jain
2026-05-27 20:45 ` [PATCH v5 9/9] mm: switch deferred split shrinker to list_lru Johannes Weiner
2026-05-28 7:08 ` SeongJae Park
2026-05-28 14:03 ` Johannes Weiner
2026-05-28 13:32 ` Usama Arif
2026-05-28 14:02 ` Johannes Weiner
2026-05-28 15:31 ` Usama Arif
2026-05-29 17:33 ` Kairui Song
2026-05-31 8:00 ` Wei Yang
2026-06-01 10:39 ` Lance Yang
2026-06-01 11:09 ` Lance Yang [this message]
2026-06-01 13:21 ` Lance Yang
2026-06-01 8:36 ` [PATCH v5 0/9] mm: switch THP " Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9cf7afb-1c92-4915-b311-305c7ac48739@linux.dev \
--to=lance.yang@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=cgroups@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=gor@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kas@kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=npache@redhat.com \
--cc=qi.zheng@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=ryncsn@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=yosry.ahmed@linux.dev \
--cc=zaslonko@linux.ibm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox