From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: Chengming Zhou
<zhouchengming-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: paolo.valente-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 0/3] blk-cgroup: some cleanup
Date: Fri, 7 Apr 2023 11:41:41 -0700 [thread overview]
Message-ID: <cab869b1-1cba-5698-55eb-a93d0596c869@acm.org> (raw)
In-Reply-To: <20230406145050.49914-1-zhouchengming-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
On 4/6/23 07:50, Chengming Zhou wrote:
> These are some cleanup patches of blk-cgroup. Thanks for review.
With these patches applied, my kernel test VM crashes during boot. The
following crash disappears if I revert these patches:
BUG: KASAN: null-ptr-deref in bio_associate_blkg_from_css+0x83/0x240
Read of size 8 at addr 0000000000000518 by task blkid/5885
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS
1.16.0-debian-1.16.0-5 04/01/2014
Call Trace:
dump_stack_lvl+0x4a/0x80
print_report+0x21e/0x260
kasan_report+0xc2/0xf0
__asan_load8+0x69/0x90
bio_associate_blkg_from_css+0x83/0x240
bfq_bio_bfqg+0xce/0x120 [bfq]
bfq_bic_update_cgroup+0x2f/0x3c0 [bfq]
bfq_init_rq+0x1e8/0xb10 [bfq]
bfq_insert_request.isra.0+0xa3/0x420 [bfq]
bfq_insert_requests+0xca/0xf0 [bfq]
blk_mq_dispatch_rq_list+0x4c0/0xb00
__blk_mq_sched_dispatch_requests+0x15e/0x200
blk_mq_sched_dispatch_requests+0x8b/0xc0
__blk_mq_run_hw_queue+0x3ff/0x500
__blk_mq_delay_run_hw_queue+0x23a/0x300
blk_mq_run_hw_queue+0x14e/0x350
blk_mq_sched_insert_request+0x181/0x1f0
blk_execute_rq+0xf4/0x300
scsi_execute_cmd+0x23e/0x350
sr_do_ioctl+0x173/0x3d0 [sr_mod]
sr_packet+0x60/0x90 [sr_mod]
cdrom_get_track_info.constprop.0+0x125/0x170 [cdrom]
cdrom_get_last_written+0x1d4/0x2d0 [cdrom]
mmc_ioctl_cdrom_last_written+0x85/0x120 [cdrom]
mmc_ioctl+0x10b/0x1d0 [cdrom]
cdrom_ioctl+0xa66/0x1270 [cdrom]
sr_block_ioctl+0xee/0x130 [sr_mod]
blkdev_ioctl+0x1bb/0x3f0
__x64_sys_ioctl+0xc7/0xe0
do_syscall_64+0x34/0x80
entry_SYSCALL_64_after_hwframe+0x46/0xb0
Bart.
next prev parent reply other threads:[~2023-04-07 18:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 14:50 [PATCH v2 0/3] blk-cgroup: some cleanup Chengming Zhou
2023-04-06 14:50 ` [PATCH v2 1/3] block, bfq: remove BFQ_WEIGHT_LEGACY_DFL Chengming Zhou
2023-04-06 14:50 ` [PATCH v2 2/3] blk-cgroup: delete cpd_bind_fn of blkcg_policy Chengming Zhou
2023-04-06 14:50 ` [PATCH v2 3/3] blk-cgroup: delete cpd_init_fn " Chengming Zhou
[not found] ` <20230406145050.49914-1-zhouchengming-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
2023-04-06 22:17 ` [PATCH v2 0/3] blk-cgroup: some cleanup Jens Axboe
2023-04-07 18:41 ` Bart Van Assche [this message]
[not found] ` <cab869b1-1cba-5698-55eb-a93d0596c869-HInyCGIudOg@public.gmane.org>
2023-04-07 18:44 ` Jens Axboe
2023-04-07 19:45 ` Bart Van Assche
2023-04-08 3:37 ` [External] " Chengming Zhou
2023-04-08 14:31 ` Chengming Zhou
2023-04-10 1:57 ` Yu Kuai
[not found] ` <d23a6891-96f0-2ee0-70c7-869123d85362-XF6JlduFytWkHkcT6e4Xnw@public.gmane.org>
2023-04-10 18:47 ` Bart Van Assche
[not found] ` <8651fa1f-7f50-03c6-cd85-e61aa44d4927-HInyCGIudOg@public.gmane.org>
2023-04-10 22:20 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cab869b1-1cba-5698-55eb-a93d0596c869@acm.org \
--to=bvanassche-hinycgiudog@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=josef-DigfWCa+lFGyeJad7bwFQA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=paolo.valente-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=zhouchengming-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox