From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.56 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794394315; b=EBXm3c19rDZ8+nom+cQhaK7ppjVX8kV3ol7Pw0A6ZtebU7NAC5codSTA0WhiYF+OHj49 vTo1/qqkh+psqMs58v6uawqI4O3zAWvmKCR+ADIvtSJOOYeCmtW9Hfel6jtEm/7kgVSAH 1HHRc4m5Up8wmq7w55hNbuQQF2WDTt5ICKl1kIwNBgI2fpSU6v//Lu6/T6IQhgrZVDUrx Wi+kJ5u2GJjCKWqfy3dzIM+jmW90LrFz+JfP8wMSRpfrICs+j3ATFHOFEQ4COGt6KXhN9 Qu638g4MkMzVmeQkIPhpKlzXW/xPhPD0cMjALHR0koZUo66uViVRQuw7XBVABqj2qUA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794394315; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=5AVpUvbziS4tLtkl71xz9vkUGVuY/mbFEqqFLF/VE2U=; b=eaZlDkl+rd0L2vsayZ9WzW+CTL7h1Ng5JGl02zpUyPPN5gw+ygakXgg6n7npcSagxTTP yTqEje2CGkOY9SiEY2frIPl5SaANmOlFCtm1sSXjNEt6arsW/FmIQJmloerADXqIC+m4w m2ZcmcpXFZ1lCS93Y9pOJ9isrFaUb1pztIzC9B/s6tcCGRQp7CgYukwhyHPJr/rCd3Eg4 AGX4pEXVvi/9atN5M1UYIiiUF3aK7OkjFJ80K30P6gxvfFYT0uWY1/AC8gYJ4YbKf+llW 5ziwJg4DAQmVvurTOsQaGetgxZXQ7MZOKOkOUKFtSRP23Sg0xLn902F6cN7+O/8Coag== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=aKLbtLzK; arc=none smtp.remote-ip=91.218.175.56 Received: from mta0.migadu.com (out-56.mta0.migadu.com [91.218.175.56]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFF8C606A33F for ; Wed, 11 Nov 2026 10:51:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org AFF8C606A33F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=aKLbtLzK X-Envelope-To: cgroups@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=w8Ajrj08Qy2iipL85FFRK03LHNYTUCHQy59AnCWVRj4=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794394312; v=1; x=1794999112; b=aKLbtLzKuV1HlEwkwP3ApoFgaPivMXLvlSHlz+a/wlESPJMeSXG7C7Run9+sJhiMMDSxhBa0 yGsuK6bZBJXePZ1mZammjvcXu76ySG3FNVcGBlPL1o+PRxlLIck38iZ8p7AMgDJLS+cgGh4j5IB LN8Io8Dy3V5aCv6UwV/nRALU= X-Envelope-To: cgroups@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id f93127dded52155e; Wed, 11 Nov 2026 10:51:52 +0000 X-Mizu-Trace-ID: f93127dded52155e X-Migadu-Flow: FLOW_OUT Message-ID: Date: Wed, 11 Nov 2026 18:51:47 +0800 X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] cgroup/cpuset: Reject updates that empty the top sched domain To: Ridong Chen , Waiman Long , Tejun Heo Cc: Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Shuah Khan , Mathieu Desnoyers , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Guopeng Zhang References: <20261110050324.173461-1-guopeng.zhang@linux.dev> <20261110050324.173461-2-guopeng.zhang@linux.dev> <0c302879-0d06-4c90-970d-6c9b40946f0f@linux.dev> Content-Language: en-US From: Guopeng Zhang In-Reply-To: <0c302879-0d06-4c90-970d-6c9b40946f0f@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 在 2026/11/10 20:13, Ridong Chen 写道: > > > On 11/10/2026 1:03 PM, Guopeng Zhang wrote: >> From: Guopeng Zhang >> >> Boot-isolated CPUs remain in top_cpuset.effective_cpus, but are excluded >> from its scheduling domain by generate_sched_domains(). Checking only >> effective_cpus when distributing CPUs to partitions can therefore allow >> all boot domain housekeeping CPUs to be taken from the top cpuset. >> >> The resulting empty domain triggers a warning in build_sched_domains() >> and can cause an out-of-bounds CPU access in build_perf_domains(). Both >> root and isolated partitions can trigger this, whether local or remote. >> For example, on a 32-CPU system booted with isolcpus=domain,10-31: >> >>    echo 0-9 > A/cpuset.cpus >>    echo root > A/cpuset.cpus.partition >>    Oops: general protection fault >>    RIP: 0010:build_perf_domains+... >> >> Require local and remote partition creation and CPU mask updates to >> leave an active boot domain housekeeping CPU in the top cpuset, >> accounting for CPUs returned by the same update. >> >> Add test cases to test_cpuset_prs.sh to verify that every partition >> update leaves an active boot domain housekeeping CPU in the top cpuset. >> >> Fixes: 9b496a8bbed9 ("cgroup/cpuset: Prevent leakage of isolated CPUs into sched domains") >> Co-developed-by: Ridong Chen >> Signed-off-by: Ridong Chen > > It would be better with: Ridong Chen > Yeah, I'll update it. Thanks， Guopeng