Linux cgroups development
 help / color / mirror / Atom feed
From: Tao Cui <cui.tao@linux.dev>
To: Tejun Heo <tj@kernel.org>
Cc: cui.tao@linux.dev, josef@toxicopanda.com, axboe@kernel.dk,
	cgroups@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	andrii@kernel.org, eddyz87@gmail.com, ast@kernel.org,
	daniel@iogearbox.net, linux-kselftest@vger.kernel.org,
	cuitao@kylinos.cn, ameryhung@gmail.com,
	alexei.starovoitov@gmail.com
Subject: Re: [PATCH 5/5] docs: cgroup-v2: document the iocost BPF cost model attachment
Date: Thu, 29 Oct 2026 18:33:09 +0800	[thread overview]
Message-ID: <ce3ede81-f70b-4324-9fa4-21cf716e1e33@linux.dev> (raw)
In-Reply-To: <72deb196d0dfc413a48f0739013bc610@kernel.org>

Hello Tejun,

在 2026/10/29 04:09, Tejun Heo 写道:
> Hello, Tao.
> 
> On Wed, Oct 28, 2026 at 10:35:34PM +0800, Tao Cui wrote:
>> +	When CONFIG_BLK_CGROUP_IOCOST_BPF is enabled, a BPF cost
>> +	model can be bound to a device by attaching an
> 
> Users can't select CONFIG_BLK_CGROUP_IOCOST_BPF.
> 
The sentence now reads "When BPF cost model support is available".

>> +	Only detaching removes the model, after which "model=bpf"
>> +	fails and the device prices with the builtin model again.
>> +	Device removal ejects the attached model as well, while the
>> +	struct_ops link remains until userspace destroys it.  "ctrl"
> 
> "Only detaching removes the model" is followed by "Device removal ejects
> the attached model as well".
> 
Dropped "Only".

>> +	accepts only "auto" and "user" and never selects a model.  It
>> +	keeps describing the builtin coefficients, which take effect
>> +	again when switched back.  The automatic profile stepping does
>> +	not switch profiles while the BPF model is in use; as with
>> +	user-set parameters, the profile selected from the device
>> +	class still applies.
> 
> cgroup-v2.rst doesn't describe automatic profile stepping anywhere else.
> 
Those sentences are removed.
>> +	defined.  They remain readable and writable while "model" is
>> +	"bpf" but take effect only after switching back to "linear".
> 
> The builtin coefficients taking effect again after switching back is
> already said above.
> 
Removed.

Thanks,
Tao

> Thanks.
> 
> --
> tejun


  reply	other threads:[~2026-10-29 10:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 14:35 [RFC PATCH v11 0/5] blk-iocost: BPF struct_ops cost model Tao Cui
2026-10-28 14:35 ` [PATCH 1/5] blk-iocost: move shared definitions to blk-iocost.h Tao Cui
2026-10-28 20:09   ` Tejun Heo
2026-10-29 10:04     ` Tao Cui
2026-10-28 14:35 ` [PATCH 2/5] blk-iocost: add BPF struct_ops cost model support Tao Cui
2026-10-28 15:33   ` bot+bpf-ci
2026-10-28 20:09   ` Tejun Heo
2026-10-29 10:11     ` Tao Cui
2026-10-28 14:35 ` [PATCH 3/5] selftests/bpf: add iocost cost model test Tao Cui
2026-10-28 15:33   ` bot+bpf-ci
2026-10-28 20:09   ` Tejun Heo
2026-10-29 10:30     ` Tao Cui
2026-10-28 14:35 ` [PATCH 4/5] blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary Tao Cui
2026-10-28 20:09   ` Tejun Heo
2026-10-29 10:31     ` Tao Cui
2026-10-28 14:35 ` [PATCH 5/5] docs: cgroup-v2: document the iocost BPF cost model attachment Tao Cui
2026-10-28 20:09   ` Tejun Heo
2026-10-29 10:33     ` Tao Cui [this message]
2026-10-28 15:58 ` [RFC PATCH v11 0/5] blk-iocost: BPF struct_ops cost model Alexei Starovoitov
2026-10-28 20:09   ` Tejun Heo
2026-10-29  9:55   ` Tao Cui
2026-10-28 20:09 ` Tejun Heo
2026-10-29  9:57   ` Tao Cui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce3ede81-f70b-4324-9fa4-21cf716e1e33@linux.dev \
    --to=cui.tao@linux.dev \
    --cc=alexei.starovoitov@gmail.com \
    --cc=ameryhung@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bpf@vger.kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=cuitao@kylinos.cn \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=josef@toxicopanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox