Re: [PATCH -mm 00/14] Per memcg slab shrinkers

Tejun Heo
2014-09-21T16:00:12Z

Hello,

On Sun, Sep 21, 2014 at 07:14:32PM +0400, Vladimir Davydov wrote:
...
> list. This is really important, because this allows us to release
> memcg_cache_id used for indexing in per-memcg arrays. If we don't do
> this, the arrays will grow uncontrollably, which is really bad. Note, in
> comparison to user memory reparenting, which Johannes is going to get

I don't know the code well and haven't read the patches and could
easilya be completely off the mark, but, if the size of slab array is
the only issue, wouldn't it be easier to separate that part out? The
indexing is only necessary for allocating new items, right? Can't
that part be shutdown and the index freed on offline and the rest stay
till release? Things like reparenting tends to add fair amount of
complexity and hot path overheads which aren't necessary otherwise.

Thanks.

--
tejun