From: Baolin Wang <baolin.wang-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Cc: torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
sj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org,
shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
muchun.song-fxUVXftIFDnyG1zEObXtfA@public.gmane.org,
naoya.horiguchi-YMj9X0ASwKA@public.gmane.org,
linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
osalvador-l3A5Bk7waGM@public.gmane.org,
mike.kravetz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
baolin.wang-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org,
damon-cunTk1MwBs/YUNznpcFYbw@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v3 0/4] Change the return value for page isolation functions
Date: Wed, 15 Feb 2023 18:39:33 +0800 [thread overview]
Message-ID: <cover.1676424378.git.baolin.wang@linux.alibaba.com> (raw)
Now the page isolation functions did not return a boolean to indicate
success or not, instead it will return a negative error when failed
to isolate a page. So below code used in most places seem a boolean
success/failure thing, which can confuse people whether the isolation
is successful.
if (folio_isolate_lru(folio))
continue;
Moreover the page isolation functions only return 0 or -EBUSY, and
most users did not care about the negative error except for few users,
thus we can convert all page isolation functions to return a boolean
value, which can remove the confusion to make code more clear.
No functional changes intended in this patch series.
Changes from v2:
- Add a new boolean 'isolated' variable for functions that require the
negative error value.
- Keep the same return value logic in do_migrate_range(), that means it
will return -EBUSY if all pages are failed to be isolated.
- Collect Acked-by and Reviewed-by tags. Thanks David and SeongJae.
Changes from v1:
- Convert all isolation functions to return bool.
Baolin Wang (4):
mm: change to return bool for folio_isolate_lru()
mm: change to return bool for isolate_lru_page()
mm: hugetlb: change to return bool for isolate_hugetlb()
mm: change to return bool for isolate_movable_page()
include/linux/hugetlb.h | 6 +++---
include/linux/migrate.h | 6 +++---
mm/compaction.c | 2 +-
mm/damon/paddr.c | 2 +-
mm/folio-compat.c | 4 ++--
mm/gup.c | 2 +-
mm/hugetlb.c | 13 ++++++++-----
mm/internal.h | 4 ++--
mm/khugepaged.c | 4 ++--
mm/madvise.c | 4 ++--
mm/memcontrol.c | 4 ++--
mm/memory-failure.c | 10 +++++-----
mm/memory_hotplug.c | 8 +++++---
mm/mempolicy.c | 4 ++--
mm/migrate.c | 20 +++++++++++---------
mm/migrate_device.c | 2 +-
mm/vmscan.c | 10 +++++-----
17 files changed, 56 insertions(+), 49 deletions(-)
--
2.27.0
next reply other threads:[~2023-02-15 10:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 10:39 Baolin Wang [this message]
[not found] ` <cover.1676424378.git.baolin.wang-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2023-02-15 10:39 ` [PATCH v3 1/4] mm: change to return bool for folio_isolate_lru() Baolin Wang
[not found] ` <8a4e3679ed4196168efadf7ea36c038f2f7d5aa9.1676424378.git.baolin.wang-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2023-02-15 15:35 ` Matthew Wilcox
2023-02-15 10:39 ` [PATCH v3 2/4] mm: change to return bool for isolate_lru_page() Baolin Wang
[not found] ` <3074c1ab628d9dbf139b33f248a8bc253a3f95f0.1676424378.git.baolin.wang-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2023-02-15 15:39 ` Matthew Wilcox
2023-02-15 10:39 ` [PATCH v3 3/4] mm: hugetlb: change to return bool for isolate_hugetlb() Baolin Wang
[not found] ` <12a287c5bebc13df304387087bbecc6421510849.1676424378.git.baolin.wang-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2023-02-15 15:41 ` Matthew Wilcox
2023-02-15 19:22 ` Mike Kravetz
2023-02-15 20:25 ` SeongJae Park
[not found] ` <20230215202548.92462-1-sj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-02-16 2:04 ` Baolin Wang
2023-02-15 10:39 ` [PATCH v3 4/4] mm: change to return bool for isolate_movable_page() Baolin Wang
[not found] ` <cb877f73f4fff8d309611082ec740a7065b1ade0.1676424378.git.baolin.wang-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2023-02-15 15:44 ` Matthew Wilcox
[not found] ` <Y+z91pcxAuygc92J-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2023-02-16 2:07 ` Baolin Wang
2023-02-16 22:46 ` Andrew Morton
2023-02-15 20:14 ` [PATCH v3 0/4] Change the return value for page isolation functions Linus Torvalds
2023-02-15 20:26 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1676424378.git.baolin.wang@linux.alibaba.com \
--to=baolin.wang-kpsofbns7gizrge5brqyagc/g2k4zdhf@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=damon-cunTk1MwBs/YUNznpcFYbw@public.gmane.org \
--cc=david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mike.kravetz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=muchun.song-fxUVXftIFDnyG1zEObXtfA@public.gmane.org \
--cc=naoya.horiguchi-YMj9X0ASwKA@public.gmane.org \
--cc=osalvador-l3A5Bk7waGM@public.gmane.org \
--cc=roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org \
--cc=shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=sj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox