cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: gaoxu <gaoxu2@honor.com>
To: "Kamalesh Babulal" <kamalesh.babulal@oracle.com>,
	"Tejun Heo" <tj@kernel.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>
Cc: "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"surenb@google.com" <surenb@google.com>,
	yipengxiang <yipengxiang@honor.com>
Subject: 回复: [PATCH v2] cgroup: Fix compilation issue due to cgroup_mutex not being exported
Date: Sun, 20 Apr 2025 00:49:32 +0000	[thread overview]
Message-ID: <d181a0a4e1bf42f69d9b1a26fc5dc8ea@honor.com> (raw)
In-Reply-To: <af289b54-de43-4d7c-bf74-926abfad7808@oracle.com>

> 
> Hi,
> 
> On 4/18/25 8:12 AM, gaoxu wrote:
> 
> [...]
> > diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index
> > 447ac857e..c1bc51058 100644
> > --- a/kernel/cgroup/cgroup.c
> > +++ b/kernel/cgroup/cgroup.c
> > @@ -84,13 +84,13 @@
> >   * css_set_lock protects task->cgroups pointer, the list of css_set
> >   * objects, and the chain of tasks off each css_set.
> >   *
> > - * These locks are exported if CONFIG_PROVE_RCU so that accessors in
> > - * cgroup.h can use them for lockdep annotations.
> > + * These locks are exported if CONFIG_PROVE_RCU or CONFIG_LOCKDEP so
> > + that
> > + * accessors in cgroup.h can use them for lockdep annotations.
> >   */
> 
> Tejun has already merged the initial version of the patch without the updated
> description. You may want to send the description change as a separate patch,
> rebased on top of the cgroup/for-next branch.
> 
> I've rephrased the description to clarify that lockdep annotations can occur even
> without CONFIG_PROVE_RCU. Feel free to use this version or modify it further:
> "Export locks for lockdep annotations. Use CONFIG_PROVE_RCU for accessors in
> cgroup.h, and CONFIG_LOCKDEP for accessors that do not require
> CONFIG_PROVE_RCU."
Received, thanks!
> 
> --
> Cheers,
> Kamalesh


      reply	other threads:[~2025-04-20  0:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18  2:42 [PATCH v2] cgroup: Fix compilation issue due to cgroup_mutex not being exported gaoxu
2025-04-18  7:47 ` Kamalesh Babulal
2025-04-20  0:49   ` gaoxu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d181a0a4e1bf42f69d9b1a26fc5dc8ea@honor.com \
    --to=gaoxu2@honor.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kamalesh.babulal@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    --cc=yipengxiang@honor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).