Re: [PATCH v2] cgroup/rdma: refactor resource parsing with match_table_t/match_token()

Tejun Heo
2026-04-21T16:42:35Z

Hello,

A few things for a respin:

- Can you use your real name in the Signed-off-by? Something like
"Firstname Lastname <email>" rather than the account handle.

- The patch also drops this comment in rdmacg_resource_set_max():

/*
* No user of the rpool and all entries are set to max, so
* safe to delete this rpool.
*/

That's unrelated to the parser refactor. Please keep it, or split
it out as a separate cleanup patch.

- The old strncmp(value, RDMACG_MAX_STR, strlen(value)) also silently
accepted "hca_handle=" (empty value) as "max" because strncmp with
n=0 always returns 0. v2 fixes this too - worth mentioning in the
changelog alongside the "ma" case.

Thanks.

--
tejun