From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ardelean, Alexandru" Subject: Re: [PATCH 09/16] mmc: sdhci-xenon: use new match_string() helper/macro Date: Fri, 10 May 2019 11:04:53 +0000 Message-ID: References: <20190508112842.11654-1-alexandru.ardelean@analog.com> <20190508112842.11654-11-alexandru.ardelean@analog.com> <20190508122010.GC21059@kadam> <2ec6812d6bf2f33860c7c816c641167a31eb2ed6.camel@analog.com> <31be52eb1a1abbc99a24729f5c65619235cb201f.camel@analog.com> <20190510110116.GB18105@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.onmicrosoft.com; s=selector1-analog-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nVlpM+6hUpJfEDjmqqh5buswTi9IXWo+idp+3aYvadA=; b=cJaRCIlXlhytsC0WOUjovdUXlHRExZWPjhVf03F0+kh9EW3mb68RI6Rnc3cHyEhKGz4sJV9wA82vpcEx/F+iU3ypyrnsW4/k0e997VS2hIGKO+igCU4zzHHlAx2b/kf5RKAjaKA2W3b6tkRnBRfNgWUAFNGQGOnAYoLiEYdp3VE= In-Reply-To: <20190510110116.GB18105@kadam> Content-Language: en-US Content-ID: <134D0B85CEA25646B3EBD898406EC02C@analog.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: "dan.carpenter@oracle.com" Cc: "linux-wireless@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-pci@vger.kernel.org" , "alsa-devel@alsa-project.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-mtd@lists.infradead.org" , "linux-clk@vger.kernel.org" , "devel@driverdev.osuosl.org" , "andriy.shevchenko@linux.intel.com" , "linux-rockchip@lists.infradead.org" , "linux-pm@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , linux-gpio@vger.kernel.or On Fri, 2019-05-10 at 14:01 +0300, Dan Carpenter wrote: > [External] > > > On Fri, May 10, 2019 at 09:13:26AM +0000, Ardelean, Alexandru wrote: > > On Wed, 2019-05-08 at 16:26 +0300, Alexandru Ardelean wrote: > > > On Wed, 2019-05-08 at 15:20 +0300, Dan Carpenter wrote: > > > > > > > > > > > > On Wed, May 08, 2019 at 02:28:35PM +0300, Alexandru Ardelean wrote: > > > > > -static const char * const phy_types[] = { > > > > > - "emmc 5.0 phy", > > > > > - "emmc 5.1 phy" > > > > > -}; > > > > > - > > > > > enum xenon_phy_type_enum { > > > > > EMMC_5_0_PHY, > > > > > EMMC_5_1_PHY, > > > > > NR_PHY_TYPES > > > > > > > > There is no need for NR_PHY_TYPES now so you could remove that as > > > > well. > > > > > > > > > > I thought the same. > > > The only reason to keep NR_PHY_TYPES, is for potential future > > > patches, > > > where it would be just 1 addition > > > > > > enum xenon_phy_type_enum { > > > EMMC_5_0_PHY, > > > EMMC_5_1_PHY, > > > + EMMC_5_2_PHY, > > > NR_PHY_TYPES > > > } > > > > > > Depending on style/preference of how to do enums (allow comma on last > > > enum > > > or not allow comma on last enum value), adding new enum values woudl > > > be 2 > > > additions + 1 deletion lines. > > > > > > enum xenon_phy_type_enum { > > > EMMC_5_0_PHY, > > > - EMMC_5_1_PHY > > > + EMM > > > C_5_1_PHY, > > > + EMMC_5_2_PHY > > > } > > > > > > Either way (leave NR_PHY_TYPES or remove NR_PHY_TYPES) is fine from > > > my > > > side. > > > > > > > Preference on this ? > > If no objection [nobody insists] I would keep. > > > > I don't feel strongly about it [dropping NR_PHY_TYPES or not]. > > If you end up resending the series could you remove it, but if not then > it's not worth it. ack thanks Alex > > regards, > dan carpenter >