From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 955EF279338 for ; Tue, 29 Apr 2025 09:40:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745919627; cv=none; b=fWusWkYk2JrJ97i+C0P7x+ipUQTnR/hfQvbozzuHQHfk2y984ff1f8VeN7bAqjp7ssbMgvsAAlnVcET2EtfdR4IqvokKX3mOiv6bxpC+1UptoeP+O4qAi2CsdgbFkE5Z1IvAZV91nFSKZtvc4FIo2pN8oHRBQKNZptE5DQJ5/SQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745919627; c=relaxed/simple; bh=VEClPpvelOykPpRU7PP7F/S3ulnhMGLUZV/2Au4tLs8=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=NryCN/NokKLQq2KPIMwWdtrhgToG6NVam5gCorHb7aLdKrx23sT/zx7HXr5VJN4uZ33zP74DzO9CUHxsAlcOvQajcgwIT6Siidkb8n2CYZFo/5kgP8L5gQ7OIdHOkQPiPxeoYcltUAtb5oQtKhJIprRNk9monVm0UTdgs6Kfp3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Rvo2mRiX; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Rvo2mRiX" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2260c91576aso48284845ad.3 for ; Tue, 29 Apr 2025 02:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745919625; x=1746524425; darn=vger.kernel.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=887j+HuJAg3GAFJi8re61kxKscTlK+O7RQ0PqOMN3wo=; b=Rvo2mRiX50wj6MiH7GVu1/4JUDxZ5AaIKK6tXbKTL+zC98IAU9sbGWLOMKTVS7bh+V C2cVA+1wg+RPu9DlCnhf1GbS7LUbopgmbZ8wycFTmQlYG5+JWne8AIi2Plin1vRKPDbs aEbPNNTQc1/tAORHZ/MMFXujNu1/lHh+AgDDT13BT2lNHbSS3mU3fMG4ImpDeySRN6bZ 6MFGjMeQohT8Xt/HV2mq4gBULlW6MCtISMBbFeHg83Fzj4c7D5b46fZgCYG9rRusS4ar tURDpRrqCFcVmEQ8hK9AdrTX2ZyF92nAIhjhZ3WKke2oMORKvNk1qAdSjWxBbauf/fmX 2GjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745919625; x=1746524425; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=887j+HuJAg3GAFJi8re61kxKscTlK+O7RQ0PqOMN3wo=; b=cF5FIpwutYON7crGx+HJqb+dntl+DRu5SOEEW8u1NEZs/PPI/kA9eEiIk1JMxSVPNQ FRDD7t7fJatlOFE1xDIPSz0F8QN4yK11pt7YBqx+KaJfiIaNv3OU1lMp/lOQuV7kdxZG plgeZMkQ9pD1hIgs1klNZHYZxMTSwZocbqC/L0f0sayimoYMioJjveHzpwq4qsEXInH1 OabVnCsHIz0rW2nNzzje1UoeHizpEcZ2doveZflarO5ZdG8hzToMk6Ol5Iirraers1kL 80BE5ow0aQ+fMLGeGkkYTjuwYOBldq4XFm1JHawlDUmbPJ7rMzHEOAgCY++y0FYWcdGl sQxg== X-Forwarded-Encrypted: i=1; AJvYcCX+KHZyb0kG0bP+8YSI9twssvr1ZV3aDCJY52ks6m40E9ZqTkQGBwjBY7Nq4awyY3WOBxmYPz7i@vger.kernel.org X-Gm-Message-State: AOJu0YzxD7ztAJo30fd+ESxrvXiar8cbB0YFA3o3nPR3LqVBHGzrVhU8 2bV+FlqUdPWPKaN3MHqcll2SsJGpuM3b+VToBj8rdcXUwBjMYoFxjeks6MNRPQ== X-Gm-Gg: ASbGncv7PjFSsJt7laDcm3jPXmj38WaXMId1LowNYkLX6e6iIXmjdgsUekd4TjQbw/Z aS09MzVKz43Q/Xzvr5yTPiiojxMIF/5Eq7F8Ra+4fVXK/JZseusQXI4jQirwdIJjU3lBBEo33Da cdONU5BMs2rXpYSAarLRro+Z3XHnbskkMFmBKzeynqPPDU/VZUQ+DnKPNs5zo54YTV2PJ8yXdRu RY3psvPxsVn6Ph1qSQ0Eir/ZCRPUnMYxITfP+eHkkxiWa8q3pZI9p3cdkOL6GZZ7C0baRzvHJq9 yJxiGdEP6gO20KFO8Rnwh0Pb9A1xecVLr49ijIHIAymKORmvq/KvLpbHz/A9KNTSSnmcDiMb8Rj ZLEE64wZNhprsVG6dAjdym1nI X-Google-Smtp-Source: AGHT+IGJzRx+E9AYOKH3V9G8U9AElamVc69ogYXshkqnP91KceEEIHQZBBI1Oddf93pxjy3KZrE5dQ== X-Received: by 2002:a17:903:2bce:b0:223:4c09:20b8 with SMTP id d9443c01a7336-22dc6a6c91emr166079865ad.37.1745919624658; Tue, 29 Apr 2025 02:40:24 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db50e7cf2sm98181285ad.154.2025.04.29.02.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 02:40:23 -0700 (PDT) Date: Tue, 29 Apr 2025 02:40:07 -0700 (PDT) From: Hugh Dickins To: Andrew Morton , Shakeel Butt cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Jakub Kicinski , Eric Dumazet , Soheil Hassas Yeganeh , linux-mm@kvack.org, cgroups@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] memcg: multi-memcg percpu charge cache In-Reply-To: Message-ID: References: <20250416180229.2902751-1-shakeel.butt@linux.dev> Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII [PATCH mm-unstable] memcg: multi-memcg percpu charge cache - fix 3 Fix 2 has been giving me lots of memcg OOM kills not seen before: it's better to stock nr_pages than the uninitialized stock_pages. Signed-off-by: Hugh Dickins --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 178d79e68107..02c6f553dc53 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1952,7 +1952,7 @@ static void refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages) } css_get(&memcg->css); WRITE_ONCE(stock->cached[i], memcg); - WRITE_ONCE(stock->nr_pages[i], stock_pages); + WRITE_ONCE(stock->nr_pages[i], nr_pages); } local_unlock_irqrestore(&memcg_stock.stock_lock, flags);