From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-193.mta0.migadu.com [91.218.175.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 244393AE706 for ; Sun, 20 Sep 2026 03:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789874801; cv=none; b=gS546auNDmRKDslFu2Kp/BrDYoO0iullFsBe5yaZGfWwsoneLKx310rSW7nN3AEHeJZl0yLsPkoPj6MxdPj4ZLIJh4JTS7BHmuWfHOkwCk+5PSQlqqOQvfoZK7GoQYZMAGldlla9W9MK41djk4sRtqwCpZ8H6xBiEfZnDKBFcJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789874801; c=relaxed/simple; bh=lUMIprFigeo+4Lvd3zU+aZwPLnWWNiV1VTYdTyJmw5k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r1RC9bbRWmCvkEkWo9prjyKWe7H9zhpmgCfTcxpC5llJze1krjKgorsCGlp/bzA+hNYw9zkiBw5UbJYlZ+QkNnIPtvJA2c2uq7CdfsebO6TINj9HU3gSNh3a/cq5BB019lzoReEK6z+MXkeC+fRmZgRRcteq0MtHlXgaq/huO0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=OHRQP1Rw; arc=none smtp.client-ip=91.218.175.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="OHRQP1Rw" X-Envelope-To: cgroups@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=lUMIprFigeo+4Lvd3zU+aZwPLnWWNiV1VTYdTyJmw5k=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789874797; v=1; x=1790479597; b=OHRQP1RwusFNvUZkR8V2C1iVw6VjJm95Sta0bpFTmf67vVCpZy425r7YCtTsbn2juMVNoOKl cybXc++f949qHKzDKBFZ0XHIKr6N0iSIvGUr5xAjsThB8pPRs+kULh70OCDi6VXaIGn/0GFjtGa ntWEQHV7GH/VlNCSfJbOv4tM= X-Envelope-To: cgroups@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 30785122cacebbc4; Sun, 20 Sep 2026 03:26:37 +0000 X-Mizu-Trace-ID: 30785122cacebbc4 X-Migadu-Flow: FLOW_OUT Message-ID: Date: Sun, 20 Sep 2026 11:26:33 +0800 Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cgroup/cpuset: Defer sched domain rebuild to common unlock path To: Guopeng Zhang , Waiman Long Cc: Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Guopeng Zhang References: <20260918102730.72263-1-guopeng.zhang@linux.dev> From: Ridong Chen In-Reply-To: <20260918102730.72263-1-guopeng.zhang@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/18/2026 6:27 PM, Guopeng Zhang wrote: > From: Guopeng Zhang > > Both callers of update_prstate(), cpuset_partition_write() and > cpuset_css_killed(), call cpuset_update_sd_hk_unlock() immediately > afterwards. That helper rebuilds sched domains when force_sd_rebuild is > set before releasing the cpuset locks, so the check in update_prstate() > is redundant. > > Commit 3bfe47967191 ("cgroup/cpuset: Move > housekeeping_update()/rebuild_sched_domains() together") removed the > same check from cpuset_write_resmask(). Remove the remaining one from > update_prstate(). > > Signed-off-by: Guopeng Zhang > --- > kernel/cgroup/cpuset.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 8f24171..d58ecf5 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -3039,8 +3039,6 @@ out: > update_partition_sd_lb(cs, old_prs); > > notify_partition_change(cs, old_prs); > - if (force_sd_rebuild) > - rebuild_sched_domains_locked(); > free_tmpmasks(&tmpmask); > return 0; > } Reviewed-by: Ridong Chen Thanks. -- Best regards Ridong