From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [RFC PATCH v2 5/5] drm, cgroup: Add peak GEM buffer allocation limit Date: Fri, 10 May 2019 14:29:29 +0200 Message-ID: References: <20181120185814.13362-1-Kenny.Ho@amd.com> <20190509210410.5471-1-Kenny.Ho@amd.com> <20190509210410.5471-6-Kenny.Ho@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190509210410.5471-6-Kenny.Ho-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Kenny Ho , y2kenny-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, sunnanyong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, alexander.deucher-5C7GfCeVMHo@public.gmane.org, brian.welty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org QW0gMDkuMDUuMTkgdW0gMjM6MDQgc2NocmllYiBLZW5ueSBIbzoKPiBUaGlzIG5ldyBkcm1jZ3Jw IHJlc291cmNlIGxpbWl0cyB0aGUgbGFyZ2VzdCBHRU0gYnVmZmVyIHRoYXQgY2FuIGJlCj4gYWxs b2NhdGVkIGluIGEgY2dyb3VwLgo+Cj4gQ2hhbmdlLUlkOiBJMDgzMGQ1Njc3NTU2OGUxY2YyMTVi NTZjYzg5MmQ1ZTc5NDVlOWYyNQo+IFNpZ25lZC1vZmYtYnk6IEtlbm55IEhvIDxLZW5ueS5Ib0Bh bWQuY29tPgo+IC0tLQo+ICAgaW5jbHVkZS9saW51eC9jZ3JvdXBfZHJtLmggfCAgMiArKwo+ICAg a2VybmVsL2Nncm91cC9kcm0uYyAgICAgICAgfCA1OSArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKwo+ICAgMiBmaWxlcyBjaGFuZ2VkLCA2MSBpbnNlcnRpb25zKCspCj4KPiBk aWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9jZ3JvdXBfZHJtLmggYi9pbmNsdWRlL2xpbnV4L2Nn cm91cF9kcm0uaAo+IGluZGV4IGZlMTRiYTdiYjFjZi4uNTdjMDdhMTQ4OTc1IDEwMDY0NAo+IC0t LSBhL2luY2x1ZGUvbGludXgvY2dyb3VwX2RybS5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9jZ3Jv dXBfZHJtLmgKPiBAQCAtMTYsOCArMTYsMTAgQEAKPiAgIHN0cnVjdCBkcm1jZ3JwX2RldmljZV9y ZXNvdXJjZSB7Cj4gICAJLyogZm9yIHBlciBkZXZpY2Ugc3RhdHMgKi8KPiAgIAlzNjQJCQlib19z dGF0c190b3RhbF9hbGxvY2F0ZWQ7Cj4gKwlzaXplX3QJCQlib19zdGF0c19wZWFrX2FsbG9jYXRl ZDsKPiAgIAo+ICAgCXM2NAkJCWJvX2xpbWl0c190b3RhbF9hbGxvY2F0ZWQ7Cj4gKwlzaXplX3QJ CQlib19saW1pdHNfcGVha19hbGxvY2F0ZWQ7CgpXaHkgczY0IGZvciB0aGUgdG90YWwgbGltaXQg YW5kIHNpemVfdCBmb3IgdGhlIHBlYWsgYWxsb2NhdGlvbj8KCkNocmlzdGlhbi4KCj4gICB9Owo+ ICAgCj4gICBzdHJ1Y3QgZHJtY2dycCB7Cj4gZGlmZiAtLWdpdCBhL2tlcm5lbC9jZ3JvdXAvZHJt LmMgYi9rZXJuZWwvY2dyb3VwL2RybS5jCj4gaW5kZXggYmMzYWJmZjA5MTEzLi41YzdlMWI4MDU5 Y2UgMTAwNjQ0Cj4gLS0tIGEva2VybmVsL2Nncm91cC9kcm0uYwo+ICsrKyBiL2tlcm5lbC9jZ3Jv dXAvZHJtLmMKPiBAQCAtMTcsNiArMTcsNyBAQCBzdHJ1Y3QgZHJtY2dycF9kZXZpY2Ugewo+ICAg CXN0cnVjdCBtdXRleAkJbXV0ZXg7Cj4gICAKPiAgIAlzNjQJCQlib19saW1pdHNfdG90YWxfYWxs b2NhdGVkX2RlZmF1bHQ7Cj4gKwlzaXplX3QJCQlib19saW1pdHNfcGVha19hbGxvY2F0ZWRfZGVm YXVsdDsKPiAgIH07Cj4gICAKPiAgICNkZWZpbmUgRFJNQ0dfQ1RGX1BSSVZfU0laRSAzCj4gQEAg LTI0LDYgKzI1LDcgQEAgc3RydWN0IGRybWNncnBfZGV2aWNlIHsKPiAgIAo+ICAgZW51bSBkcm1j Z3JwX3Jlc190eXBlIHsKPiAgIAlEUk1DR1JQX1RZUEVfQk9fVE9UQUwsCj4gKwlEUk1DR1JQX1RZ UEVfQk9fUEVBSywKPiAgIH07Cj4gICAKPiAgIGVudW0gZHJtY2dycF9maWxlX3R5cGUgewo+IEBA IC03Miw2ICs3NCw5IEBAIHN0YXRpYyBpbmxpbmUgaW50IGluaXRfZHJtY2dycF9zaW5nbGUoc3Ry dWN0IGRybWNncnAgKmRybWNncnAsIGludCBpKQo+ICAgCWlmIChrbm93bl9kcm1jZ3JwX2RldnNb aV0gIT0gTlVMTCkgewo+ICAgCQlkZHItPmJvX2xpbWl0c190b3RhbF9hbGxvY2F0ZWQgPQo+ICAg CQkgIGtub3duX2RybWNncnBfZGV2c1tpXS0+Ym9fbGltaXRzX3RvdGFsX2FsbG9jYXRlZF9kZWZh dWx0Owo+ICsKPiArCQlkZHItPmJvX2xpbWl0c19wZWFrX2FsbG9jYXRlZCA9Cj4gKwkJICBrbm93 bl9kcm1jZ3JwX2RldnNbaV0tPmJvX2xpbWl0c19wZWFrX2FsbG9jYXRlZF9kZWZhdWx0Owo+ICAg CX0KPiAgIAo+ICAgCXJldHVybiAwOwo+IEBAIC0xMzEsNiArMTM2LDkgQEAgc3RhdGljIGlubGlu ZSB2b2lkIGRybWNncnBfcHJpbnRfc3RhdHMoc3RydWN0IGRybWNncnBfZGV2aWNlX3Jlc291cmNl ICpkZHIsCj4gICAJY2FzZSBEUk1DR1JQX1RZUEVfQk9fVE9UQUw6Cj4gICAJCXNlcV9wcmludGYo c2YsICIlbGxkXG4iLCBkZHItPmJvX3N0YXRzX3RvdGFsX2FsbG9jYXRlZCk7Cj4gICAJCWJyZWFr Owo+ICsJY2FzZSBEUk1DR1JQX1RZUEVfQk9fUEVBSzoKPiArCQlzZXFfcHJpbnRmKHNmLCAiJXp1 XG4iLCBkZHItPmJvX3N0YXRzX3BlYWtfYWxsb2NhdGVkKTsKPiArCQlicmVhazsKPiAgIAlkZWZh dWx0Ogo+ICAgCQlzZXFfcHV0cyhzZiwgIlxuIik7Cj4gICAJCWJyZWFrOwo+IEBAIC0xNDksNiAr MTU3LDkgQEAgc3RhdGljIGlubGluZSB2b2lkIGRybWNncnBfcHJpbnRfbGltaXRzKHN0cnVjdCBk cm1jZ3JwX2RldmljZV9yZXNvdXJjZSAqZGRyLAo+ICAgCWNhc2UgRFJNQ0dSUF9UWVBFX0JPX1RP VEFMOgo+ICAgCQlzZXFfcHJpbnRmKHNmLCAiJWxsZFxuIiwgZGRyLT5ib19saW1pdHNfdG90YWxf YWxsb2NhdGVkKTsKPiAgIAkJYnJlYWs7Cj4gKwljYXNlIERSTUNHUlBfVFlQRV9CT19QRUFLOgo+ ICsJCXNlcV9wcmludGYoc2YsICIlenVcbiIsIGRkci0+Ym9fbGltaXRzX3BlYWtfYWxsb2NhdGVk KTsKPiArCQlicmVhazsKPiAgIAlkZWZhdWx0Ogo+ICAgCQlzZXFfcHV0cyhzZiwgIlxuIik7Cj4g ICAJCWJyZWFrOwo+IEBAIC0xNjcsNiArMTc4LDkgQEAgc3RhdGljIGlubGluZSB2b2lkIGRybWNn cnBfcHJpbnRfZGVmYXVsdChzdHJ1Y3QgZHJtY2dycF9kZXZpY2UgKmRkZXYsCj4gICAJY2FzZSBE Uk1DR1JQX1RZUEVfQk9fVE9UQUw6Cj4gICAJCXNlcV9wcmludGYoc2YsICIlbGxkXG4iLCBkZGV2 LT5ib19saW1pdHNfdG90YWxfYWxsb2NhdGVkX2RlZmF1bHQpOwo+ICAgCQlicmVhazsKPiArCWNh c2UgRFJNQ0dSUF9UWVBFX0JPX1BFQUs6Cj4gKwkJc2VxX3ByaW50ZihzZiwgIiV6dVxuIiwgZGRl di0+Ym9fbGltaXRzX3BlYWtfYWxsb2NhdGVkX2RlZmF1bHQpOwo+ICsJCWJyZWFrOwo+ICAgCWRl ZmF1bHQ6Cj4gICAJCXNlcV9wdXRzKHNmLCAiXG4iKTsKPiAgIAkJYnJlYWs7Cj4gQEAgLTE4Miw2 ICsxOTYsMTEgQEAgc3RhdGljIGlubGluZSB2b2lkIGRybWNncnBfcHJpbnRfaGVscChpbnQgY2Fy ZE51bSwgc3RydWN0IHNlcV9maWxlICpzZiwKPiAgIAkJIlRvdGFsIGFtb3VudCBvZiBidWZmZXIg YWxsb2NhdGlvbiBpbiBieXRlcyBmb3IgY2FyZCVkXG4iLAo+ICAgCQljYXJkTnVtKTsKPiAgIAkJ YnJlYWs7Cj4gKwljYXNlIERSTUNHUlBfVFlQRV9CT19QRUFLOgo+ICsJCXNlcV9wcmludGYoc2Ys Cj4gKwkJIkxhcmdlc3QgYnVmZmVyIGFsbG9jYXRpb24gaW4gYnl0ZXMgZm9yIGNhcmQlZFxuIiwK PiArCQljYXJkTnVtKTsKPiArCQlicmVhazsKPiAgIAlkZWZhdWx0Ogo+ICAgCQlzZXFfcHV0cyhz ZiwgIlxuIik7Cj4gICAJCWJyZWFrOwo+IEBAIC0yNTQsNiArMjczLDEwIEBAIHNzaXplX3QgZHJt Y2dycF9ib19saW1pdF93cml0ZShzdHJ1Y3Qga2VybmZzX29wZW5fZmlsZSAqb2YsIGNoYXIgKmJ1 ZiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKHZhbCA8IDApIGNvbnRp bnVlOwo+ICAgCQkJCWRkci0+Ym9fbGltaXRzX3RvdGFsX2FsbG9jYXRlZCA9IHZhbDsKPiAgIAkJ CQlicmVhazsKPiArCQkJY2FzZSBEUk1DR1JQX1RZUEVfQk9fUEVBSzoKPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpZiAodmFsIDwgMCkgY29udGludWU7Cj4gKwkJCQlkZHItPmJv X2xpbWl0c19wZWFrX2FsbG9jYXRlZCA9IHZhbDsKPiArCQkJCWJyZWFrOwo+ICAgCQkJZGVmYXVs dDoKPiAgIAkJCQlicmVhazsKPiAgIAkJCX0KPiBAQCAtMzAwLDYgKzMyMywzMyBAQCBzdHJ1Y3Qg Y2Z0eXBlIGZpbGVzW10gPSB7Cj4gICAJCS5wcml2YXRlID0gKERSTUNHUlBfVFlQRV9CT19UT1RB TCA8PCBEUk1DR19DVEZfUFJJVl9TSVpFKSB8Cj4gICAJCQlEUk1DR1JQX0ZUWVBFX01BWCwKPiAg IAl9LAo+ICsJewo+ICsJCS5uYW1lID0gImJ1ZmZlci5wZWFrLnN0YXRzIiwKPiArCQkuc2VxX3No b3cgPSBkcm1jZ3JwX2JvX3Nob3csCj4gKwkJLnByaXZhdGUgPSAoRFJNQ0dSUF9UWVBFX0JPX1BF QUsgPDwgRFJNQ0dfQ1RGX1BSSVZfU0laRSkgfAo+ICsJCQlEUk1DR1JQX0ZUWVBFX1NUQVRTLAo+ ICsJfSwKPiArCXsKPiArCQkubmFtZSA9ICJidWZmZXIucGVhay5kZWZhdWx0IiwKPiArCQkuc2Vx X3Nob3cgPSBkcm1jZ3JwX2JvX3Nob3csCj4gKwkJLmZsYWdzID0gQ0ZUWVBFX09OTFlfT05fUk9P VCwKPiArCQkucHJpdmF0ZSA9IChEUk1DR1JQX1RZUEVfQk9fUEVBSyA8PCBEUk1DR19DVEZfUFJJ Vl9TSVpFKSB8Cj4gKwkJCURSTUNHUlBfRlRZUEVfREVGQVVMVCwKPiArCX0sCj4gKwl7Cj4gKwkJ Lm5hbWUgPSAiYnVmZmVyLnBlYWsuaGVscCIsCj4gKwkJLnNlcV9zaG93ID0gZHJtY2dycF9ib19z aG93LAo+ICsJCS5mbGFncyA9IENGVFlQRV9PTkxZX09OX1JPT1QsCj4gKwkJLnByaXZhdGUgPSAo RFJNQ0dSUF9UWVBFX0JPX1BFQUsgPDwgRFJNQ0dfQ1RGX1BSSVZfU0laRSkgfAo+ICsJCQlEUk1D R1JQX0ZUWVBFX0hFTFAsCj4gKwl9LAo+ICsJewo+ICsJCS5uYW1lID0gImJ1ZmZlci5wZWFrLm1h eCIsCj4gKwkJLndyaXRlID0gZHJtY2dycF9ib19saW1pdF93cml0ZSwKPiArCQkuc2VxX3Nob3cg PSBkcm1jZ3JwX2JvX3Nob3csCj4gKwkJLnByaXZhdGUgPSAoRFJNQ0dSUF9UWVBFX0JPX1BFQUsg PDwgRFJNQ0dfQ1RGX1BSSVZfU0laRSkgfAo+ICsJCQlEUk1DR1JQX0ZUWVBFX01BWCwKPiArCX0s Cj4gICAJeyB9CS8qIHRlcm1pbmF0ZSAqLwo+ICAgfTsKPiAgIAo+IEBAIC0zMjMsNiArMzczLDcg QEAgaW50IGRybWNncnBfcmVnaXN0ZXJfZGV2aWNlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4g ICAKPiAgIAlkZGV2LT5kZXYgPSBkZXY7Cj4gICAJZGRldi0+Ym9fbGltaXRzX3RvdGFsX2FsbG9j YXRlZF9kZWZhdWx0ID0gUzY0X01BWDsKPiArCWRkZXYtPmJvX2xpbWl0c19wZWFrX2FsbG9jYXRl ZF9kZWZhdWx0ID0gU0laRV9NQVg7Cj4gICAKPiAgIAltdXRleF9pbml0KCZkZGV2LT5tdXRleCk7 Cj4gICAKPiBAQCAtMzkzLDYgKzQ0NCwxMSBAQCBib29sIGRybWNncnBfYm9fY2FuX2FsbG9jYXRl KHN0cnVjdCB0YXNrX3N0cnVjdCAqdGFzaywgc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgIAkJ CXJlc3VsdCA9IGZhbHNlOwo+ICAgCQkJYnJlYWs7Cj4gICAJCX0KPiArCj4gKwkJaWYgKGQtPmJv X2xpbWl0c19wZWFrX2FsbG9jYXRlZCA8IHNpemUpIHsKPiArCQkJcmVzdWx0ID0gZmFsc2U7Cj4g KwkJCWJyZWFrOwo+ICsJCX0KPiAgIAl9Cj4gICAJbXV0ZXhfdW5sb2NrKCZrbm93bl9kcm1jZ3Jw X2RldnNbZGV2SWR4XS0+bXV0ZXgpOwo+ICAgCj4gQEAgLTQxNCw2ICs0NzAsOSBAQCB2b2lkIGRy bWNncnBfY2hnX2JvX2FsbG9jKHN0cnVjdCBkcm1jZ3JwICpkcm1jZ3JwLCBzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LAo+ICAgCQlkZHIgPSBkcm1jZ3JwLT5kZXZfcmVzb3VyY2VzW2RldklkeF07Cj4g ICAKPiAgIAkJZGRyLT5ib19zdGF0c190b3RhbF9hbGxvY2F0ZWQgKz0gKHM2NClzaXplOwo+ICsK PiArCQlpZiAoZGRyLT5ib19zdGF0c19wZWFrX2FsbG9jYXRlZCA8IChzaXplX3Qpc2l6ZSkKPiAr CQkJZGRyLT5ib19zdGF0c19wZWFrX2FsbG9jYXRlZCA9IChzaXplX3Qpc2l6ZTsKPiAgIAl9Cj4g ICAJbXV0ZXhfdW5sb2NrKCZrbm93bl9kcm1jZ3JwX2RldnNbZGV2SWR4XS0+bXV0ZXgpOwo+ICAg fQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdm eCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4