From: JP Kobryn <inwardvessel@gmail.com>
To: "Shakeel Butt" <shakeel.butt@linux.dev>,
"Michal Koutný" <mkoutny@suse.com>
Cc: syzbot <syzbot+8d052e8b99e40bc625ed@syzkaller.appspotmail.com>,
cgroups@vger.kernel.org, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
tj@kernel.org
Subject: Re: [syzbot] [cgroups?] WARNING in css_rstat_exit
Date: Mon, 21 Jul 2025 17:29:01 -0700 [thread overview]
Message-ID: <e938953c-8735-4276-8f45-543ade5cc515@gmail.com> (raw)
In-Reply-To: <uenvth6s5pfulsz36nxfgg7s2nfi4wm5334edyogiicq4x54mg@kh7keqfyrihh>
Thanks Michal and Shakeel for the input on this. I will be sending out a
series to harden css_create(). I was able to open a small window for the
placement of css_rstat_init() that satisfies existing constraints and
allows for error handling before refcounts come into play.
On 7/17/25 11:46 AM, Shakeel Butt wrote:
> On Thu, Jul 17, 2025 at 03:28:27PM +0200, Michal Koutný wrote:
>> Thanks for looking into this JP.
>> You seem to tracked down the cause with uncleaned rstat, beware that the
>> approach in the patch would leave reference imbalance after
>> init_and_link_css() though.
>
> Yeah I discussed the same with JP and I think JP is planning to move the
> css_rstat_init() before init_and_link_css() and a second param to
> css_rstat_init() to differentiate between css_is_self() or not.
prev parent reply other threads:[~2025-07-22 0:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 16:55 [syzbot] [cgroups?] WARNING in css_rstat_exit syzbot
2025-06-16 9:49 ` Michal Koutný
2025-06-17 4:46 ` JP Kobryn
2025-07-14 7:29 ` syzbot
2025-07-14 23:37 ` JP Kobryn
2025-07-14 23:39 ` syzbot
2025-07-14 23:58 ` JP Kobryn
2025-07-15 0:00 ` syzbot
2025-07-15 1:05 ` JP Kobryn
2025-07-15 1:27 ` syzbot
2025-07-17 13:28 ` Michal Koutný
2025-07-17 18:46 ` Shakeel Butt
2025-07-22 0:29 ` JP Kobryn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e938953c-8735-4276-8f45-543ade5cc515@gmail.com \
--to=inwardvessel@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=shakeel.butt@linux.dev \
--cc=syzbot+8d052e8b99e40bc625ed@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).