Linux cgroups development
 help / color / mirror / Atom feed
From: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
To: "Michal Koutný" <mkoutny@suse.com>, "Waiman Long" <llong@redhat.com>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
	Jonathan Corbet <corbet@lwn.net>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Documentation/cgroup-v2: Update memory.numa_stat description to reflect possible units
Date: Mon, 13 Jan 2025 00:38:55 +0000	[thread overview]
Message-ID: <fb14b1d1-53b9-4f0c-a605-a82f113d2189@fujitsu.com> (raw)
In-Reply-To: <2piu6sz3vkjl3scu6puo45ewu5ffuzv6ikeetgt6rizpswkcec@2uezwhes37io>



On 10/01/2025 23:35, Michal Koutný wrote:
> On Fri, Jan 10, 2025 at 10:26:40AM -0500, Waiman Long <llong@redhat.com> wrote:
>>> -	All memory amounts are in bytes.
>>> +	All memory amounts are in bytes or bytes.
>>
>> You mean "bytes or pages". Right?
> 
> Despite both variant are logically correct, the docs should better say:
> +	All memory amounts are in bytes unless said otherwise.
> (so that it points to respective explainers).

Michal, Longman


Thank you very much for all your feedback; I will make updates based on Michal's suggestion.

Thanks
Zhijian

> 
> HTH,
> Michal

  reply	other threads:[~2025-01-13  0:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 12:30 [PATCH] Documentation/cgroup-v2: Update memory.numa_stat description to reflect possible units Li Zhijian
2025-01-10 15:26 ` Waiman Long
2025-01-10 15:35   ` Michal Koutný
2025-01-13  0:38     ` Zhijian Li (Fujitsu) [this message]
2025-01-13  1:05 ` [PATCH v2] Documentation/cgroup-v2: Update memory.{stat,numa_stat} " Li Zhijian
2025-01-13  8:58   ` Bagas Sanjaya
2025-01-13 17:49   ` Jonathan Corbet
2025-01-16  5:50     ` Zhijian Li (Fujitsu)
2025-01-16 15:12       ` Jonathan Corbet
2025-01-16 17:19       ` Tejun Heo
2025-01-17  3:09         ` Zhijian Li (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb14b1d1-53b9-4f0c-a605-a82f113d2189@fujitsu.com \
    --to=lizhijian@fujitsu.com \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llong@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox