From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Moyer Subject: Re: [PATCH 4/8] cfq-iosched: minor cleanups Date: Mon, 08 Jun 2015 14:59:49 -0400 Message-ID: References: <1433753973-23684-1-git-send-email-tj@kernel.org> <1433753973-23684-5-git-send-email-tj@kernel.org> Mime-Version: 1.0 Return-path: In-Reply-To: <1433753973-23684-5-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> (Tejun Heo's message of "Mon, 8 Jun 2015 17:59:29 +0900") Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, avanzini.arianna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Tejun Heo writes: > * Some were accessing cic->cfqq[] directly. Always use cic_to_cfqq() > and cic_set_cfqq(). > > * check_ioprio_changed() doesn't need to verify cfq_get_queue()'s > return for NULL. It's always non-NULL. Simplify accordingly. > > This patch doesn't cause any functional changes. > > Signed-off-by: Tejun Heo > Cc: Vivek Goyal > Cc: Arianna Avanzini Looks good. I don't much like the "bool is_sync" function parameters. Calls to cic_to_cfqq, cic_set_cfqq, etc would be much easier to read if they took BLK_RW_SYNC and BLK_RW_ASYNC. Certainly not a problem with this patch, though, just a general observation. Reviewed-by: Jeff Moyer