From: "Liang He" <windhl@126.com>
To: "Prashant Malani" <pmalani@chromium.org>
Cc: bleung@chromium.org, groeck@chromium.org,
chrome-platform@lists.linux.dev
Subject: Re:Re: [PATCH] platform/chrome: cros_ec_typec: Add missing fwnode_handle_put()
Date: Wed, 12 Apr 2023 08:26:54 +0800 (CST) [thread overview]
Message-ID: <12078fa5.471.18772dbb80b.Coremail.windhl@126.com> (raw)
In-Reply-To: <CACeCKacsy5tbSFATgtsDYfAJi68ExpbJDBGv2Z0K4N-dC7H8aA@mail.gmail.com>
At 2023-04-12 04:30:35, "Prashant Malani" <pmalani@chromium.org> wrote:
>Hi Liang He,
>
>Can you please resend this patch? I don't see it in patchwork or the
>mailing list any more.
>
>Thanks!
>
I will resend now, thanks for your work on my patch.
Liang
>On Tue, Mar 21, 2023 at 9:11 PM Liang He <windhl@126.com> wrote:
>>
>> In cros_typec_init_ports(), we should add fwnode_handle_put()
>> when break out of the iteration device_for_each_child_node()
>> as it will automatically increase and decrease the refcounter.
>>
>> Fixes: fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")
>> Signed-off-by: Liang He <windhl@126.com>
>> ---
>> drivers/platform/chrome/cros_ec_typec.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
>> index 2a7ff14dc37e..3a242effc85d 100644
>> --- a/drivers/platform/chrome/cros_ec_typec.c
>> +++ b/drivers/platform/chrome/cros_ec_typec.c
>> @@ -443,6 +443,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)
>> return 0;
>>
>> unregister_ports:
>> + fwnode_handle_put(fwnode);
>> cros_unregister_ports(typec);
>> return ret;
>> }
>> --
>> 2.25.1
>>
prev parent reply other threads:[~2023-04-12 0:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230322041054.1856718-1-windhl@126.com>
2023-03-26 14:48 ` [PATCH] platform/chrome: cros_ec_typec: Add missing fwnode_handle_put() Guenter Roeck
2023-04-11 20:30 ` Prashant Malani
2023-04-12 0:26 ` Liang He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12078fa5.471.18772dbb80b.Coremail.windhl@126.com \
--to=windhl@126.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox