* Re: [PATCH] platform/chrome: cros_ec_typec: Add missing fwnode_handle_put()
[not found] <20230322041054.1856718-1-windhl@126.com>
@ 2023-03-26 14:48 ` Guenter Roeck
2023-04-11 20:30 ` Prashant Malani
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2023-03-26 14:48 UTC (permalink / raw)
To: Liang He; +Cc: pmalani, bleung, groeck, chrome-platform
On Tue, Mar 21, 2023 at 9:11 PM Liang He <windhl@126.com> wrote:
>
> In cros_typec_init_ports(), we should add fwnode_handle_put()
> when break out of the iteration device_for_each_child_node()
> as it will automatically increase and decrease the refcounter.
>
> Fixes: fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")
> Signed-off-by: Liang He <windhl@126.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/platform/chrome/cros_ec_typec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 2a7ff14dc37e..3a242effc85d 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -443,6 +443,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)
> return 0;
>
> unregister_ports:
> + fwnode_handle_put(fwnode);
> cros_unregister_ports(typec);
> return ret;
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/chrome: cros_ec_typec: Add missing fwnode_handle_put()
[not found] <20230322041054.1856718-1-windhl@126.com>
2023-03-26 14:48 ` [PATCH] platform/chrome: cros_ec_typec: Add missing fwnode_handle_put() Guenter Roeck
@ 2023-04-11 20:30 ` Prashant Malani
2023-04-12 0:26 ` Liang He
1 sibling, 1 reply; 3+ messages in thread
From: Prashant Malani @ 2023-04-11 20:30 UTC (permalink / raw)
To: Liang He; +Cc: bleung, groeck, chrome-platform
Hi Liang He,
Can you please resend this patch? I don't see it in patchwork or the
mailing list any more.
Thanks!
On Tue, Mar 21, 2023 at 9:11 PM Liang He <windhl@126.com> wrote:
>
> In cros_typec_init_ports(), we should add fwnode_handle_put()
> when break out of the iteration device_for_each_child_node()
> as it will automatically increase and decrease the refcounter.
>
> Fixes: fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")
> Signed-off-by: Liang He <windhl@126.com>
> ---
> drivers/platform/chrome/cros_ec_typec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 2a7ff14dc37e..3a242effc85d 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -443,6 +443,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)
> return 0;
>
> unregister_ports:
> + fwnode_handle_put(fwnode);
> cros_unregister_ports(typec);
> return ret;
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re:Re: [PATCH] platform/chrome: cros_ec_typec: Add missing fwnode_handle_put()
2023-04-11 20:30 ` Prashant Malani
@ 2023-04-12 0:26 ` Liang He
0 siblings, 0 replies; 3+ messages in thread
From: Liang He @ 2023-04-12 0:26 UTC (permalink / raw)
To: Prashant Malani; +Cc: bleung, groeck, chrome-platform
At 2023-04-12 04:30:35, "Prashant Malani" <pmalani@chromium.org> wrote:
>Hi Liang He,
>
>Can you please resend this patch? I don't see it in patchwork or the
>mailing list any more.
>
>Thanks!
>
I will resend now, thanks for your work on my patch.
Liang
>On Tue, Mar 21, 2023 at 9:11 PM Liang He <windhl@126.com> wrote:
>>
>> In cros_typec_init_ports(), we should add fwnode_handle_put()
>> when break out of the iteration device_for_each_child_node()
>> as it will automatically increase and decrease the refcounter.
>>
>> Fixes: fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")
>> Signed-off-by: Liang He <windhl@126.com>
>> ---
>> drivers/platform/chrome/cros_ec_typec.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
>> index 2a7ff14dc37e..3a242effc85d 100644
>> --- a/drivers/platform/chrome/cros_ec_typec.c
>> +++ b/drivers/platform/chrome/cros_ec_typec.c
>> @@ -443,6 +443,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)
>> return 0;
>>
>> unregister_ports:
>> + fwnode_handle_put(fwnode);
>> cros_unregister_ports(typec);
>> return ret;
>> }
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-12 0:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230322041054.1856718-1-windhl@126.com>
2023-03-26 14:48 ` [PATCH] platform/chrome: cros_ec_typec: Add missing fwnode_handle_put() Guenter Roeck
2023-04-11 20:30 ` Prashant Malani
2023-04-12 0:26 ` Liang He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox