From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC93F157468; Wed, 24 Apr 2024 08:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713948770; cv=none; b=DAhDQNfTpiRXetK1WtZqEBv4P7e5E8EXCJKRMBjdj0+OyLcyqdGR6FqQKj4fPdhMHPRRZvOJxxeJG9YDb5CYp9w1K/Oov/ZUcp7V7PcrPrEPyE/ytDI3/hlKcD4v8cIsVWwpMIebETtEBJOVE/TAxf1UIC9ASHCdeJxrd/KiYTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713948770; c=relaxed/simple; bh=xeFFermW9Sr98hlQ4VV5aZoZPPKK7kRslJqQSK7QTyQ=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=K1ShjykDW2s94P2GAW9ueVCDMd4o40bfpPjFYybYgbqso6K1F+Q/eZz8v40eOstgPRT2Di08P5o7bOE5+K48AQaeHIjniGZdqXq2FGrbrx39dVfcQ+bb2gfIkt7YUQkrQlJORpgCdB95wzVPDzxNzWlu+UmgnUEK+fpJpsGnPhY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qru/Sys7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qru/Sys7" Received: by smtp.kernel.org (Postfix) with ESMTPS id 60587C32781; Wed, 24 Apr 2024 08:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713948770; bh=xeFFermW9Sr98hlQ4VV5aZoZPPKK7kRslJqQSK7QTyQ=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=qru/Sys7v3vRJo1V9qwxutUZDfHsrufFdxuwkssyxwTQY7H2z59klkdktt6T5Lzyv inkPDKXP7VpPaT8sM8W46gVO2naJydK2Twrwp14kKKJAjGpHCHH6+RWE4g8VO7ySzY V03gXL/u0HQ3/Et1Wvy1Gu2T+DmWDk6Czg89yBx+g3fx2UPl2MB/P0u/aUtorfSJqk Oyh2lHdAvaNN5PcnSwo1heU+WxyAM9U66ayXO90wQzf1DUwhSi3Ds3f4vIL74FJBfV H4S7E34pqMIPxBvLoskml/csJuhmhQV6k+duCAQR7rQSUal4FqWALY/knJP+ZsfRls WG3ePO3Bmjbhg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 58305C4339F; Wed, 24 Apr 2024 08:52:50 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] platform/chrome: cros_ec_uart: properly fix race condition From: patchwork-bot+chrome-platform@kernel.org Message-Id: <171394877035.3441.2924475068794719398.git-patchwork-notify@kernel.org> Date: Wed, 24 Apr 2024 08:52:50 +0000 References: <20240410182618.169042-2-noah@noahloomans.com> In-Reply-To: <20240410182618.169042-2-noah@noahloomans.com> To: Noah Loomans Cc: bhanumaiya@chromium.org, bleung@chromium.org, tzungbi@kernel.org, groeck@chromium.org, robertzieba@google.com, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Hello: This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih : On Wed, 10 Apr 2024 20:26:19 +0200 you wrote: > The cros_ec_uart_probe() function calls devm_serdev_device_open() before > it calls serdev_device_set_client_ops(). This can trigger a NULL pointer > dereference: > > BUG: kernel NULL pointer dereference, address: 0000000000000000 > ... > CPU: 5 PID: 103 Comm: kworker/u16:3 Not tainted 6.8.4-zen1-1-zen #1 4a88f2661038c2a3bb69aa70fb41a5735338823c > Hardware name: Google Morphius/Morphius, BIOS MrChromebox-4.22.2-1-g2a93624aebf 01/22/2024 > Workqueue: events_unbound flush_to_ldisc > RIP: 0010:ttyport_receive_buf+0x3f/0xf0 > ... > Call Trace: > > ? __die+0x10f/0x120 > ? page_fault_oops+0x171/0x4e0 > ? srso_return_thunk+0x5/0x5f > ? exc_page_fault+0x7f/0x180 > ? asm_exc_page_fault+0x26/0x30 > ? ttyport_receive_buf+0x3f/0xf0 > flush_to_ldisc+0x9b/0x1c0 > process_one_work+0x17b/0x340 > worker_thread+0x301/0x490 > ? __pfx_worker_thread+0x10/0x10 > kthread+0xe8/0x120 > ? __pfx_kthread+0x10/0x10 > ret_from_fork+0x34/0x50 > ? __pfx_kthread+0x10/0x10 > ret_from_fork_asm+0x1b/0x30 > > > [...] Here is the summary with links: - platform/chrome: cros_ec_uart: properly fix race condition https://git.kernel.org/chrome-platform/c/5e700b384ec1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html