Chrome platform driver development
 help / color / mirror / Atom feed
From: "Dustin L. Howett" <dustin@howett.net>
To: chrome-platform@lists.linux.dev
Cc: Benson Leung <bleung@chromium.org>,
	Aseda Aboagye <aaboagye@chromium.org>,
	Tzung-Bi Shih <tzungbi@google.com>,
	Michael Niksa <michael.niksa@live.com>,
	"Dustin L. Howett" <dustin@howett.net>
Subject: [PATCH v3 0/2] platform/chrome: add support for the Framework Laptop
Date: Thu, 17 Feb 2022 10:59:28 -0600	[thread overview]
Message-ID: <20220217165930.15081-1-dustin@howett.net> (raw)

This series adds support for the Framework Laptop to the cros_ec LPC
driver.

The Framework Laptop is a non-Chromebook laptop that uses the ChromeOS
Embedded Controller. Since the machine was designed to present a more
normal device profile, it does not report all 512 I/O ports that are
typically used by cros_ec_lpcs. Because of this, changes to the driver's
port reservation scheme were required.

Since this EC driver probes the MEC range first, and uses only the MEC
range if that probe succeeds[^1], we can get by without requesting the
entire port range required by non-MEC embedded controllers until
absolutely necessary.

[^1]: this includes "memory mapped" read - where the traditional LPC EC
requires I/O ports 0x900-0x9FF, the MEC EC multiplexes reads/writes
over the same eight ports, 0x800-0x807.

Changes in v2:
  - Cleaned up the commit subjects per request.
Changes in v3:
  - Sync'd cros_ec_commands.h with the EC changelist at
    https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3460548

Dustin L. Howett (2):
  platform/chrome: cros_ec_lpcs: detect the Framework Laptop
  platform/chrome: cros_ec_lpcs: reserve the MEC LPC I/O ports first

 drivers/platform/chrome/cros_ec_lpc.c          | 47 ++++++++++++++-----
 include/linux/platform_data/cros_ec_commands.h | 10 ++--
 2 files changed, 41 insertions(+), 16 deletions(-)

-- 
2.34.1


             reply	other threads:[~2022-02-17 16:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17 16:59 Dustin L. Howett [this message]
2022-02-17 16:59 ` [PATCH v3 1/2] platform/chrome: cros_ec_lpcs: detect the Framework Laptop Dustin L. Howett
2022-02-17 16:59 ` [PATCH v3 2/2] platform/chrome: cros_ec_lpcs: reserve the MEC LPC I/O ports first Dustin L. Howett
2022-02-18  2:32 ` [PATCH v3 0/2] platform/chrome: add support for the Framework Laptop Tzung-Bi Shih
2022-05-03  6:10 ` patchwork-bot+chrome-platform
2022-05-04  2:20 ` patchwork-bot+chrome-platform

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220217165930.15081-1-dustin@howett.net \
    --to=dustin@howett.net \
    --cc=aaboagye@chromium.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=michael.niksa@live.com \
    --cc=tzungbi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox