Chrome platform driver development
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: bleung@chromium.org, groeck@chromium.org
Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 15/23] platform/chrome: cros_ec_proto: don't show MKBP version if unsupported
Date: Wed,  8 Jun 2022 11:07:26 +0000	[thread overview]
Message-ID: <20220608110734.2928245-16-tzungbi@kernel.org> (raw)
In-Reply-To: <20220608110734.2928245-1-tzungbi@kernel.org>

It wrongly showed the following message when it doesn't support MKBP:
"MKBP support version 4294967295".

Fix it.

Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
Changes from v2:
- Add R-b tag.

 drivers/platform/chrome/cros_ec_proto.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
index 8a53e989c7e2..efbabdcb31ae 100644
--- a/drivers/platform/chrome/cros_ec_proto.c
+++ b/drivers/platform/chrome/cros_ec_proto.c
@@ -508,13 +508,13 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev)
 	ret = cros_ec_get_host_command_version_mask(ec_dev,
 						    EC_CMD_GET_NEXT_EVENT,
 						    &ver_mask);
-	if (ret < 0 || ver_mask == 0)
+	if (ret < 0 || ver_mask == 0) {
 		ec_dev->mkbp_event_supported = 0;
-	else
+	} else {
 		ec_dev->mkbp_event_supported = fls(ver_mask);
 
-	dev_dbg(ec_dev->dev, "MKBP support version %u\n",
-		ec_dev->mkbp_event_supported - 1);
+		dev_dbg(ec_dev->dev, "MKBP support version %u\n", ec_dev->mkbp_event_supported - 1);
+	}
 
 	/* Probe if host sleep v1 is supported for S0ix failure detection. */
 	ret = cros_ec_get_host_command_version_mask(ec_dev,
-- 
2.36.1.255.ge46751e96f-goog


  parent reply	other threads:[~2022-06-08 11:08 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08 11:07 [PATCH v3 00/23] platform/chrome: Kunit tests and refactor for cros_ec_query_all() Tzung-Bi Shih
2022-06-08 11:07 ` [PATCH v3 01/23] platform/chrome: cros_ec_commands: fix compile errors Tzung-Bi Shih
2022-06-08 11:07 ` [PATCH v3 02/23] platform/chrome: cros_ec_proto: add Kunit tests for cros_ec_query_all() Tzung-Bi Shih
2022-06-08 16:12   ` Guenter Roeck
2022-06-08 11:07 ` [PATCH v3 03/23] platform/chrome: use macros for passthru indexes Tzung-Bi Shih
2022-06-08 11:07 ` [PATCH v3 04/23] platform/chrome: cros_ec_proto: assign buffer size from protocol info Tzung-Bi Shih
2022-06-08 11:07 ` [PATCH v3 05/23] platform/chrome: cros_ec_proto: remove redundant NULL check Tzung-Bi Shih
2022-06-08 11:07 ` [PATCH v3 06/23] platform/chrome: cros_ec_proto: use cros_ec_map_error() Tzung-Bi Shih
2022-06-08 11:07 ` [PATCH v3 07/23] platform/chrome: cros_ec_proto: separate cros_ec_get_proto_info() Tzung-Bi Shih
2022-06-08 11:07 ` [PATCH v3 08/23] platform/chrome: cros_ec_proto: add Kunit tests for getting proto info Tzung-Bi Shih
2022-06-08 16:13   ` Guenter Roeck
2022-06-08 11:07 ` [PATCH v3 09/23] platform/chrome: cros_ec_proto: handle empty payload in " Tzung-Bi Shih
2022-06-08 16:13   ` Guenter Roeck
2022-06-08 11:07 ` [PATCH v3 10/23] platform/chrome: cros_ec_proto: separate cros_ec_get_proto_info_legacy() Tzung-Bi Shih
2022-06-08 11:07 ` [PATCH v3 11/23] platform/chrome: cros_ec_proto: add Kunit test for getting legacy info Tzung-Bi Shih
2022-06-08 16:14   ` Guenter Roeck
2022-06-08 11:07 ` [PATCH v3 12/23] platform/chrome: cros_ec_proto: handle empty payload in getting info legacy Tzung-Bi Shih
2022-06-08 16:14   ` Guenter Roeck
2022-06-08 11:07 ` [PATCH v3 13/23] platform/chrome: cros_ec: don't allocate `din` and `dout` in cros_ec_register() Tzung-Bi Shih
2022-06-08 16:15   ` Guenter Roeck
2022-06-09  5:09     ` Tzung-Bi Shih
2022-06-08 11:07 ` [PATCH v3 14/23] platform/chrome: don't use devm variants for `din` and `dout` Tzung-Bi Shih
2022-06-08 16:17   ` Guenter Roeck
2022-06-08 11:07 ` Tzung-Bi Shih [this message]
2022-06-08 11:07 ` [PATCH v3 16/23] platform/chrome: cros_ec_proto: return 0 on getting cmd mask success Tzung-Bi Shih
2022-06-08 16:20   ` Guenter Roeck
2022-06-09  8:44     ` Tzung-Bi Shih
2022-06-08 11:07 ` [PATCH v3 17/23] platform/chrome: cros_ec_proto: add Kunit test for getting cmd mask error Tzung-Bi Shih
2022-06-08 16:21   ` Guenter Roeck
2022-06-08 11:07 ` [PATCH v3 18/23] platform/chrome: cros_ec_proto: check `msg->result` in getting cmd mask Tzung-Bi Shih
2022-06-08 16:23   ` Guenter Roeck
2022-06-08 16:27     ` Guenter Roeck
2022-06-08 11:07 ` [PATCH v3 19/23] platform/chrome: cros_ec_proto: add Kunit tests for " Tzung-Bi Shih
2022-06-08 16:28   ` Guenter Roeck
2022-06-08 11:07 ` [PATCH v3 20/23] platform/chrome: cros_ec_proto: handle empty payload in " Tzung-Bi Shih
2022-06-08 16:24   ` Guenter Roeck
2022-06-08 11:07 ` [PATCH v3 21/23] platform/chrome: cros_ec_proto: return 0 on getting wake mask success Tzung-Bi Shih
2022-06-08 16:26   ` Guenter Roeck
2022-06-08 11:07 ` [PATCH v3 22/23] platform/chrome: cros_ec_proto: add Kunit test for getting wake mask Tzung-Bi Shih
2022-06-08 16:29   ` Guenter Roeck
2022-06-08 11:07 ` [PATCH v3 23/23] platform/chrome: cros_ec_proto: handle empty payload in " Tzung-Bi Shih
2022-06-08 16:30   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220608110734.2928245-16-tzungbi@kernel.org \
    --to=tzungbi@kernel.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox