From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DB517B; Wed, 29 Jun 2022 09:21:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A6A5C34114; Wed, 29 Jun 2022 09:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656494506; bh=HQ25Ow2lpsqgoUrUW/nG+URV4v3uVvi69tP+dqJVwS8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KDGJ+ZX0QDwKOanqLEHq4R3Rgk4gw7YBpXQ1tp5J2PbFlN9SFFfxpykmheKoDEBKH GZdb6/Vu19P209bnRNGK3ZFDu4CTBf7M/1tGbAgk0qvALDE6m6bUxa1i55igZp5mYn M9nKXnXHahfEJ1/gD9uIZsD8u8SACyrjQAA5RstBhscMb/v3jVsSe8amKh8qkDuMrS GSpJXwgYiOg6nUIYiiXl948rxcrWW3Rc1By0vwkqaGsbNa0kxgo7uX8LQpEE5EFJvC lXPBmC+HFU37tkvSye7TN5YXt1OC7tohvK8VYqANalwO76xOIXwCRjtMw86pXFhld/ h03Us4Elobz6g== Date: Wed, 29 Jun 2022 11:20:42 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Wolfram Sang , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Sekhar Nori , Bartosz Golaszewski , Russell King , Scott Wood , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Robin van der Gracht , Miguel Ojeda , Corey Minyard , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Max Filippov , Michael Turquette , Stephen Boyd , Luca Ceresoli , Tudor Ambarus , Herbert Xu , "David S. Miller" , MyungJoo Ham , Chanwoo Choi , Michael Hennerich , Linus Walleij , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Benson Leung , Guenter Roeck , Phong LE , Adrien Grassein , Peter Senna Tschudin , Martin Donnelly , Martyn Welch , Douglas Anderson , Stefan Mavrodiev , Thierry Reding , Sam Ravnborg , Florian Fainelli , Broadcom internal kernel review list , Javier Martinez Canillas , Jiri Kosina , Benjamin Tissoires , Jean Delvare , George Joseph , Juerg Haefliger , Riku Voipio , Robert Marko , Luka Perkov , Marc Hulsman , Rudolf Marek , Peter Rosin , Jonathan Cameron , Lars-Peter Clausen , Dan Robertson , Rui Miguel Silva , Tomasz Duszynski , Kevin Tsai , Crt Mori , Dmitry Torokhov , Nick Dyer , Bastien Nocera , Hans de Goede , Maxime Coquelin , Alexandre Torgue , Sakari Ailus , Pavel Machek , Jan-Simon Moeller , Colin Leroy , Joe Tessler , Hans Verkuil , Mauro Carvalho Chehab , Antti Palosaari , Jasmin Jessich , Matthias Schwarzott , Olli Salonen , Akihiro Tsukada , Kieran Bingham , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Martin Kepplinger , Ricardo Ribalda , Dave Stevenson , Leon Luo , Manivannan Sadhasivam , Bingbu Cao , "Paul J. Murphy" , Daniele Alessandrelli , Michael Tretter , Pengutronix Kernel Team , Kyungmin Park , Heungjun Kim , Ramesh Shanmugasundaram , Jacopo Mondi , Niklas =?UTF-8?B?U8O2ZGVybHVuZA==?= , Jimmy Su , Arec Kao , "Lad, Prabhakar" , Shunqian Zheng , Steve Longerbeam , Chiranjeevi Rapolu , Daniel Scally , Wenyou Yang , Petr Cvek , Akinobu Mita , Sylwester Nawrocki , Benjamin Mugnier , Sylvain Petinot , Mats Randgaard , Tim Harvey , Matt Ranostay , Eduardo Valentin , "Daniel W. S. Almeida" , Lee Jones , Chen-Yu Tsai , Support Opensource , Robert Jones , Andy Shevchenko , Charles Keepax , Richard Fitzgerald , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Tony Lindgren , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Woojung Huh , UNGLinuxDriver@microchip.com, George McCollister , Ido Schimmel , Petr Machata , Jeremy Kerr , Matt Johnston , Charles Gorand , Krzysztof Opasiak , Rob Herring , Frank Rowand , Mark Gross , Maximilian Luz , Corentin Chary , Pali =?UTF-8?B?Um9ow6Fy?= , Sebastian Reichel , Tobias Schrammm , Liam Girdwood , Mark Brown , Alessandro Zummo , Jens Frederich , Jon Nettleton , Jiri Slaby , Felipe Balbi , Heikki Krogerus , Daniel Thompson , Jingoo Han , Helge Deller , Evgeniy Polyakov , Wim Van Sebroeck , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Johannes Berg , Jaroslav Kysela , Takashi Iwai , James Schulman , David Rhodes , Lucas Tanure , Nuno =?UTF-8?B?U8Oh?= , Matthias Brugger , Oder Chiou , Fabio Estevam , Kevin Cernekee , Christophe Leroy , Maxime Ripard , Alvin =?UTF-8?B?xaBpcHJhZ2E=?= , Lucas Stach , Jagan Teki , Biju Das , Thomas Zimmermann , Alex Deucher , Lyude Paul , Xin Ji , Hsin-Yi Wang , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , Yang Li , Angela Czubak , Alistair Francis , Eddie James , Joel Stanley , Nathan Chancellor , Antoniu Miclaus , Alexandru Ardelean , Dmitry Rokosov , Srinivas Pandruvada , Stephan Gerhold , Miaoqian Lin , Gwendal Grignou , Yang Yingliang , Paul Cercueil , Daniel Palmer , Haibo Chen , Cai Huoqing , Marek Vasut , Jose Cazarin , Dan Carpenter , Jean-Baptiste Maneyrol , Michael Srba , Nikita Travkin , Maslov Dmitry , Jiri Valek - 2N , Arnaud Ferraris , Zheyu Ma , Marco Felsch , Oliver Graute , Zheng Yongjun , CGEL ZTE , Minghao Chi , Evgeny Novikov , Sean Young , Kirill Shilimanov , Moses Christopher Bollavarapu , Paul Kocialkowski , Janusz Krzysztofik , Dongliang Mu , Colin Ian King , lijian , Kees Cook , Yan Lei , Heiner Kallweit , Jonas Malaco , wengjianfeng , Rikard Falkeborn , Wei Yongjun , Tom Rix , Yizhuo , Martiros Shakhzadyan , Bjorn Andersson , Sven Peter , Alyssa Rosenzweig , Hector Martin , Saranya Gopal , Guido =?UTF-8?B?R8O8bnRoZXI=?= , Sing-Han Chen , Wayne Chang , Geert Uytterhoeven , Alexey Dobriyan , Masahiro Yamada , Vincent Knecht , Stephen Kitt , Pierre-Louis Bossart , Alexey Khoroshilov , Randy Dunlap , Alejandro Tafalla , Vijendar Mukunda , Seven Lee , Mac Chiang , David Lin , Daniel Beer , Ricard Wanderlof , Simon Trimmer , Shengjiu Wang , Viorel Suman , Nicola Lunghi , Adam Ford , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, chrome-platform@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, kasan-dev@googlegroups.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220629112042.221af80b@thinkpad> In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 28 Jun 2022 16:03:12 +0200 Uwe Kleine-K=C3=B6nig wrote: > From: Uwe Kleine-K=C3=B6nig >=20 > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig For > drivers/leds/leds-turris-omnia.c | 4 +--- Acked-by: Marek Beh=C3=BAn