From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 687352917; Tue, 5 Jul 2022 20:12:03 +0000 (UTC) Received: by mail-qk1-f182.google.com with SMTP id z7so9574863qko.8; Tue, 05 Jul 2022 13:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=OTC6txqtQct8PJfU00O4zbYgNzmzFUtn37nCnhn8x1k=; b=jzyDqqOsmOiFQpBNDEIIiq2MN35QtJrUD2/ujzSWycMbbCOOa/kXWzucbOzXvgJPlM l41OpTnwJFtVKAh9ESeTZGx5QRNGnFLf7Ve6XK/dYXbRSWYolxdZFruwb2QvUjtDqKp3 XPq8C5Jcp4JG3opZdh2U+imHALhK3sBAHCCrGSqp8Vv6nsMRfMt39kYqHYOSFDIblB6A qByLsJ7MJ8hdI1n2d+9GcDpXsaJ8cJ751FUYmiFAN8pTN8GWtaPdCiQlJR4UCA74w7VK BYLuDVNV9YmL+YjlB3aU/m2FQ5afMCy9VI/vJGznIenuOAJI2wSPMGBH0t9pzT1ABtei oFrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=OTC6txqtQct8PJfU00O4zbYgNzmzFUtn37nCnhn8x1k=; b=VRB4jzbiyfT6+8QpG/VI1vp7kjlBK2dJydmI7Rw4VtpE5JfCX81lUn0ZFSf8RRWDQC Jg2z2I0Cc5j3nGHd3KuAatWtqdG29FJWQ1uZVz0YYHRaqhkuxrQhHKAan2xUmu8bNu1G MNJhmS4uG4mpk7AwOpBgohtBBCDqY9NqQeeuu0Zwv098jUt4t2QkwIfAHqBrsoOH3NhD 2x4cTTkvO9icmAis1Q4vYYkUP4HaPjxN6QYu+Gc8OBPQF00kIdeBULkeUH1fz2n+ijJI AXXXI1YpB2d1TEp4PhTADRnU+1q6V/cA0dhFR/NBAX408AvT0WYi95bgYoK+nYVypSXi lc3A== X-Gm-Message-State: AJIora/wpRvMKgGq7tjDtBzfjUdKm8orvckt2wHPSU4VRmpCgcCyrTHb NzG8HLE+1Zs8pEhaN8rv2Q== X-Google-Smtp-Source: AGRyM1v0OJ93Nu3s63zVNhYbXwTamj5LdNYK8gxlMvIKZ0kjVcSqwnmSr3p+XEHk7rqxFSougreCpA== X-Received: by 2002:a05:620a:385:b0:6af:1f2b:9168 with SMTP id q5-20020a05620a038500b006af1f2b9168mr24692503qkm.170.1657051922136; Tue, 05 Jul 2022 13:12:02 -0700 (PDT) Received: from serve.minyard.net ([47.184.144.75]) by smtp.gmail.com with ESMTPSA id r8-20020a05620a298800b006b4689e3425sm5643578qkp.129.2022.07.05.13.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 13:12:01 -0700 (PDT) Sender: Corey Minyard Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:1895:1b49:2a68:29f7]) by serve.minyard.net (Postfix) with ESMTPSA id B3B861800BD; Tue, 5 Jul 2022 20:11:57 +0000 (UTC) Date: Tue, 5 Jul 2022 15:11:56 -0500 From: Corey Minyard To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Wolfram Sang , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Sekhar Nori , Bartosz Golaszewski , Russell King , Scott Wood , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Robin van der Gracht , Miguel Ojeda , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Max Filippov , Michael Turquette , Stephen Boyd , Luca Ceresoli , Tudor Ambarus , Herbert Xu , "David S. Miller" , MyungJoo Ham , Chanwoo Choi , Michael Hennerich , Linus Walleij , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Benson Leung , Guenter Roeck , Phong LE , Adrien Grassein , Peter Senna Tschudin , Martin Donnelly , Martyn Welch , Douglas Anderson , Stefan Mavrodiev , Thierry Reding , Sam Ravnborg , Florian Fainelli , Broadcom internal kernel review list , Javier Martinez Canillas , Jiri Kosina , Benjamin Tissoires , Jean Delvare , George Joseph , Juerg Haefliger , Riku Voipio , Robert Marko , Luka Perkov , Marc Hulsman , Rudolf Marek , Peter Rosin , Jonathan Cameron , Lars-Peter Clausen , Dan Robertson , Rui Miguel Silva , Tomasz Duszynski , Kevin Tsai , Crt Mori , Dmitry Torokhov , Nick Dyer , Bastien Nocera , Hans de Goede , Maxime Coquelin , Alexandre Torgue , Sakari Ailus , Pavel Machek , Jan-Simon Moeller , Marek =?utf-8?B?QmVow7pu?= , Colin Leroy , Joe Tessler , Hans Verkuil , Mauro Carvalho Chehab , Antti Palosaari , Jasmin Jessich , Matthias Schwarzott , Olli Salonen , Akihiro Tsukada , Kieran Bingham , Tianshu Qiu , Dongchun Zhu , Shawn Tu , Martin Kepplinger , Ricardo Ribalda , Dave Stevenson , Leon Luo , Manivannan Sadhasivam , Bingbu Cao , "Paul J. Murphy" , Daniele Alessandrelli , Michael Tretter , Pengutronix Kernel Team , Kyungmin Park , Heungjun Kim , Ramesh Shanmugasundaram , Jacopo Mondi , Niklas =?utf-8?Q?S=C3=B6derlund?= , Jimmy Su , Arec Kao , "Lad, Prabhakar" , Shunqian Zheng , Steve Longerbeam , Chiranjeevi Rapolu , Daniel Scally , Wenyou Yang , Petr Cvek , Akinobu Mita , Sylwester Nawrocki , Benjamin Mugnier , Sylvain Petinot , Mats Randgaard , Tim Harvey , Matt Ranostay , Eduardo Valentin , "Daniel W. S. Almeida" , Lee Jones , Chen-Yu Tsai , Support Opensource , Robert Jones , Andy Shevchenko , Charles Keepax , Richard Fitzgerald , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Tony Lindgren , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Woojung Huh , UNGLinuxDriver@microchip.com, George McCollister , Ido Schimmel , Petr Machata , Jeremy Kerr , Matt Johnston , Charles Gorand , Krzysztof Opasiak , Rob Herring , Frank Rowand , Mark Gross , Maximilian Luz , Corentin Chary , Pali =?utf-8?B?Um9ow6Fy?= , Sebastian Reichel , Tobias Schrammm , Liam Girdwood , Mark Brown , Alessandro Zummo , Jens Frederich , Jon Nettleton , Jiri Slaby , Felipe Balbi , Heikki Krogerus , Daniel Thompson , Jingoo Han , Helge Deller , Evgeniy Polyakov , Wim Van Sebroeck , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Johannes Berg , Jaroslav Kysela , Takashi Iwai , James Schulman , David Rhodes , Lucas Tanure , Nuno =?utf-8?B?U8Oh?= , Matthias Brugger , Oder Chiou , Fabio Estevam , Kevin Cernekee , Christophe Leroy , Maxime Ripard , Alvin =?utf-8?Q?=C5=A0ipraga?= , Lucas Stach , Jagan Teki , Biju Das , Thomas Zimmermann , Alex Deucher , Lyude Paul , Xin Ji , Hsin-Yi Wang , =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= , Yang Li , Angela Czubak , Alistair Francis , Eddie James , Joel Stanley , Nathan Chancellor , Antoniu Miclaus , Alexandru Ardelean , Dmitry Rokosov , Srinivas Pandruvada , Stephan Gerhold , Miaoqian Lin , Gwendal Grignou , Yang Yingliang , Paul Cercueil , Daniel Palmer , Haibo Chen , Cai Huoqing , Marek Vasut , Jose Cazarin , Dan Carpenter , Jean-Baptiste Maneyrol , Michael Srba , Nikita Travkin , Maslov Dmitry , Jiri Valek - 2N , Arnaud Ferraris , Zheyu Ma , Marco Felsch , Oliver Graute , Zheng Yongjun , CGEL ZTE , Minghao Chi , Evgeny Novikov , Sean Young , Kirill Shilimanov , Moses Christopher Bollavarapu , Paul Kocialkowski , Janusz Krzysztofik , Dongliang Mu , Colin Ian King , lijian , Kees Cook , Yan Lei , Heiner Kallweit , Jonas Malaco , wengjianfeng , Rikard Falkeborn , Wei Yongjun , Tom Rix , Yizhuo , Martiros Shakhzadyan , Bjorn Andersson , Sven Peter , Alyssa Rosenzweig , Hector Martin , Saranya Gopal , Guido =?utf-8?Q?G=C3=BCnther?= , Sing-Han Chen , Wayne Chang , Geert Uytterhoeven , Alexey Dobriyan , Masahiro Yamada , Vincent Knecht , Stephen Kitt , Pierre-Louis Bossart , Alexey Khoroshilov , Randy Dunlap , Alejandro Tafalla , Vijendar Mukunda , Seven Lee , Mac Chiang , David Lin , Daniel Beer , Ricard Wanderlof , Simon Trimmer , Shengjiu Wang , Viorel Suman , Nicola Lunghi , Adam Ford , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, chrome-platform@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, kasan-dev@googlegroups.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220705201156.GL908082@minyard.net> Reply-To: minyard@acm.org References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> On Tue, Jun 28, 2022 at 04:03:12PM +0200, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. For IPMI portions below: Acked-by: Corey Minyard > > static const struct i2c_device_id lcd2s_i2c_id[] = { > diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c > index db40037eb347..a0e9e80d92ee 100644 > --- a/drivers/char/ipmi/ipmb_dev_int.c > +++ b/drivers/char/ipmi/ipmb_dev_int.c > @@ -341,14 +341,12 @@ static int ipmb_probe(struct i2c_client *client) > return 0; > } > > -static int ipmb_remove(struct i2c_client *client) > +static void ipmb_remove(struct i2c_client *client) > { > struct ipmb_dev *ipmb_dev = i2c_get_clientdata(client); > > i2c_slave_unregister(client); > misc_deregister(&ipmb_dev->miscdev); > - > - return 0; > } > > static const struct i2c_device_id ipmb_id[] = { > diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c > index ab19b4b3317e..25c010c9ec25 100644 > --- a/drivers/char/ipmi/ipmi_ipmb.c > +++ b/drivers/char/ipmi/ipmi_ipmb.c > @@ -424,7 +424,7 @@ static void ipmi_ipmb_request_events(void *send_info) > /* We don't fetch events here. */ > } > > -static int ipmi_ipmb_remove(struct i2c_client *client) > +static void ipmi_ipmb_remove(struct i2c_client *client) > { > struct ipmi_ipmb_dev *iidev = i2c_get_clientdata(client); > > @@ -438,8 +438,6 @@ static int ipmi_ipmb_remove(struct i2c_client *client) > ipmi_ipmb_stop_thread(iidev); > > ipmi_unregister_smi(iidev->intf); > - > - return 0; > } > > static int ipmi_ipmb_probe(struct i2c_client *client) > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index fc742ee9c046..13da021e7c6b 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1281,13 +1281,13 @@ static void shutdown_ssif(void *send_info) > } > } > > -static int ssif_remove(struct i2c_client *client) > +static void ssif_remove(struct i2c_client *client) > { > struct ssif_info *ssif_info = i2c_get_clientdata(client); > struct ssif_addr_info *addr_info; > > if (!ssif_info) > - return 0; > + return; > > /* > * After this point, we won't deliver anything asychronously > @@ -1303,8 +1303,6 @@ static int ssif_remove(struct i2c_client *client) > } > > kfree(ssif_info); > - > - return 0; > } > > static int read_response(struct i2c_client *client, unsigned char *resp)